Commit c9f66577 authored by Regan Hsu's avatar Regan Hsu Committed by Commit Bot

[OsSettingsSearch] Remove navigated to route announcement.

Do not announce a route has been navigated to when a OS Settings search
result is clicked/entered upon.

Fixed: 1071283
Change-Id: I522643ffa7d18afd49699eb83e6dabb7e059261b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158685
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762090}
parent a35bc5d0
......@@ -23,9 +23,6 @@
<message name="IDS_OS_SEARCH_RESULT_ROW_A11Y_RESULT_SELECTED" desc="ChromeVox alert to indicate the position number of a selected result in a list of search results and the selected result text itself, and that the user can press enter to navigate to section described by the search result.">
Search result <ph name="LIST_POSITION">$1<ex>1</ex></ph> of <ph name="LIST_SIZE">$2<ex>2</ex></ph>: <ph name="SEARCH_RESULT_TEXT">$3<ex>Network Settings</ex></ph>. Press Enter to navigate to section.
</message>
<message name="IDS_OS_SEARCH_RESULT_ROW_A11Y_NAVIGATED_TO_RESULT" desc="ChromeVox alert to indicate that the user has navigated to a search result after having clicked or pressed enter on a search result.">
Navigated to <ph name="SEARCH_RESULT_TEXT">$1<ex>Network Settings</ex></ph>.
</message>
<message name="IDS_OS_SEARCH_BOX_A11Y_ONE_RESULT" desc="ChromeVox alert to indicate the that one search result has been found.">
Displaying 1 search result for <ph name="QUERY">$1<ex>Wi-Fi</ex>.</ph>
</message>
......
......@@ -339,13 +339,7 @@ cr.define('settings', function() {
new URLSearchParams(pathAndOptParams[1]) :
undefined;
// TODO(crbug/1071283): The announcement should occur before any
// announcements at the new route.
this.fire(
'iron-announce',
{text: this.i18n('searchResultNavigatedTo', this.resultText_)});
settings.Router.getInstance().navigateTo(route, params);
this.fire('navigated-to-result-route');
},
......
......@@ -903,8 +903,6 @@ void AddSearchInSettingsStrings(content::WebUIDataSource* html_source) {
{"searchNoResults", IDS_SEARCH_NO_RESULTS},
{"searchResults", IDS_SEARCH_RESULTS},
{"searchResultSelected", IDS_OS_SEARCH_RESULT_ROW_A11Y_RESULT_SELECTED},
{"searchResultNavigatedTo",
IDS_OS_SEARCH_RESULT_ROW_A11Y_NAVIGATED_TO_RESULT},
{"searchResultsOne", IDS_OS_SEARCH_BOX_A11Y_ONE_RESULT},
{"searchResultsNumber", IDS_OS_SEARCH_BOX_A11Y_RESULT_COUNT},
// TODO(dpapad): IDS_DOWNLOAD_CLEAR_SEARCH and IDS_HISTORY_CLEAR_SEARCH
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment