Commit c9fb3206 authored by Manuel Rego Casasnovas's avatar Manuel Rego Casasnovas Committed by Commit Bot

Simplify DCHECK at IsContainingBlockForCandidate()

Use CanContainOutOfFlowPositionedElement() to simplify a DCHECK
at NGOutOfFlowLayoutPart::IsContainingBlockForCandidate().
The call to CanContainOutOfFlowPositionedElement() is equivalent
to the previous code.

Change-Id: I361e368729dd5231b3cc5dc52492b01ba4336ac3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526321
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: default avatarIan Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825359}
parent 24ca2630
...@@ -1022,11 +1022,8 @@ bool NGOutOfFlowLayoutPart::IsContainingBlockForCandidate( ...@@ -1022,11 +1022,8 @@ bool NGOutOfFlowLayoutPart::IsContainingBlockForCandidate(
// Candidates whose containing block is inline are always positioned inside // Candidates whose containing block is inline are always positioned inside
// closest parent block flow. // closest parent block flow.
if (candidate.inline_container) { if (candidate.inline_container) {
DCHECK( DCHECK(candidate.inline_container->CanContainOutOfFlowPositionedElement(
candidate.node.Style().GetPosition() == EPosition::kAbsolute && candidate.node.Style().GetPosition()));
candidate.inline_container->CanContainAbsolutePositionObjects() ||
(candidate.node.Style().GetPosition() == EPosition::kFixed &&
candidate.inline_container->CanContainFixedPositionObjects()));
return container_builder_->GetLayoutObject() == return container_builder_->GetLayoutObject() ==
candidate.node.GetLayoutBox()->ContainingBlock(); candidate.node.GetLayoutBox()->ContainingBlock();
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment