Commit ca399a94 authored by Makoto Shimazu's avatar Makoto Shimazu Committed by Commit Bot

NetS13nServiceWorker: Remove NOTREACHED in ProceedWithResponse

ProceedWithResponse doesn't have to be implemented for
ServiceWorkerNavigationLoader since it's not using MojoAsyncResourceHandler.
This CL just removes the NOTREACHED() there.

Bug: 822131
Change-Id: I5fb97dd8c0a0428b642f74368409b787e47f9315
Reviewed-on: https://chromium-review.googlesource.com/994496Reviewed-by: default avatarKinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548364}
parent 1c1627f7
...@@ -321,9 +321,6 @@ void ServiceWorkerNavigationLoader::StartResponse( ...@@ -321,9 +321,6 @@ void ServiceWorkerNavigationLoader::StartResponse(
// We have a non-redirect response. Send the headers to the client. // We have a non-redirect response. Send the headers to the client.
CommitResponseHeaders(); CommitResponseHeaders();
// S13nServiceWorker without NetworkService:
// TODO(shimazu): Wait to respond body until ProceedWithResponse().
// Handle a stream response body. // Handle a stream response body.
if (!body_as_stream.is_null() && body_as_stream->stream.is_valid()) { if (!body_as_stream.is_null() && body_as_stream->stream.is_valid()) {
stream_waiter_ = std::make_unique<StreamWaiter>( stream_waiter_ = std::make_unique<StreamWaiter>(
...@@ -372,9 +369,9 @@ void ServiceWorkerNavigationLoader::FollowRedirect() { ...@@ -372,9 +369,9 @@ void ServiceWorkerNavigationLoader::FollowRedirect() {
} }
void ServiceWorkerNavigationLoader::ProceedWithResponse() { void ServiceWorkerNavigationLoader::ProceedWithResponse() {
// TODO(arthursonzogni): Implement this for navigation requests if the // ServiceWorkerNavigationLoader doesn't need to wait for
// ServiceWorker service is enabled before the Network Service. // ProceedWithResponse() since it doesn't use MojoAsyncResourceHandler to load
NOTREACHED(); // the resource request.
} }
void ServiceWorkerNavigationLoader::SetPriority(net::RequestPriority priority, void ServiceWorkerNavigationLoader::SetPriority(net::RequestPriority priority,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment