Commit ca3fca53 authored by Gauthier Ambard's avatar Gauthier Ambard Committed by Commit Bot

Remove DCHECK in popupMenuCoordinator

This CL removes the DCHECK in the popupMenuCoordinator in the callback
at the end of the presentation of the popup menu.
The DCHECK can be triggered by dismissing the popup menu before the end
of the animation.

Bug: 834957
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ic507735290e56ab80b3ae7b9e9f74abf0ae35722
Reviewed-on: https://chromium-review.googlesource.com/1025096Reviewed-by: default avatarOlivier Robin <olivierrobin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553095}
parent 6b1bfc1f
...@@ -123,7 +123,9 @@ PopupMenuCommandType CommandTypeFromPopupType(PopupMenuType type) { ...@@ -123,7 +123,9 @@ PopupMenuCommandType CommandTypeFromPopupType(PopupMenuType type) {
#pragma mark - ContainedPresenterDelegate #pragma mark - ContainedPresenterDelegate
- (void)containedPresenterDidPresent:(id<ContainedPresenter>)presenter { - (void)containedPresenterDidPresent:(id<ContainedPresenter>)presenter {
DCHECK(presenter == self.presenter); if (presenter != self.presenter)
return;
if (self.requestStartTime != 0) { if (self.requestStartTime != 0) {
base::TimeDelta elapsed = base::TimeDelta::FromSecondsD( base::TimeDelta elapsed = base::TimeDelta::FromSecondsD(
[NSDate timeIntervalSinceReferenceDate] - self.requestStartTime); [NSDate timeIntervalSinceReferenceDate] - self.requestStartTime);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment