Defrag QuicStreamFactory methods, and rename test-only method.

The QuicStreamFactory methods definition order was completely different
from the declaration order in the header. This CL fixes that. It also
renames the test-only method CryptoConfigCacheIsEmpty() to
CryptoConfigCacheIsEmptyForTesting().

This CL doesn't actually change any code, other than the rename and
moving stuff around.

Bug: 1003423
Change-Id: I751d656cf24b41e206414be04958ac52cf4a9faf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819352Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698980}

net/quic/quic_stream_factory.h

@@ -566,10 +566,6 @@ class NET_EXPORT_PRIVATE QuicStreamFactory
   // Helper methods.
   bool WasQuicRecentlyBroken(const QuicSessionKey& session_key) const;
 
-  bool CryptoConfigCacheIsEmpty(
-      const quic::QuicServerId& server_id,
-      const NetworkIsolationKey& network_isolation_key);
-
   // Starts an asynchronous job for cert verification if
   // |params_.race_cert_verification| is enabled and if there are cached certs
   // for the given |server_id|.
@@ -630,6 +626,10 @@ class NET_EXPORT_PRIVATE QuicStreamFactory
       int cert_verify_flags,
       const NetLogWithSource& net_log);
 
+  bool CryptoConfigCacheIsEmptyForTesting(
+      const quic::QuicServerId& server_id,
+      const NetworkIsolationKey& network_isolation_key);
+
   // Whether QUIC is known to work on current network. This is true when QUIC is
   // expected to work in general, rather than whether QUIC was broken / recently
   // broken when used with a particular server. That information is stored in

net/quic/quic_stream_factory_peer.cc

@@ -152,8 +152,8 @@ bool QuicStreamFactoryPeer::CryptoConfigCacheIsEmpty(
     QuicStreamFactory* factory,
     const quic::QuicServerId& quic_server_id,
     const NetworkIsolationKey& network_isolation_key) {
-  return factory->CryptoConfigCacheIsEmpty(quic_server_id,
-                                           network_isolation_key);
+  return factory->CryptoConfigCacheIsEmptyForTesting(quic_server_id,
+                                                     network_isolation_key);
 }
 
 void QuicStreamFactoryPeer::CacheDummyServerConfig(