Skip to content

GitLab

T
tangled
Commit ca551bc6 authored by Mario Sanchez Prada's avatar Mario Sanchez Prada Committed by Commit Bot
Browse files
Options

[css-filters] Move multiple-references-id-mutate-crash.html test to WPT 

Migrate this test out of third_party/blink/web_tests/css3/filters
and into a WPT-specific directory for crashtests, adding links to
the relevant specs and a test assertion describing its purpose.

This CL also creates a external/wpt/css/filter-effects/crashtests
directory to place the new crashtest, in order to be able to add
a multiple-references-id-crash-002.html in a follow-up CL, since
otherwise (i.e. no crashtest dir) we would have to move the '-crash'
substring after the '-001/-002' one part, right before the extension,
or otherwise the test would not run (see the relevant RFC[1]).

Besides, having a crashtest directory will be convenient to migrate
more crash tests into css/filter-effects in the future.

[1] https://github.com/web-platform-tests/rfcs/blob/master/rfcs/load_test.md

Bug: 1063749
Change-Id: I997fba360058d604698fab74ae84ee3b9893cb49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144035
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: default avatarFredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#757925}
parent eb23af94
Hide whitespace changes
Inline Side-by-side
Showing with 26 additions and 18 deletions
third_party/blink/web_tests/SmokeTests
View file @ ca551bc6
......@@ -45,7 +45,6 @@ css3/device-adapt/viewport-initial-width-zero.html
css3/device-adapt/viewport-insert-rule-after.html
css3/device-adapt/viewport-insert-rule-before.html
css3/filters/crash-hw-sw-switch.html
css3/filters/multiple-references-id-mutate-crash.html
css3/flexbox/assert-generated-new-flexbox.html
css3/fonts/font-feature-settings-parsing-prefixed.html
css3/masking/clip-path-reference-of-fake-clipPath.html
......@@ -164,6 +163,7 @@ external/wpt/css/css-typed-om/CSSMatrixComponent-DOMMatrix-mutable.html
external/wpt/css/css-typed-om/declared-styleMap-accepts-inherit.html
external/wpt/css/css-typed-om/stylevalue-subclasses/cssKeywordValue.html
external/wpt/css/css-typed-om/the-stylepropertymap/properties/border-style.html
external/wpt/css/filter-effects/crashtests/multiple-references-id-crash-001.html
external/wpt/custom-elements/HTMLElement-constructor.html
external/wpt/custom-elements/parser/parser-constructs-custom-element-in-document-write.html
external/wpt/custom-elements/parser/parser-constructs-custom-elements.html
......
third_party/blink/web_tests/css3/filters/multiple-references-id-mutate-crash.html deleted 100644 → 0
View file @ eb23af94
<!DOCTYPE html>
<style>
.filter {
filter: url(#foo);
}
</style>
<div class="filter"></div>
<div class="filter"></div>
<button form="bar"></button>
<script>
if (window.testRunner)
testRunner.dumpAsText();
onload = function() {
document.body.innerHTML = "PASS if no crash";
}
</script>
third_party/blink/web_tests/external/wpt/css/filter-effects/crashtests/multiple-references-id-crash-001.html 0 → 100644
View file @ ca551bc6
<!DOCTYPE html>
<html>
<title>CSS Filters: multiple references to non-existent filter</title>
<link rel="author" title="Fredrik Söderquist" href="mailto:fs@opera.com">
<link rel="help" href="https://drafts.fxtf.org/filter-effects-1/#FilterProperty">
<link rel="help" href="https://bugs.chromium.org/p/chromium/issues/detail?id=439970">
<meta name="assert" content="Check that applying the same filter pointing to a non-existing target from multiple elements does not crash when removed."/>
<style>
.filter {
filter: url(#foo);
}
</style>
<body onload="runTest()">
<div class="filter"></div>
<div class="filter"></div>
<button form="bar"></button>
<script>
function runTest() {
document.body.innerHTML = "PASS if no crash";
}
</script>
</body>
</html>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment