Change security_page_tests.js to check visibility, not navigations

The security_page_tests currently test the page navigated to by the
security_keys subpage. The target of this navigation is constant and
similar behaviors are not tested elsewhere in settings.

This CL changes the test to test the visibility of the link row, which
does change depending on platform and flag state and has significant
testing precedent.

Bug: 1111027
Change-Id: I37814b531e4f174c8a9d46ec72f1c920b358d545
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321413
Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com>
Reviewed-by: Sean Harrison <harrisonsean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#793026}

chrome/test/data/webui/settings/security_page_test.js

@@ -10,7 +10,7 @@ import {SafeBrowsingSetting} from 'chrome://settings/lazy_load.js';
 import {MetricsBrowserProxyImpl, PrivacyElementInteractions,PrivacyPageBrowserProxyImpl, Router, routes, SecureDnsMode, SyncBrowserProxyImpl} from 'chrome://settings/settings.js';
 
 import {assertEquals, assertFalse, assertTrue} from '../chai_assert.js';
-import {flushTasks} from '../test_util.m.js';
+import {flushTasks, isChildVisible} from '../test_util.m.js';
 
 import {TestMetricsBrowserProxy} from './test_metrics_browser_proxy.js';
 import {TestPrivacyPageBrowserProxy} from './test_privacy_page_browser_proxy.js';
@@ -18,7 +18,7 @@ import {TestSyncBrowserProxy} from './test_sync_browser_proxy.m.js';
 
 // clang-format on
 
-suite('CrSettingsSecurityPageTestWithEnhanced', function() {
+suite('CrSettingsSecurityPageTest', function() {
   /** @type {!TestMetricsBrowserProxy} */
   let testMetricsBrowserProxy;
 
@@ -98,9 +98,8 @@ suite('CrSettingsSecurityPageTestWithEnhanced', function() {
     assertEquals(PrivacyElementInteractions.MANAGE_CERTIFICATES, result);
   });
 
-  test('ManageSecurityKeysSubpageRoute', function() {
-    page.$$('#security-keys-subpage-trigger').click();
-    assertEquals(Router.getInstance().getCurrentRoute(), routes.SECURITY_KEYS);
+  test('ManageSecurityKeysSubpageVisible', function() {
+    assertTrue(isChildVisible(page, '#security-keys-subpage-trigger'));
   });
 
   test('LogSafeBrowsingExtendedToggle', async function() {
@@ -391,12 +390,13 @@ suite('CrSettingsSecurityPageTestWithEnhanced', function() {
 });
 
 
-suite('CrSettingsSecurityPageTestWithoutEnhanced', function() {
+suite('CrSettingsSecurityPageTest_FlagsDisabled', function() {
   /** @type {!SettingsSecurityPageElement} */
   let page;
 
   suiteSetup(function() {
     loadTimeData.overrideValues({
+      enableSecurityKeysSubpage: false,
       safeBrowsingEnhancedEnabled: false,
     });
   });
@@ -433,7 +433,11 @@ suite('CrSettingsSecurityPageTestWithoutEnhanced', function() {
     page.remove();
   });
 
-  test('enhancedHiddenWhenDisbled', function() {
-    assertTrue(page.$$('#safeBrowsingEnhanced').hidden);
+  test('EnhancedHiddenWhenDisbled', function() {
+    assertFalse(isChildVisible(page, '#safeBrowsingEnhanced'));
+  });
+
+  test('ManageSecurityKeysSubpageHidden', function() {
+    assertFalse(isChildVisible(page, '#security-keys-subpage-trigger'));
   });
 });