Skip to content

GitLab

T
tangled
Commit cab1e31b authored by Mike West's avatar Mike West Committed by Chromium LUCI CQ
Browse files
Options

Deprecate kV8SharedArrayBufferConstructedWithoutIsolation. 

This patch wires the kV8SharedArrayBufferConstructedWithoutIsolation
feature up to Blink's deprecation infrastructure, resulting in a console
warning on the one hand, and a deprecation report on the other.

Bug: 1168554
Change-Id: I129ef0fc85d6e57ecb5db7a8671d771556e9f375
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640254
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: default avatarCamille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845577}
parent d4e66a8e
Hide whitespace changes
Inline Side-by-side
Showing with 222 additions and 0 deletions
third_party/blink/renderer/bindings/core/v8/use_counter_callback.cc
View file @ cab1e31b
...@@ -240,6 +240,7 @@ void UseCounterCallback(v8::Isolate* isolate, ...@@ -240,6 +240,7 @@ void UseCounterCallback(v8::Isolate* isolate,
if (!CurrentExecutionContext(isolate)->CrossOriginIsolatedCapability()) { if (!CurrentExecutionContext(isolate)->CrossOriginIsolatedCapability()) {
blink_feature = blink_feature =
WebFeature::kV8SharedArrayBufferConstructedWithoutIsolation; WebFeature::kV8SharedArrayBufferConstructedWithoutIsolation;
deprecated = true;
} else { } else {
blink_feature = WebFeature::kV8SharedArrayBufferConstructed; blink_feature = WebFeature::kV8SharedArrayBufferConstructed;
} }
......
third_party/blink/renderer/core/frame/deprecation.cc
View file @ cab1e31b
...@@ -508,6 +508,16 @@ DeprecationInfo GetDeprecationInfo(WebFeature feature) { ...@@ -508,6 +508,16 @@ DeprecationInfo GetDeprecationInfo(WebFeature feature) {
"details.", "details.",
MilestoneString(kM84).Ascii().c_str())}; MilestoneString(kM84).Ascii().c_str())};
case WebFeature::kV8SharedArrayBufferConstructedWithoutIsolation:
return {
"SharedArrayBufferConstructedWithoutIsolation", kM91,
String::Format(
"SharedArrayBuffer will require cross-origin isolation as of "
"%s. See "
"https://developer.chrome.com/blog/enabling-shared-array-buffer/"
" for more details.",
MilestoneString(kM91).Ascii().c_str())};
case WebFeature::kV8RTCRtpSender_CreateEncodedAudioStreams_Method: case WebFeature::kV8RTCRtpSender_CreateEncodedAudioStreams_Method:
return {"V8RTCRtpSender_CreateEncodedAudioStreams_Method", kM88, return {"V8RTCRtpSender_CreateEncodedAudioStreams_Method", kM88,
ReplacedWillBeRemoved("RTCRtpSender.createEncodedAudioStreams", ReplacedWillBeRemoved("RTCRtpSender.createEncodedAudioStreams",
......
third_party/blink/web_tests/crypto/random-values-expected.txt
View file @ cab1e31b
CONSOLE WARNING: SharedArrayBuffer will require cross-origin isolation as of M91, around May 2021. See https://developer.chrome.com/blog/enabling-shared-array-buffer/ for more details.
Tests crypto.randomValues. Tests crypto.randomValues.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
......
third_party/blink/web_tests/crypto/subtle/importKey-badParameters-expected.txt
View file @ cab1e31b
CONSOLE WARNING: line 68: SharedArrayBuffer will require cross-origin isolation as of M91, around May 2021. See https://developer.chrome.com/blog/enabling-shared-array-buffer/ for more details.
Tests calling cypto.subtle.importKey with bad parameters Tests calling cypto.subtle.importKey with bad parameters
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
......
third_party/blink/web_tests/crypto/worker-random-values-expected.txt
View file @ cab1e31b
CONSOLE WARNING: SharedArrayBuffer will require cross-origin isolation as of M91, around May 2021. See https://developer.chrome.com/blog/enabling-shared-array-buffer/ for more details.
[Worker] Tests crypto.randomValues. [Worker] Tests crypto.randomValues.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
......
third_party/blink/web_tests/fast/beacon/beacon-basic-expected.txt
View file @ cab1e31b
CONSOLE WARNING: SharedArrayBuffer will require cross-origin isolation as of M91, around May 2021. See https://developer.chrome.com/blog/enabling-shared-array-buffer/ for more details.
Exercising the Beacon API Exercising the Beacon API
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
......
third_party/blink/web_tests/fast/css/fontface-arraybuffer-expected.txt
View file @ cab1e31b
CONSOLE WARNING: line 29: SharedArrayBuffer will require cross-origin isolation as of M91, around May 2021. See https://developer.chrome.com/blog/enabling-shared-array-buffer/ for more details.
Tests ArrayBuffer / ArrayBufferView constructors of FontFace. Tests ArrayBuffer / ArrayBufferView constructors of FontFace.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
......
third_party/blink/web_tests/fast/dom/geometry-interfaces-dom-matrix-expected.txt
View file @ cab1e31b
CONSOLE WARNING: line 125: SharedArrayBuffer will require cross-origin isolation as of M91, around May 2021. See https://developer.chrome.com/blog/enabling-shared-array-buffer/ for more details.
This is a testharness.js-based test. This is a testharness.js-based test.
Harness Error. harness_status.status = 1 , harness_status.message = 1 duplicate test name: "DOMMatrix(numberSequence) constructor" Harness Error. harness_status.status = 1 , harness_status.message = 1 duplicate test name: "DOMMatrix(numberSequence) constructor"
PASS DOMMatrix() constructor PASS DOMMatrix() constructor
......
third_party/blink/web_tests/fast/events/constructors/midi-message-event-constructor-expected.txt
View file @ cab1e31b
CONSOLE WARNING: line 35: SharedArrayBuffer will require cross-origin isolation as of M91, around May 2021. See https://developer.chrome.com/blog/enabling-shared-array-buffer/ for more details.
This tests the constructor for the MIDIMessageEvent DOM class. This tests the constructor for the MIDIMessageEvent DOM class.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
......
third_party/blink/web_tests/fast/files/blob-constructor-expected.txt
View file @ cab1e31b
CONSOLE WARNING: SharedArrayBuffer will require cross-origin isolation as of M91, around May 2021. See https://developer.chrome.com/blog/enabling-shared-array-buffer/ for more details.
Test the Blob constructor. Test the Blob constructor.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
......
third_party/blink/web_tests/fast/peerconnection/RTCPeerConnection-datachannel-expected.txt
View file @ cab1e31b
CONSOLE WARNING: SharedArrayBuffer will require cross-origin isolation as of M91, around May 2021. See https://developer.chrome.com/blog/enabling-shared-array-buffer/ for more details.
Tests RTCDataChannel. Tests RTCDataChannel.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
......
third_party/blink/web_tests/fast/workers/chromium/worker-sharedarraybuffer-transfer-two-workers-expected.txt
View file @ cab1e31b
CONSOLE WARNING: line 119: SharedArrayBuffer will require cross-origin isolation as of M91, around May 2021. See https://developer.chrome.com/blog/enabling-shared-array-buffer/ for more details.
CONSOLE WARNING: line 27: SharedArrayBuffer will require cross-origin isolation as of M91, around May 2021. See https://developer.chrome.com/blog/enabling-shared-array-buffer/ for more details.
CONSOLE WARNING: line 27: SharedArrayBuffer will require cross-origin isolation as of M91, around May 2021. See https://developer.chrome.com/blog/enabling-shared-array-buffer/ for more details.
Test sharing SharedArrayBuffers between dedicated workers. Test sharing SharedArrayBuffers between dedicated workers.
Running SharedArrayBuffer test case Running SharedArrayBuffer test case
......
third_party/blink/web_tests/fast/workers/worker-atomics-wait-expected.txt
View file @ cab1e31b
CONSOLE WARNING: line 18: SharedArrayBuffer will require cross-origin isolation as of M91, around May 2021. See https://developer.chrome.com/blog/enabling-shared-array-buffer/ for more details.
CONSOLE WARNING: line 2: SharedArrayBuffer will require cross-origin isolation as of M91, around May 2021. See https://developer.chrome.com/blog/enabling-shared-array-buffer/ for more details.
Test that Atomics.wait is not allowed on the main thread. Test that Atomics.wait is not allowed on the main thread.
PASS: Calling Atomics.wait on the main thread throws. PASS: Calling Atomics.wait on the main thread throws.
......
third_party/blink/web_tests/fast/workers/worker-sharedarraybuffer-transfer-expected.txt
View file @ cab1e31b
CONSOLE WARNING: line 113: SharedArrayBuffer will require cross-origin isolation as of M91, around May 2021. See https://developer.chrome.com/blog/enabling-shared-array-buffer/ for more details.
CONSOLE WARNING: line 27: SharedArrayBuffer will require cross-origin isolation as of M91, around May 2021. See https://developer.chrome.com/blog/enabling-shared-array-buffer/ for more details.
Test sharing SharedArrayBuffers between dedicated workers. Test sharing SharedArrayBuffers between dedicated workers.
Running SharedArrayBuffer test case Running SharedArrayBuffer test case
......
third_party/blink/web_tests/http/tests/websocket/send-arraybufferview-expected.txt
View file @ cab1e31b
CONSOLE WARNING: line 45: SharedArrayBuffer will require cross-origin isolation as of M91, around May 2021. See https://developer.chrome.com/blog/enabling-shared-array-buffer/ for more details.
WebSocket: Send ArrayBufferViews. WebSocket: Send ArrayBufferViews.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
......
third_party/blink/web_tests/platform/fuchsia/fast/beacon/beacon-basic-expected.txt
View file @ cab1e31b
CONSOLE WARNING: SharedArrayBuffer will require cross-origin isolation as of M91, around May 2021. See https://developer.chrome.com/blog/enabling-shared-array-buffer/ for more details.
Exercising the Beacon API Exercising the Beacon API
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
......
third_party/blink/web_tests/virtual/plz-dedicated-worker/fast/workers/chromium/worker-sharedarraybuffer-transfer-two-workers-expected.txt 0 → 100644
View file @ cab1e31b
CONSOLE WARNING: line 119: SharedArrayBuffer will require cross-origin isolation as of M91, around May 2021. See https://developer.chrome.com/blog/enabling-shared-array-buffer/ for more details.
CONSOLE WARNING: line 27: SharedArrayBuffer will require cross-origin isolation as of M91, around May 2021. See https://developer.chrome.com/blog/enabling-shared-array-buffer/ for more details.
CONSOLE WARNING: line 27: SharedArrayBuffer will require cross-origin isolation as of M91, around May 2021. See https://developer.chrome.com/blog/enabling-shared-array-buffer/ for more details.
Test sharing SharedArrayBuffers between dedicated workers.
Running SharedArrayBuffer test case
PASS: Passing SharedArrayBuffer in the transfer list threw.
PASS: SharedArrayBuffer not neutered during transfer.
PASS: Original data not changed during transfer.
PASS: Transferred data is OK.
PASS: Transferred data is OK.
Running Int8Array test case
PASS: Passing SharedArrayBuffer in the transfer list threw.
PASS: SharedArrayBuffer not neutered during transfer.
PASS: Original data not changed during transfer.
PASS: Transferred array type is OK.
PASS: Transferred data is OK.
PASS: Transferred array type is OK.
PASS: Transferred data is OK.
Running Uint8Array test case
PASS: Passing SharedArrayBuffer in the transfer list threw.
PASS: SharedArrayBuffer not neutered during transfer.
PASS: Original data not changed during transfer.
PASS: Transferred array type is OK.
PASS: Transferred data is OK.
PASS: Transferred array type is OK.
PASS: Transferred data is OK.
Running Uint8ClampedArray test case
PASS: Passing SharedArrayBuffer in the transfer list threw.
PASS: SharedArrayBuffer not neutered during transfer.
PASS: Original data not changed during transfer.
PASS: Transferred array type is OK.
PASS: Transferred data is OK.
PASS: Transferred array type is OK.
PASS: Transferred data is OK.
Running Int16Array test case
PASS: Passing SharedArrayBuffer in the transfer list threw.
PASS: SharedArrayBuffer not neutered during transfer.
PASS: Original data not changed during transfer.
PASS: Transferred array type is OK.
PASS: Transferred data is OK.
PASS: Transferred array type is OK.
PASS: Transferred data is OK.
Running Uint16Array test case
PASS: Passing SharedArrayBuffer in the transfer list threw.
PASS: SharedArrayBuffer not neutered during transfer.
PASS: Original data not changed during transfer.
PASS: Transferred array type is OK.
PASS: Transferred data is OK.
PASS: Transferred array type is OK.
PASS: Transferred data is OK.
Running Int32Array test case
PASS: Passing SharedArrayBuffer in the transfer list threw.
PASS: SharedArrayBuffer not neutered during transfer.
PASS: Original data not changed during transfer.
PASS: Transferred array type is OK.
PASS: Transferred data is OK.
PASS: Transferred array type is OK.
PASS: Transferred data is OK.
Running Uint32Array test case
PASS: Passing SharedArrayBuffer in the transfer list threw.
PASS: SharedArrayBuffer not neutered during transfer.
PASS: Original data not changed during transfer.
PASS: Transferred array type is OK.
PASS: Transferred data is OK.
PASS: Transferred array type is OK.
PASS: Transferred data is OK.
Running Float32Array test case
PASS: Passing SharedArrayBuffer in the transfer list threw.
PASS: SharedArrayBuffer not neutered during transfer.
PASS: Original data not changed during transfer.
PASS: Transferred array type is OK.
PASS: Transferred data is OK.
PASS: Transferred array type is OK.
PASS: Transferred data is OK.
Running Float64Array test case
PASS: Passing SharedArrayBuffer in the transfer list threw.
PASS: SharedArrayBuffer not neutered during transfer.
PASS: Original data not changed during transfer.
PASS: Transferred array type is OK.
PASS: Transferred data is OK.
PASS: Transferred array type is OK.
PASS: Transferred data is OK.
DONE
third_party/blink/web_tests/virtual/plz-dedicated-worker/fast/workers/worker-sharedarraybuffer-transfer-expected.txt 0 → 100644
View file @ cab1e31b
CONSOLE WARNING: line 113: SharedArrayBuffer will require cross-origin isolation as of M91, around May 2021. See https://developer.chrome.com/blog/enabling-shared-array-buffer/ for more details.
CONSOLE WARNING: line 27: SharedArrayBuffer will require cross-origin isolation as of M91, around May 2021. See https://developer.chrome.com/blog/enabling-shared-array-buffer/ for more details.
Test sharing SharedArrayBuffers between dedicated workers.
Running SharedArrayBuffer test case
PASS: Passing SharedArrayBuffer in the transfer list threw.
PASS: SharedArrayBuffer not neutered during transfer.
PASS: Original data not changed during transfer.
PASS: Transferred data is OK.
Running Int8Array test case
PASS: Passing SharedArrayBuffer in the transfer list threw.
PASS: SharedArrayBuffer not neutered during transfer.
PASS: Original data not changed during transfer.
PASS: Transferred array type is OK.
PASS: Transferred data is OK.
Running Uint8Array test case
PASS: Passing SharedArrayBuffer in the transfer list threw.
PASS: SharedArrayBuffer not neutered during transfer.
PASS: Original data not changed during transfer.
PASS: Transferred array type is OK.
PASS: Transferred data is OK.
Running Uint8ClampedArray test case
PASS: Passing SharedArrayBuffer in the transfer list threw.
PASS: SharedArrayBuffer not neutered during transfer.
PASS: Original data not changed during transfer.
PASS: Transferred array type is OK.
PASS: Transferred data is OK.
Running Int16Array test case
PASS: Passing SharedArrayBuffer in the transfer list threw.
PASS: SharedArrayBuffer not neutered during transfer.
PASS: Original data not changed during transfer.
PASS: Transferred array type is OK.
PASS: Transferred data is OK.
Running Uint16Array test case
PASS: Passing SharedArrayBuffer in the transfer list threw.
PASS: SharedArrayBuffer not neutered during transfer.
PASS: Original data not changed during transfer.
PASS: Transferred array type is OK.
PASS: Transferred data is OK.
Running Int32Array test case
PASS: Passing SharedArrayBuffer in the transfer list threw.
PASS: SharedArrayBuffer not neutered during transfer.
PASS: Original data not changed during transfer.
PASS: Transferred array type is OK.
PASS: Transferred data is OK.
Running Uint32Array test case
PASS: Passing SharedArrayBuffer in the transfer list threw.
PASS: SharedArrayBuffer not neutered during transfer.
PASS: Original data not changed during transfer.
PASS: Transferred array type is OK.
PASS: Transferred data is OK.
Running Float32Array test case
PASS: Passing SharedArrayBuffer in the transfer list threw.
PASS: SharedArrayBuffer not neutered during transfer.
PASS: Original data not changed during transfer.
PASS: Transferred array type is OK.
PASS: Transferred data is OK.
Running Float64Array test case
PASS: Passing SharedArrayBuffer in the transfer list threw.
PASS: SharedArrayBuffer not neutered during transfer.
PASS: Original data not changed during transfer.
PASS: Transferred array type is OK.
PASS: Transferred data is OK.
Running SendSharedArrayBufferTwice test case
PASS: Transferred data is OK.
Running TransferArrayBufferAndSharedArrayBuffer test case
PASS: ArrayBuffer was neutered during transfer.
PASS: Transferred data is OK.
PASS: Transferred data is OK.
Running SharedArrayBufferInTransferListViaMessagePort test case
PASS: Passing SharedArrayBuffer in the transfer list threw.
PASS: ArrayBuffer 'ab1' was not neutered.
PASS: ArrayBuffer 'ab2' was not neutered.
DONE
third_party/blink/web_tests/virtual/v8-off-thread-finalization/fast/dom/geometry-interfaces-dom-matrix-expected.txt 0 → 100644
View file @ cab1e31b
CONSOLE WARNING: line 125: SharedArrayBuffer will require cross-origin isolation as of M91, around May 2021. See https://developer.chrome.com/blog/enabling-shared-array-buffer/ for more details.
This is a testharness.js-based test.
Harness Error. harness_status.status = 1 , harness_status.message = 1 duplicate test name: "DOMMatrix(numberSequence) constructor"
PASS DOMMatrix() constructor
PASS DOMMatrix fromFloat32Array - 2D matrix
PASS DOMMatrix fromFloat64Array - 2D matrix
PASS DOMMatrix fromFloat32Array - 3D matrix
PASS DOMMatrix fromFloat64Array - 3D matrix
PASS DOMMatrix(transformList) - emptyString
PASS DOMMatrix(transformList) - transformList
PASS DOMMatrix(numberSequence) constructor
PASS DOMMatrix(numberSequence) constructor
PASS DOMMatrix attributes
PASS DOMMatrix.is2D can never be set to 'true' when it was set to 'false' before calling setMatrixValue()
PASS DOMMatrix fromFloat*Array - invalid array size of nearby 6
PASS DOMMatrix fromFloat*Array - invalid array size of nearby 16
PASS DOMMatrix fromFloat*Array - invalid array size
PASS DOMMatrix fromFloat*Array - can't use SharedArrayBuffer view
PASS DOMMatrix.fromMatrix() with no parameter
PASS DOMMatrix.fromMatrix() with null
PASS DOMMatrix.fromMatrix() with undefined
PASS DOMMatrix.fromMatrix() with empty object
PASS DOMMatrix.fromMatrix({a: 1, b: 2, c: 3, d: 4, e: 5, f: 6}) should create a 2D DOMMatrix
PASS DOMMatrix.fromMatrix({m11: 1, m22: 2, m33: 3, m44: 4, m23: 5, m43: 6}) should create a 3D DOMMatrix
PASS If 2d related properties don't be set, should set to fallback
PASS DOMMatrix.fromMatrix(): NaN test
PASS DOMMatrix toJSON() - identity matrix
PASS DOMMatrix toJSON() - 2D matrix
PASS DOMMatrix toJSON() - 3D matrix
PASS DOMMatrix.fromMatrix(): Exception test
Harness: the test ran to completion.
third_party/blink/web_tests/webaudio/dom-exceptions-expected.txt
View file @ cab1e31b
CONSOLE WARNING: line 252: SharedArrayBuffer will require cross-origin isolation as of M91, around May 2021. See https://developer.chrome.com/blog/enabling-shared-array-buffer/ for more details.
CONSOLE WARNING: line 347: The provided value 'fancy' is not a valid enum value of type ChannelCountMode. CONSOLE WARNING: line 347: The provided value 'fancy' is not a valid enum value of type ChannelCountMode.
CONSOLE WARNING: line 353: The provided value 'undefined' is not a valid enum value of type ChannelInterpretation. CONSOLE WARNING: line 353: The provided value 'undefined' is not a valid enum value of type ChannelInterpretation.
CONSOLE WARNING: line 523: The provided value '9x' is not a valid enum value of type OverSampleType. CONSOLE WARNING: line 523: The provided value '9x' is not a valid enum value of type OverSampleType.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment