Commit cac9faa9 authored by Alex Moshchuk's avatar Alex Moshchuk Committed by Commit Bot

Add missing members to FrameReplicationState struct traits.

Not having FrameReplicationState::has_received_user_gesture in the
struct traits caused it to not propagate through IPCs properly, and
was caught by a couple of autoplay layout test failures, which had
been failing with site isolation enabled.  Thanks to mustaq@ for the
analysis that led to the discovery of this bug.

FrameReplicationState::active_sandbox_flags was similarly missing from
the struct traits, so that member is fixed as well.

Bug: 794631
Change-Id: I3ebdb51ff887b79c18c4a7c593fac33bb3333a0d
Reviewed-on: https://chromium-review.googlesource.com/981306Reviewed-by: default avatarNasko Oskov <nasko@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545969}
parent 5c849d31
...@@ -512,12 +512,14 @@ IPC_STRUCT_TRAITS_BEGIN(content::FrameReplicationState) ...@@ -512,12 +512,14 @@ IPC_STRUCT_TRAITS_BEGIN(content::FrameReplicationState)
IPC_STRUCT_TRAITS_MEMBER(name) IPC_STRUCT_TRAITS_MEMBER(name)
IPC_STRUCT_TRAITS_MEMBER(unique_name) IPC_STRUCT_TRAITS_MEMBER(unique_name)
IPC_STRUCT_TRAITS_MEMBER(feature_policy_header) IPC_STRUCT_TRAITS_MEMBER(feature_policy_header)
IPC_STRUCT_TRAITS_MEMBER(active_sandbox_flags)
IPC_STRUCT_TRAITS_MEMBER(frame_policy) IPC_STRUCT_TRAITS_MEMBER(frame_policy)
IPC_STRUCT_TRAITS_MEMBER(accumulated_csp_headers) IPC_STRUCT_TRAITS_MEMBER(accumulated_csp_headers)
IPC_STRUCT_TRAITS_MEMBER(scope) IPC_STRUCT_TRAITS_MEMBER(scope)
IPC_STRUCT_TRAITS_MEMBER(insecure_request_policy) IPC_STRUCT_TRAITS_MEMBER(insecure_request_policy)
IPC_STRUCT_TRAITS_MEMBER(insecure_navigations_set) IPC_STRUCT_TRAITS_MEMBER(insecure_navigations_set)
IPC_STRUCT_TRAITS_MEMBER(has_potentially_trustworthy_unique_origin) IPC_STRUCT_TRAITS_MEMBER(has_potentially_trustworthy_unique_origin)
IPC_STRUCT_TRAITS_MEMBER(has_received_user_gesture)
IPC_STRUCT_TRAITS_MEMBER(has_received_user_gesture_before_nav) IPC_STRUCT_TRAITS_MEMBER(has_received_user_gesture_before_nav)
IPC_STRUCT_TRAITS_END() IPC_STRUCT_TRAITS_END()
......
...@@ -133,6 +133,9 @@ struct CONTENT_EXPORT FrameReplicationState { ...@@ -133,6 +133,9 @@ struct CONTENT_EXPORT FrameReplicationState {
// Whether the frame has received a user gesture in a previous navigation so // Whether the frame has received a user gesture in a previous navigation so
// long as a the frame has staying on the same eTLD+1. // long as a the frame has staying on the same eTLD+1.
bool has_received_user_gesture_before_nav; bool has_received_user_gesture_before_nav;
// IMPORTANT NOTE: When adding a new member to this struct, don't forget to
// also add a corresponding entry to the struct traits in frame_messages.h!
}; };
} // namespace content } // namespace content
......
...@@ -5,10 +5,6 @@ ...@@ -5,10 +5,6 @@
crbug.com/802835 external/wpt/fetch/corb/img-png-mislabeled-as-html-nosniff.tentative.sub.html [ Pass ] crbug.com/802835 external/wpt/fetch/corb/img-png-mislabeled-as-html-nosniff.tentative.sub.html [ Pass ]
crbug.com/802835 external/wpt/fetch/corb/script-html-correctly-labeled.tentative.sub.html [ Pass ] crbug.com/802835 external/wpt/fetch/corb/script-html-correctly-labeled.tentative.sub.html [ Pass ]
# https://crbug.com/794631: OOPIFs VS feature policy VS opaque origins?
crbug.com/794631 virtual/unified-autoplay/external/wpt/feature-policy/autoplay-allowed-by-feature-policy-attribute.https.sub.html [ Failure ]
crbug.com/794631 virtual/unified-autoplay/external/wpt/feature-policy/autoplay-allowed-by-feature-policy.https.sub.html [ Failure ]
# https://crbug.com/793127: NOTREACHED() from clamy@ tickled by frame consolidation CL? # https://crbug.com/793127: NOTREACHED() from clamy@ tickled by frame consolidation CL?
crbug.com/793127 http/tests/security/upgrade-insecure-requests/iframe-upgrade.https.html [ Crash ] crbug.com/793127 http/tests/security/upgrade-insecure-requests/iframe-upgrade.https.html [ Crash ]
crbug.com/793127 external/wpt/content-security-policy/securitypolicyviolation/upgrade-insecure-requests-reporting.https.html [ Crash ] crbug.com/793127 external/wpt/content-security-policy/securitypolicyviolation/upgrade-insecure-requests-reporting.https.html [ Crash ]
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment