Commit cacb0491 authored by Bo Liu's avatar Bo Liu Committed by Commit Bot

Revert "Add a DumpWithoutCrashing to header sender"

This reverts commit 33cd6ce1.

Reason: Obtained crash reports from wild so no longer needed.

Original description:
> Add a DumpWithoutCrashing to header sender
>
> Add a DumpWithoutCrashing to the sender side of
> URLLoaderFactory.CreateLoaderAndStart.
>
> Bug: 1028189
> Change-Id: I05fcf83ebe3248b4b67c60d0ecb5c176173ad976
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358478
> Commit-Queue: Bo <boliu@chromium.org>
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#798660}

Bug: 1028189
Bug: 1125081
Change-Id: I8729d0f68c9e7ede31e00e2a7ef9c0ac07dbd877
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401218Reviewed-by: default avatarMatt Menke <mmenke@chromium.org>
Reviewed-by: default avatarRobert Sesek <rsesek@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805361}
parent 0ddfe29d
...@@ -4,24 +4,11 @@ ...@@ -4,24 +4,11 @@
#include "services/network/public/cpp/http_request_headers_mojom_traits.h" #include "services/network/public/cpp/http_request_headers_mojom_traits.h"
#include "base/debug/dump_without_crashing.h"
#include "net/http/http_util.h" #include "net/http/http_util.h"
#include "services/network/public/cpp/crash_keys.h" #include "services/network/public/cpp/crash_keys.h"
namespace mojo { namespace mojo {
// static
const std::string&
StructTraits<network::mojom::HttpRequestHeaderKeyValuePairDataView,
net::HttpRequestHeaders::HeaderKeyValuePair>::
key(const net::HttpRequestHeaders::HeaderKeyValuePair& item) {
if (!net::HttpUtil::IsValidHeaderName(item.key)) {
// TODO(crbug.com/1028189): Adding temporarily to debug crbug.com/1028189.
base::debug::DumpWithoutCrashing();
}
return item.key;
}
// static // static
bool StructTraits<network::mojom::HttpRequestHeaderKeyValuePairDataView, bool StructTraits<network::mojom::HttpRequestHeaderKeyValuePairDataView,
net::HttpRequestHeaders::HeaderKeyValuePair>:: net::HttpRequestHeaders::HeaderKeyValuePair>::
......
...@@ -16,7 +16,9 @@ struct COMPONENT_EXPORT(NETWORK_CPP_BASE) ...@@ -16,7 +16,9 @@ struct COMPONENT_EXPORT(NETWORK_CPP_BASE)
StructTraits<network::mojom::HttpRequestHeaderKeyValuePairDataView, StructTraits<network::mojom::HttpRequestHeaderKeyValuePairDataView,
net::HttpRequestHeaders::HeaderKeyValuePair> { net::HttpRequestHeaders::HeaderKeyValuePair> {
static const std::string& key( static const std::string& key(
const net::HttpRequestHeaders::HeaderKeyValuePair& item); const net::HttpRequestHeaders::HeaderKeyValuePair& item) {
return item.key;
}
static const std::string& value( static const std::string& value(
const net::HttpRequestHeaders::HeaderKeyValuePair& item) { const net::HttpRequestHeaders::HeaderKeyValuePair& item) {
return item.value; return item.value;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment