Commit cae053fe authored by David Roger's avatar David Roger Committed by Chromium LUCI CQ

[profiles] Remove voiceover for avatar URLs

The avatar images in profile UIs did not have any accessibility options,
and the voice over was spelling out the whole image URL, which is a
broken experience.
The voice over label for the avatars is not strictly required, and thus
this CL disables the voice over by passing an empty 'alt' attribute to
the images.

Fixed: 1151916
Change-Id: Ifd098e78842a3b01e1bd28d19baf8e2aac86c4d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565432
Auto-Submit: David Roger <droger@chromium.org>
Commit-Queue: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: default avatarEsmael Elmoslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832032}
parent bad63670
...@@ -112,7 +112,7 @@ ...@@ -112,7 +112,7 @@
<div id="header"> <div id="header">
<div id="headerText">[[interceptionParameters_.headerText]]</div> <div id="headerText">[[interceptionParameters_.headerText]]</div>
<div id="avatar-container"> <div id="avatar-container">
<img id="avatar" <img id="avatar" alt=""
src="[[interceptionParameters_.interceptedAccount.pictureUrl]]"> src="[[interceptionParameters_.interceptedAccount.pictureUrl]]">
<div class="work-badge" id="badge" <div class="work-badge" id="badge"
hidden="[[!interceptionParameters_.interceptedAccount.isManaged]]"> hidden="[[!interceptionParameters_.interceptedAccount.isManaged]]">
......
...@@ -121,7 +121,7 @@ ...@@ -121,7 +121,7 @@
<div id="header"> <div id="header">
<div id="headerText">[[initialProfileName_]]</div> <div id="headerText">[[initialProfileName_]]</div>
<div id="avatarContainer"> <div id="avatarContainer">
<img id="avatar" src="[[pictureUrl_]]"> <img id="avatar" alt="" src="[[pictureUrl_]]">
<div class="work-badge" id="badge" hidden="[[!isManaged_]]"> <div class="work-badge" id="badge" hidden="[[!isManaged_]]">
<iron-icon class="icon" icon="cr:domain"></iron-icon> <iron-icon class="icon" icon="cr:domain"></iron-icon>
</div> </div>
......
...@@ -121,7 +121,7 @@ ...@@ -121,7 +121,7 @@
on-click="onClickBack_" aria-label="$i18n{backButtonLabel}"> on-click="onClickBack_" aria-label="$i18n{backButtonLabel}">
</cr-icon-button> </cr-icon-button>
<h2 id="title">$i18n{localProfileCreationTitle}</h2> <h2 id="title">$i18n{localProfileCreationTitle}</h2>
<img class="avatar" src$="[[profileThemeInfo.themeGenericAvatar]]"> <img class="avatar" alt="" src$="[[profileThemeInfo.themeGenericAvatar]]">
</div> </div>
<div id="wrapperContainer"> <div id="wrapperContainer">
......
...@@ -55,7 +55,7 @@ ...@@ -55,7 +55,7 @@
disabled="[[loadSigninInProgess_]]"> disabled="[[loadSigninInProgess_]]">
</cr-icon-button> </cr-icon-button>
<div id="signinPromoBanner" class="banner"></div> <div id="signinPromoBanner" class="banner"></div>
<img class="avatar" src="[[profileThemeInfo.themeGenericAvatar]]"> <img class="avatar" alt="" src="[[profileThemeInfo.themeGenericAvatar]]">
</div> </div>
<div class="title-container"> <div class="title-container">
<h2>$i18n{profileTypeChoiceTitle}</h2> <h2>$i18n{profileTypeChoiceTitle}</h2>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment