Commit cae53638 authored by nednguyen's avatar nednguyen Committed by Commit bot

Prefetch all WPR archives used by system_health_smoke_test

This also enables system_health_smoke_test on android.chromium bot (Android N5X Swarm Builder).

BUG=700426

Review-Url: https://codereview.chromium.org/2752033002
Cr-Commit-Position: refs/heads/master@{#457813}
parent 01146e0c
...@@ -1183,8 +1183,7 @@ ...@@ -1183,8 +1183,7 @@
{ {
"args": [ "args": [
"--browser=android-chromium", "--browser=android-chromium",
"--device=android", "--device=android"
"--skip=benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.*"
], ],
"isolate_name": "telemetry_perf_unittests", "isolate_name": "telemetry_perf_unittests",
"name": "telemetry_perf_unittests", "name": "telemetry_perf_unittests",
......
...@@ -155,8 +155,14 @@ def load_tests(loader, standard_tests, pattern): ...@@ -155,8 +155,14 @@ def load_tests(loader, standard_tests, pattern):
# Since none of our system health benchmarks creates stories based on # Since none of our system health benchmarks creates stories based on
# command line options, it should be ok to pass options=None to # command line options, it should be ok to pass options=None to
# CreateStorySet. # CreateStorySet.
for story_to_smoke_test in ( stories_set = benchmark_class().CreateStorySet(options=None)
benchmark_class().CreateStorySet(options=None).stories):
# Prefetch WPR archive needed by the stories set to avoid race condition
# when feching them when tests are run in parallel.
# See crbug.com/700426 for more details.
stories_set.wpr_archive_info.DownloadArchivesIfNeeded()
for story_to_smoke_test in stories_set.stories:
suite.addTest( suite.addTest(
_GenerateSmokeTestCase(benchmark_class, story_to_smoke_test)) _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment