Commit caed1e9d authored by Eugene But's avatar Eugene But Committed by Commit Bot

Properly disable tests in PrintControllerTestCase.

This CL adds TODO and replaces EARL_GREY_TEST_SKIPPED with
EARL_GREY_TEST_DISABLED.

Bug: 990947
Change-Id: Idfd04f691d2bff9a38f6332d9e18d25c9a765975
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736931
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: default avatarPeter Lee <pkl@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684350}
parent 4116d8fc
...@@ -48,7 +48,8 @@ const char kHTMLURL[] = "http://test"; ...@@ -48,7 +48,8 @@ const char kHTMLURL[] = "http://test";
// loaded. // loaded.
// TODO(crbug.com/683280): Does this test serve any purpose on iOS11? // TODO(crbug.com/683280): Does this test serve any purpose on iOS11?
- (void)testPrintNormalPage { - (void)testPrintNormalPage {
EARL_GREY_TEST_SKIPPED(@"Dispatcher-based printing does not work."); // TODO(crbug.com/990947): Delete or enable the test.
EARL_GREY_TEST_DISABLED(@"Dispatcher-based printing does not work.");
GURL url = web::test::HttpServer::MakeUrl(kHTMLURL); GURL url = web::test::HttpServer::MakeUrl(kHTMLURL);
std::map<GURL, std::string> responses; std::map<GURL, std::string> responses;
...@@ -65,7 +66,8 @@ const char kHTMLURL[] = "http://test"; ...@@ -65,7 +66,8 @@ const char kHTMLURL[] = "http://test";
// Tests that the AirPrint menu successfully loads when a PDF is loaded. // Tests that the AirPrint menu successfully loads when a PDF is loaded.
// TODO(crbug.com/683280): Does this test serve any purpose on iOS11? // TODO(crbug.com/683280): Does this test serve any purpose on iOS11?
- (void)testPrintPDF { - (void)testPrintPDF {
EARL_GREY_TEST_SKIPPED(@"Dispatcher-based printing does not work."); // TODO(crbug.com/990947): Delete or enable the test.
EARL_GREY_TEST_DISABLED(@"Dispatcher-based printing does not work.");
web::test::SetUpFileBasedHttpServer(); web::test::SetUpFileBasedHttpServer();
GURL url = web::test::HttpServer::MakeUrl(kPDFURL); GURL url = web::test::HttpServer::MakeUrl(kPDFURL);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment