Remove toggle for kNotifySessionsOfMostRecentIconUrlChange

This CL cleans-up a kill-switch after a successful launch of this fix.

Bug: 971246
Change-Id: Ibd62f42eeb62f0402421fd671e1cced57da21b28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827401
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Auto-Submit: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700233}

chrome/browser/sync/sessions/sync_sessions_router_tab_helper.cc

@@ -9,7 +9,6 @@
 #include "chrome/browser/sessions/session_tab_helper.h"
 #include "chrome/browser/sync/sessions/sync_sessions_web_contents_router.h"
 #include "components/favicon/content/content_favicon_driver.h"
-#include "components/favicon/core/features.h"
 #include "components/language/core/common/language_experiments.h"
 #include "components/sync_sessions/synced_tab_delegate.h"
 #include "content/public/browser/navigation_entry.h"
@@ -119,9 +118,7 @@ void SyncSessionsRouterTabHelper::OnFaviconUpdated(
     const GURL& icon_url,
     bool icon_url_changed,
     const gfx::Image& image) {
-  if (icon_url_changed &&
-      base::FeatureList::IsEnabled(
-          favicon::kNotifySessionsOfMostRecentIconUrlChange)) {
+  if (icon_url_changed) {
     NotifyRouter();
   }
 }

chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc

@@ -6,7 +6,6 @@
 #include "base/run_loop.h"
 #include "base/strings/stringprintf.h"
 #include "base/test/metrics/histogram_tester.h"
-#include "base/test/scoped_feature_list.h"
 #include "build/build_config.h"
 #include "chrome/browser/sessions/session_service.h"
 #include "chrome/browser/sessions/session_tab_helper.h"
@@ -22,7 +21,6 @@
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/url_constants.h"
-#include "components/favicon/core/features.h"
 #include "components/history/core/browser/history_types.h"
 #include "components/sessions/core/session_types.h"
 #include "components/signin/public/identity_manager/account_info.h"
@@ -795,10 +793,6 @@ IN_PROC_BROWSER_TEST_F(SingleClientSessionsSyncTest, CookieJarMismatch) {
 
 IN_PROC_BROWSER_TEST_F(SingleClientSessionsSyncTest,
                        ShouldNotifyLoadedIconUrl) {
-  base::test::ScopedFeatureList scoped_feature_list;
-  scoped_feature_list.InitAndEnableFeature(
-      favicon::kNotifySessionsOfMostRecentIconUrlChange);
-
   ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
   ASSERT_TRUE(CheckInitialState(0));
 

components/favicon/core/features.cc

@@ -12,8 +12,5 @@ const base::Feature kAllowPropagationOfFaviconCacheHits{
     "kAllowPropagationOfFaviconCacheHits", base::FEATURE_ENABLED_BY_DEFAULT};
 const base::Feature kEnableHistoryFaviconsGoogleServerQuery{
     "EnableHistoryFaviconsGoogleServerQuery", base::FEATURE_DISABLED_BY_DEFAULT};
-const base::Feature kNotifySessionsOfMostRecentIconUrlChange{
-    "NotifySessionsOfMostRecentIconUrlChange",
-    base::FEATURE_ENABLED_BY_DEFAULT};
 
 }  // namespace favicon

components/favicon/core/features.h

@@ -13,7 +13,6 @@ namespace favicon {
 
 extern const base::Feature kAllowPropagationOfFaviconCacheHits;
 extern const base::Feature kEnableHistoryFaviconsGoogleServerQuery;
-extern const base::Feature kNotifySessionsOfMostRecentIconUrlChange;
 
 }  // namespace favicon