Commit cb306e71 authored by Eric Karl's avatar Eric Karl Committed by Commit Bot

Reland "Disable browser latency recovery for Viz on Android"

This reverts commit e8718723.

Reason for revert: Testing whether this change was responsible for
the latency regression seen in crbug.com/959048. It isn't, so re-landing.

Original change's description:
> Revert "Disable browser latency recovery for Viz on Android"
> 
> This reverts commit 75cd895e.
> 
> Reason for revert: Testing whether this change was responsible for
> the latency regression seen in crbug.com/959048.
> 
> Original change's description:
> > Disable browser latency recovery for Viz on Android
> > 
> > We disabled this for the renderer in M73/M74. We missed the browser
> > component. Making these uniform.
> > 
> > Bug: 943186, 933846
> > Change-Id: I5098aca0189a66c3ce05df6c108af39cd2ca3fc1
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528915
> > Reviewed-by: Jonathan Ross <jonross@chromium.org>
> > Commit-Queue: Eric Karl <ericrk@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#642187}
> 
> TBR=sadrul@chromium.org,jonross@chromium.org,ericrk@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 959048
> Change-Id: If1619c4015479e0acb0030701c98e8bd8e492c1f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653576
> Reviewed-by: Eric Karl <ericrk@chromium.org>
> Commit-Queue: Eric Karl <ericrk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#668212}

TBR=sadrul@chromium.org,jonross@chromium.org,ericrk@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 959048
Change-Id: I8c2966bb6dbbd963075eb89a740456ab1c8bb17f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678950Reviewed-by: default avatarEric Karl <ericrk@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672711}
parent 739d1c32
...@@ -556,6 +556,13 @@ void CompositorImpl::CreateLayerTreeHost() { ...@@ -556,6 +556,13 @@ void CompositorImpl::CreateLayerTreeHost() {
settings.single_thread_proxy_scheduler = true; settings.single_thread_proxy_scheduler = true;
settings.use_painted_device_scale_factor = true; settings.use_painted_device_scale_factor = true;
if (features::IsSurfaceSynchronizationEnabled()) {
// TODO(crbug.com/933846): LatencyRecovery is causing jank on Android.
// Disable in viz mode for now, with plan to disable more widely once
// viz launches.
settings.enable_latency_recovery = false;
}
animation_host_ = cc::AnimationHost::CreateMainInstance(); animation_host_ = cc::AnimationHost::CreateMainInstance();
cc::LayerTreeHost::InitParams params; cc::LayerTreeHost::InitParams params;
......
...@@ -3157,7 +3157,7 @@ cc::LayerTreeSettings RenderWidget::GenerateLayerTreeSettings( ...@@ -3157,7 +3157,7 @@ cc::LayerTreeSettings RenderWidget::GenerateLayerTreeSettings(
#if defined(OS_ANDROID) #if defined(OS_ANDROID)
if (features::IsSurfaceSynchronizationEnabled()) { if (features::IsSurfaceSynchronizationEnabled()) {
// TODO(crbug.com/933846): LatencyRecovery is causing jank on Android. // TODO(crbug.com/933846): LatencyRecovery is causing jank on Android.
// Disable in viz mode for now, with plant o disable more widely once // Disable in viz mode for now, with plan to disable more widely once
// viz launches. // viz launches.
settings.enable_latency_recovery = false; settings.enable_latency_recovery = false;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment