Commit cb3d31dc authored by battre's avatar battre Committed by Commit bot

DumpWithoutCrashing() if URLRequestHttpJob is killed while waiting for callback

BUG=432398

Review URL: https://codereview.chromium.org/892413007

Cr-Commit-Position: refs/heads/master@{#315052}
parent 72cf6e83
...@@ -10,6 +10,7 @@ ...@@ -10,6 +10,7 @@
#include "base/command_line.h" #include "base/command_line.h"
#include "base/compiler_specific.h" #include "base/compiler_specific.h"
#include "base/debug/alias.h" #include "base/debug/alias.h"
#include "base/debug/dump_without_crashing.h"
#include "base/file_version_info.h" #include "base/file_version_info.h"
#include "base/message_loop/message_loop.h" #include "base/message_loop/message_loop.h"
#include "base/metrics/field_trial.h" #include "base/metrics/field_trial.h"
...@@ -289,6 +290,12 @@ void URLRequestHttpJob::Start() { ...@@ -289,6 +290,12 @@ void URLRequestHttpJob::Start() {
} }
void URLRequestHttpJob::Kill() { void URLRequestHttpJob::Kill() {
if (awaiting_callback_) {
// TODO(battre) crbug.com/289715
// Simulate a crash to see who kills the job while it is waiting for a
// callback. This should not happen, see URLRequest::OrphanJob().
base::debug::DumpWithoutCrashing();
}
if (!transaction_.get()) if (!transaction_.get())
return; return;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment