Commit cb6a7105 authored by W. James MacLean's avatar W. James MacLean Committed by Commit Bot

Convert CHECK to DCHECK.

Now that we know this pathway is involved in the incorrect setting of
page scale factors for OOPIFs, convert this CHECK to a DCHECK.

Bug: 859428
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I4d8805056546cc6ada3525e57d307dbcb27e6f55
Reviewed-on: https://chromium-review.googlesource.com/1146329Reviewed-by: default avatarFady Samuel <fsamuel@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577351}
parent b04e4978
......@@ -4583,10 +4583,10 @@ std::unique_ptr<ScrollAndScaleSet> LayerTreeHostImpl::ProcessScrollDeltas() {
scroll_info->page_scale_delta =
active_tree_->page_scale_factor()->PullDeltaForMainThread();
// We should never process non-unit page_scale_delta for an OOPIF subframe.
// TODO(wjmaclean): Remove this check as a pre-condition to closing the bug.
// TODO(wjmaclean): Remove this DCHECK as a pre-condition to closing the bug.
// https://crbug.com/845097
CHECK(!settings().is_layer_tree_for_subframe ||
scroll_info->page_scale_delta == 1.f);
DCHECK(!settings().is_layer_tree_for_subframe ||
scroll_info->page_scale_delta == 1.f);
scroll_info->top_controls_delta =
active_tree()->top_controls_shown_ratio()->PullDeltaForMainThread();
scroll_info->elastic_overscroll_delta =
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment