Commit cb72efa1 authored by Victor Costan's avatar Victor Costan Committed by Commit Bot

test: Replace _TEST_CASE_ with _TEST_SUITE_ in...

test: Replace _TEST_CASE_ with _TEST_SUITE_ in /chrome/browser/chromeos/system/tray_accessibility_browsertest.cc.

Googletest is (at last) converging with industry-standard terminology
[1]. We previously called test suites "test cases", which was rather
confusing for folks coming from any other testing framework.

Chrome now has a googltest version that supports _TEST_SUITE_ macros
instead of _TEST_CASE_, so this CL cleans up some of the outdated usage.

[1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature

This CL was uploaded by git cl split.

R=tetsui@chromium.org

Bug: 925652
Change-Id: Ibda100f51a5749a1489641d0b86674f874175fc4
Reviewed-on: https://chromium-review.googlesource.com/c/1438257Reviewed-by: default avatarTetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626436}
parent dd5e7d22
......@@ -652,12 +652,11 @@ IN_PROC_BROWSER_TEST_P(TrayAccessibilityLoginTest,
EXPECT_TRUE(IsMenuButtonVisible());
}
INSTANTIATE_TEST_CASE_P(TrayAccessibilityTestInstance,
TrayAccessibilityTest,
testing::Values(PREF_SERVICE,
POLICY));
INSTANTIATE_TEST_CASE_P(TrayAccessibilityLoginTestInstance,
TrayAccessibilityLoginTest,
testing::Values(PREF_SERVICE, POLICY));
INSTANTIATE_TEST_SUITE_P(TrayAccessibilityTestInstance,
TrayAccessibilityTest,
testing::Values(PREF_SERVICE, POLICY));
INSTANTIATE_TEST_SUITE_P(TrayAccessibilityLoginTestInstance,
TrayAccessibilityLoginTest,
testing::Values(PREF_SERVICE, POLICY));
} // namespace chromeos
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment