Commit cb8cbd35 authored by Denis Kuznetsov's avatar Denis Kuznetsov Committed by Commit Bot

Speculatively re-enable ActiveDirectoryLogin* tests

After changes in issue 1058022 the tests are much less likely to
time out on dgb/*san bots.

If tests will flake again, please disable them indvidually rather
then by reverting this CL.

Bug: 1034481, 1031545
Bug: 1058022
Change-Id: I9c736f865d6f3cd5fedd675f5b480f6e0a458d8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152371Reviewed-by: default avatarRoman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760030}
parent 089ca2ff
......@@ -101,13 +101,7 @@ class ActiveDirectoryLoginAutocompleteTest : public ActiveDirectoryLoginTest {
} // namespace
// Test successful Active Directory login.
// TODO(https://crbug.com/1034481) Flaky on MSAN bots.
#if defined(MEMORY_SANITIZER)
#define MAYBE_LoginSuccess DISABLED_LoginSuccess
#else
#define MAYBE_LoginSuccess LoginSuccess
#endif
IN_PROC_BROWSER_TEST_F(ActiveDirectoryLoginTest, MAYBE_LoginSuccess) {
IN_PROC_BROWSER_TEST_F(ActiveDirectoryLoginTest, LoginSuccess) {
OobeBaseTest::WaitForSigninScreen();
ASSERT_TRUE(InstallAttributes::Get()->IsActiveDirectoryManaged());
ad_login_.TestNoError();
......@@ -119,13 +113,7 @@ IN_PROC_BROWSER_TEST_F(ActiveDirectoryLoginTest, MAYBE_LoginSuccess) {
// Tests that the Kerberos SSO environment variables are set correctly after
// an Active Directory log in.
// TODO(https://crbug.com/1034481) Flaky on MSAN bots.
#if defined(MEMORY_SANITIZER)
#define MAYBE_KerberosVarsCopied DISABLED_KerberosVarsCopied
#else
#define MAYBE_KerberosVarsCopied KerberosVarsCopied
#endif
IN_PROC_BROWSER_TEST_F(ActiveDirectoryLoginTest, MAYBE_KerberosVarsCopied) {
IN_PROC_BROWSER_TEST_F(ActiveDirectoryLoginTest, KerberosVarsCopied) {
OobeBaseTest::WaitForSigninScreen();
ad_login_.TestNoError();
ad_login_.TestDomainHidden();
......@@ -256,14 +244,7 @@ IN_PROC_BROWSER_TEST_F(ActiveDirectoryLoginTest,
}
// Tests that autocomplete works. Submits username without domain.
// TODO(1031545): Flaky under MSAN.
#if defined(MEMORY_SANITIZER)
#define MAYBE_LoginSuccess DISABLED_LoginSuccess
#else
#define MAYBE_LoginSuccess LoginSuccess
#endif
IN_PROC_BROWSER_TEST_F(ActiveDirectoryLoginAutocompleteTest,
MAYBE_LoginSuccess) {
IN_PROC_BROWSER_TEST_F(ActiveDirectoryLoginAutocompleteTest, LoginSuccess) {
OobeBaseTest::WaitForSigninScreen();
ASSERT_TRUE(InstallAttributes::Get()->IsActiveDirectoryManaged());
ad_login_.TestNoError();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment