Commit cbf7dd6e authored by Andrew Grieve's avatar Andrew Grieve Committed by Commit Bot

Android: Update crash keys when a DFM is on-demand installed.

Bug: 1096191
Change-Id: Id4856a9366f62cd657232e6ab37a7c75c30196e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256771Reviewed-by: default avatarTibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: default avatarFred Mello <fredmello@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#790691}
parent f56c8f8e
......@@ -99,6 +99,7 @@ class SplitCompatEngine implements InstallEngine {
switch (status) {
case SplitInstallSessionStatus.INSTALLED:
mFacade.updateCrashKeys();
notifyListeners(moduleName, true);
break;
case SplitInstallSessionStatus.FAILED:
......
......@@ -55,4 +55,8 @@ class SplitCompatEngineFacade {
public SplitInstallRequest createSplitInstallRequest(String moduleName) {
return SplitInstallRequest.newBuilder().addModule(moduleName).build();
}
public void updateCrashKeys() {
ModuleUtil.updateCrashKeys();
}
}
......@@ -240,7 +240,7 @@ public class SplitCompatEngineTest {
doReturn(status).when(state).status();
doReturn(Arrays.asList(moduleName)).when(state).moduleNames();
InOrder inOrder = inOrder(listener, mManager, mLogger);
InOrder inOrder = inOrder(listener, mManager, mLogger, mInstallerFacade);
ArgumentCaptor<SplitInstallStateUpdatedListener> arg =
ArgumentCaptor.forClass(SplitInstallStateUpdatedListener.class);
......@@ -250,6 +250,7 @@ public class SplitCompatEngineTest {
arg.getValue().onStateUpdate(state);
// Assert.
inOrder.verify(mInstallerFacade, times(1)).updateCrashKeys();
inOrder.verify(listener, times(1)).onComplete(true);
inOrder.verify(mManager, times(1)).unregisterListener(any());
inOrder.verify(mLogger, times(1)).logStatus(moduleName, status);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment