Polishing in PasswordFormManager.

Addressing one TODO and removed several already addressed TODOs.

Change-Id: I8b4e1f96fb67e47d97c5eced35992c237e6043fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007690Reviewed-by: Matthias Körber <koerber@google.com>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Auto-Submit: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732885}

components/password_manager/core/browser/password_form_manager.cc

@@ -293,9 +293,6 @@ void PasswordFormManager::OnUpdateUsernameFromPrompt(
   // uploaded.
   votes_uploader_.set_has_username_edited_vote(false);
   if (!new_username.empty()) {
-    // |all_possible_usernames| has all possible usernames.
-    // TODO(crbug.com/831123): rename to |all_possible_usernames| when the old
-    // parser is gone.
     for (const auto& possible_username :
          parsed_submitted_form_->all_possible_usernames) {
       if (possible_username.first == new_username) {
@@ -586,6 +583,16 @@ void PasswordFormManager::OnFetchCompleted() {
   }
 }
 
+void PasswordFormManager::CreatePendingCredentials() {
+  DCHECK(is_submitted_);
+  if (!parsed_submitted_form_)
+    return;
+
+  password_save_manager_->CreatePendingCredentials(
+      *parsed_submitted_form_, observed_form_, submitted_form_, IsHttpAuth(),
+      IsCredentialAPISave());
+}
+
 bool PasswordFormManager::ProvisionallySave(
     const FormData& submitted_form,
     const PasswordManagerDriver* driver,
@@ -812,20 +819,6 @@ void PasswordFormManager::ReportTimeBetweenStoreAndServerUMA() {
   }
 }
 
-// TODO(https://crbug.com/831123): move this function to the proper place
-// corresponding to its place in the header.
-void PasswordFormManager::CreatePendingCredentials() {
-  DCHECK(is_submitted_);
-  // TODO(https://crbug.com/831123): Process correctly the case when saved
-  // credentials are not received from the store yet.
-  if (!parsed_submitted_form_)
-    return;
-
-  password_save_manager_->CreatePendingCredentials(
-      *parsed_submitted_form_, observed_form_, submitted_form_, IsHttpAuth(),
-      IsCredentialAPISave());
-}
-
 void PasswordFormManager::FillHttpAuth() {
   DCHECK(IsHttpAuth());
   if (!form_fetcher_->GetPreferredMatch())

components/password_manager/core/browser/password_form_manager.h

@@ -284,7 +284,7 @@ class PasswordFormManager : public PasswordFormManagerForUI,
   base::WeakPtr<PasswordManagerDriver> driver_;
 
   // Id of |driver_|. Cached since |driver_| might become null when frame is
-  // close..
+  // close.
   int driver_id_ = 0;
 
   // TODO(https://crbug.com/943045): use std::variant for keeping