Commit cc1c38d8 authored by tonyg@chromium.org's avatar tonyg@chromium.org

Revert of Update speedometer to use results.AddValue (https://codereview.chromium.org/386893004/)

Reason for revert:
Breaks speedometer. Should be a ListOfScalarValues.

Traceback (most recent call last):
  _RunPage at tools/telemetry/telemetry/page/page_runner.py:534
    test.RunPage(page, page_state.tab, results)
  RunPage at tools/telemetry/telemetry/page/page_test.py:247
    self.ValidatePage(page, tab, results)
  ValidatePage at tools/telemetry/telemetry/page/page_measurement.py:62
    self.MeasurePage(page, tab, results)
  MeasurePage at tools/perf/benchmarks/speedometer.py:36
    tab.EvaluateJavaScript('benchmarkClient._timeValues')))
  __init__ at tools/telemetry/telemetry/value/scalar.py:19
    assert isinstance(value, numbers.Number)
AssertionError

Locals:
  important : True
  name      : 'Total'
  page      : <telemetry.page.page.Page object at 0x1d6e590>
  units     : 'ms'
  value     : [13237.9869999991, 13351.2720000012, 14052.7640000023, 14136.3950000013, 13685.9580000001, 14048.2879999999, 14010.3279999989, 13941.6210000018, 14087.0519999998, 13388.6279999983]

Original issue's description:
> Update speedometer to use results.AddValue
> 
> BUG=391943
> TBR=nduca@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282750

TBR=nduca@chromium.org,nednguyen@google.com
NOTREECHECKS=true
NOTRY=true
BUG=391943

Review URL: https://codereview.chromium.org/387953006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282784 0039d316-1c4b-4281-b951-d872f2087c98
parent a6e21c37
...@@ -21,7 +21,6 @@ import os ...@@ -21,7 +21,6 @@ import os
from telemetry import benchmark from telemetry import benchmark
from telemetry.page import page_measurement from telemetry.page import page_measurement
from telemetry.page import page_set from telemetry.page import page_set
from telemetry.value import scalar
class SpeedometerMeasurement(page_measurement.PageMeasurement): class SpeedometerMeasurement(page_measurement.PageMeasurement):
...@@ -31,9 +30,8 @@ class SpeedometerMeasurement(page_measurement.PageMeasurement): ...@@ -31,9 +30,8 @@ class SpeedometerMeasurement(page_measurement.PageMeasurement):
tab.ExecuteJavaScript('benchmarkClient.iterationCount = 10; startTest();') tab.ExecuteJavaScript('benchmarkClient.iterationCount = 10; startTest();')
tab.WaitForJavaScriptExpression( tab.WaitForJavaScriptExpression(
'benchmarkClient._finishedTestCount == benchmarkClient.testsCount', 600) 'benchmarkClient._finishedTestCount == benchmarkClient.testsCount', 600)
results.AddValue(scalar.ScalarValue( results.Add(
results.current_page, 'Total', 'ms', 'Total', 'ms', tab.EvaluateJavaScript('benchmarkClient._timeValues'))
tab.EvaluateJavaScript('benchmarkClient._timeValues')))
@benchmark.Disabled('android') # Times out @benchmark.Disabled('android') # Times out
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment