Commit cc26f3c1 authored by Marijn Kruisselbrink's avatar Marijn Kruisselbrink Committed by Commit Bot

Disable flaky ConstrainedWindowViewTest.TabSwitchTest on ASAN

This test has been very flaky on ASAN build lately, so disabling. See
bug for details.

Tbr: msw@chromium.org
Bug: 997634
Change-Id: Ie04c0795470860891feabdda9d3dbce3c2a40a3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769585Reviewed-by: default avatarMichael Wasserman <msw@chromium.org>
Reviewed-by: default avatarMarijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690427}
parent 541c78fc
......@@ -134,7 +134,13 @@ IN_PROC_BROWSER_TEST_F(ConstrainedWindowViewTest, TabCloseTest) {
// Tests that the tab-modal window is hidden when an other tab is selected and
// shown when its tab is selected again.
IN_PROC_BROWSER_TEST_F(ConstrainedWindowViewTest, TabSwitchTest) {
// Flaky on ASAN builds (https://crbug.com/997634)
#if defined(ADDRESS_SANITIZER)
#define MAYBE_TabSwitchTest DISABLED_TabSwitchTest
#else
#define MAYBE_TabSwitchTest TabSwitchTest
#endif
IN_PROC_BROWSER_TEST_F(ConstrainedWindowViewTest, MAYBE_TabSwitchTest) {
std::unique_ptr<TestDialog> dialog =
ShowModalDialog(browser()->tab_strip_model()->GetActiveWebContents());
EXPECT_TRUE(dialog->GetWidget()->IsVisible());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment