Commit cc308cff authored by Javier Fernandez's avatar Javier Fernandez Committed by Commit Bot

[css-text] Fix test and update TestEpectations

The test word-break-break-all-inline-006.html is incorrectly defined, as
it was agreed in the corresponding CSS WG issue [1].

This CL changes the expected result of the test and updates the
TestExpectations accordingly, since it was failing for LayoutNG before.

The new expected result matches current LayoutNG's and Gecko's behavior,
but it implies that it fails in legacy and WebKit.

[1] https://github.com/web-platform-tests/wpt/issues/19903

Change-Id: Ia31c89f1a4084607fbb29fd0422354b754a092d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905549
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: default avatarKoji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714458}
parent fa9d0270
...@@ -137,6 +137,7 @@ crbug.com/591099 external/wpt/css/css-text/white-space/line-edge-white-space-col ...@@ -137,6 +137,7 @@ crbug.com/591099 external/wpt/css/css-text/white-space/line-edge-white-space-col
### external/wpt/css/css-text/word-break/ ### external/wpt/css/css-text/word-break/
crbug.com/591099 external/wpt/css/css-text/word-break/word-break-break-all-004.html [ Failure ] crbug.com/591099 external/wpt/css/css-text/word-break/word-break-break-all-004.html [ Failure ]
crbug.com/964181 external/wpt/css/css-text/word-break/word-break-break-all-inline-006.html [ Failure ]
crbug.com/1017164 external/wpt/css/css-text/word-break/word-break-break-all-inline-008.html [ Failure ] crbug.com/1017164 external/wpt/css/css-text/word-break/word-break-break-all-inline-008.html [ Failure ]
### external/wpt/css/css-ui/ ### external/wpt/css/css-ui/
......
...@@ -727,7 +727,6 @@ crbug.com/591099 external/wpt/css/css-text/line-breaking/line-breaking-019.html ...@@ -727,7 +727,6 @@ crbug.com/591099 external/wpt/css/css-text/line-breaking/line-breaking-019.html
crbug.com/591099 external/wpt/css/css-text/shaping/shaping-009.html [ Failure ] crbug.com/591099 external/wpt/css/css-text/shaping/shaping-009.html [ Failure ]
crbug.com/591099 external/wpt/css/css-text/shaping/shaping-010.html [ Failure ] crbug.com/591099 external/wpt/css/css-text/shaping/shaping-010.html [ Failure ]
crbug.com/591099 external/wpt/css/css-text/shaping/shaping-011.html [ Failure ] crbug.com/591099 external/wpt/css/css-text/shaping/shaping-011.html [ Failure ]
crbug.com/591099 external/wpt/css/css-text/word-break/word-break-break-all-inline-006.html [ Failure ]
crbug.com/1002815 external/wpt/css/cssom-view/offsetTopLeft-trailing-space-inline.html [ Failure ] crbug.com/1002815 external/wpt/css/cssom-view/offsetTopLeft-trailing-space-inline.html [ Failure ]
crbug.com/1012294 external/wpt/css/css-lists/list-style-type-string-003.html [ Failure ] crbug.com/1012294 external/wpt/css/css-lists/list-style-type-string-003.html [ Failure ]
crbug.com/1012294 external/wpt/css/css-lists/list-style-type-string-007.html [ Failure ] crbug.com/1012294 external/wpt/css/css-lists/list-style-type-string-007.html [ Failure ]
...@@ -2046,8 +2045,6 @@ crbug.com/626703 external/wpt/css/css-text/text-transform/text-transform-upperlo ...@@ -2046,8 +2045,6 @@ crbug.com/626703 external/wpt/css/css-text/text-transform/text-transform-upperlo
crbug.com/626703 external/wpt/css/css-text/word-break/word-break-break-all-007.html [ Failure ] crbug.com/626703 external/wpt/css/css-text/word-break/word-break-break-all-007.html [ Failure ]
crbug.com/626703 external/wpt/css/css-text/word-break/word-break-break-all-006.html [ Failure ] crbug.com/626703 external/wpt/css/css-text/word-break/word-break-break-all-006.html [ Failure ]
crbug.com/626703 external/wpt/css/css-text/word-break/word-break-break-all-008.html [ Failure ] crbug.com/626703 external/wpt/css/css-text/word-break/word-break-break-all-008.html [ Failure ]
crbug.com/964181 external/wpt/css/css-text/word-break/word-break-break-all-inline-004.html [ Failure ]
crbug.com/964181 external/wpt/css/css-text/word-break/word-break-break-all-inline-007.html [ Failure ]
crbug.com/626703 [ Linux ] external/wpt/css/css-text/word-break/word-break-normal-bo-000.html [ Failure ] crbug.com/626703 [ Linux ] external/wpt/css/css-text/word-break/word-break-normal-bo-000.html [ Failure ]
crbug.com/626703 [ Win ] external/wpt/css/css-text/word-break/word-break-normal-km-000.html [ Failure ] crbug.com/626703 [ Win ] external/wpt/css/css-text/word-break/word-break-normal-km-000.html [ Failure ]
crbug.com/626703 external/wpt/css/css-text/word-break/word-break-normal-my-000.html [ Failure ] crbug.com/626703 external/wpt/css/css-text/word-break/word-break-normal-my-000.html [ Failure ]
...@@ -3854,10 +3851,12 @@ crbug.com/626703 [ Win10 ] external/wpt/preload/delaying-onload-link-preload-aft ...@@ -3854,10 +3851,12 @@ crbug.com/626703 [ Win10 ] external/wpt/preload/delaying-onload-link-preload-aft
crbug.com/626703 [ Win ] external/wpt/css/css-writing-modes/box-offsets-rel-pos-vlr-005.xht [ Failure ] crbug.com/626703 [ Win ] external/wpt/css/css-writing-modes/box-offsets-rel-pos-vlr-005.xht [ Failure ]
crbug.com/626703 [ Win ] external/wpt/css/css-writing-modes/box-offsets-rel-pos-vrl-004.xht [ Failure ] crbug.com/626703 [ Win ] external/wpt/css/css-writing-modes/box-offsets-rel-pos-vrl-004.xht [ Failure ]
crbug.com/1020749 external/wpt/css/css-text/overflow-wrap/overflow-wrap-anywhere-inline-002.html [ Failure ] crbug.com/964181 external/wpt/css/css-text/overflow-wrap/overflow-wrap-anywhere-inline-002.html [ Failure ]
crbug.com/1020749 external/wpt/css/css-text/overflow-wrap/overflow-wrap-anywhere-inline-003.html [ Failure ] crbug.com/964181 external/wpt/css/css-text/overflow-wrap/overflow-wrap-anywhere-inline-003.html [ Failure ]
crbug.com/1020749 external/wpt/css/css-text/word-break/word-break-break-all-inline-009.html [ Failure ] crbug.com/964181 external/wpt/css/css-text/word-break/word-break-break-all-inline-004.html [ Failure ]
crbug.com/1020749 external/wpt/css/css-text/word-break/word-break-break-all-inline-010.html [ Failure ] crbug.com/964181 external/wpt/css/css-text/word-break/word-break-break-all-inline-007.html [ Failure ]
crbug.com/964181 external/wpt/css/css-text/word-break/word-break-break-all-inline-009.html [ Failure ]
crbug.com/964181 external/wpt/css/css-text/word-break/word-break-break-all-inline-010.html [ Failure ]
# Sheriff 2019-08-19: # Sheriff 2019-08-19:
crbug.com/626703 external/wpt/html/cross-origin-embedder-policy/none.https.html [ Failure ] crbug.com/626703 external/wpt/html/cross-origin-embedder-policy/none.https.html [ Failure ]
......
...@@ -5,5 +5,5 @@ ...@@ -5,5 +5,5 @@
.testdiv { font-family: monospace; width: 6.1ch; padding: 1px; margin: 10px; border: 1px solid silver; } .testdiv { font-family: monospace; width: 6.1ch; padding: 1px; margin: 10px; border: 1px solid silver; }
</style> </style>
<div>Test passes if the two boxes are the same.</div> <div>Test passes if the two boxes are the same.</div>
<div class="testdiv">aaaabb<br>bbbbbb<br>bbbccccc</div> <div class="testdiv">aaaabb<br>bbbbbb<br>bbb<br>ccccc</div>
<div class="testdiv">aaaabb<br>bbbbbb<br>bbbccccc</div> <div class="testdiv">aaaabb<br>bbbbbb<br>bbb<br>ccccc</div>
...@@ -11,4 +11,10 @@ ...@@ -11,4 +11,10 @@
</style> </style>
<div>Test passes if the two boxes are the same.</div> <div>Test passes if the two boxes are the same.</div>
<div class="testdiv">aaaa<span class="test">bbbbbbbbbbb</span>ccccc</div> <div class="testdiv">aaaa<span class="test">bbbbbbbbbbb</span>ccccc</div>
<div class="testdiv">aaaabb<br>bbbbbb<br>bbbccccc</div> <!--
Some browsers may decide to break before the last 'b', which is still conformant from the spec
perspective. However, this test would fail in that case. Current spec states that behavior is
undefined in the boundaries of the inline-box. See https://github.com/web-platform-tests/wpt/issues/19903
and https://github.com/w3c/csswg-drafts/issues/3897 for details.
-->
<div class="testdiv">aaaabb<br>bbbbbb<br>bbb<br>ccccc</div>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment