Commit cc317d1b authored by Ying Ye's avatar Ying Ye Committed by Commit Bot

Create one row in crash report for each key/value pair in extra_info

Bug: internal b/171233251
Test: triggered crash and checked crash report
Change-Id: If24d4a2d74969b9ddb6cab002baba95c241cb210
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530794Reviewed-by: default avatarSergey Volk <servolk@chromium.org>
Reviewed-by: default avatarYuchen Liu <yucliu@chromium.org>
Commit-Queue: Ying Ye <yingye@google.com>
Cr-Commit-Position: refs/heads/master@{#826431}
parent 127d99bb
...@@ -20,6 +20,7 @@ ...@@ -20,6 +20,7 @@
#include "base/logging.h" #include "base/logging.h"
#include "base/path_service.h" #include "base/path_service.h"
#include "base/single_thread_task_runner.h" #include "base/single_thread_task_runner.h"
#include "base/strings/string_split.h"
#include "base/threading/thread_task_runner_handle.h" #include "base/threading/thread_task_runner_handle.h"
#include "chromecast/base/cast_paths.h" #include "chromecast/base/cast_paths.h"
#include "chromecast/base/pref_names.h" #include "chromecast/base/pref_names.h"
...@@ -45,8 +46,6 @@ const char kVirtualChannel[] = "virtual-channel"; ...@@ -45,8 +46,6 @@ const char kVirtualChannel[] = "virtual-channel";
const char kLatestUiVersion[] = "latest-ui-version"; const char kLatestUiVersion[] = "latest-ui-version";
const char kExtraInfoKey[] = "extra_info";
typedef std::vector<std::unique_ptr<DumpInfo>> DumpList; typedef std::vector<std::unique_ptr<DumpInfo>> DumpList;
std::unique_ptr<PrefService> CreatePrefService() { std::unique_ptr<PrefService> CreatePrefService() {
...@@ -253,7 +252,19 @@ bool MinidumpUploader::DoWork() { ...@@ -253,7 +252,19 @@ bool MinidumpUploader::DoWork() {
g.SetParameter("stadia_session_id", dump.params().stadia_session_id); g.SetParameter("stadia_session_id", dump.params().stadia_session_id);
} }
if (!dump.params().extra_info.empty()) { if (!dump.params().extra_info.empty()) {
g.SetParameter(kExtraInfoKey, dump.params().extra_info); std::vector<std::string> pairs = base::SplitString(dump.params().extra_info,
" ",
base::TRIM_WHITESPACE,
base::SPLIT_WANT_NONEMPTY
);
for (const auto& pair : pairs) {
std::vector<std::string> key_value =
base::SplitString(pair, "=", base::TRIM_WHITESPACE,
base::SPLIT_WANT_NONEMPTY);
if (key_value.size() == 2) {
g.SetParameter(key_value[0], key_value[1]);
}
}
} }
std::string response; std::string response;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment