Commit cc471af4 authored by Mohamed Amir Yosef's avatar Mohamed Amir Yosef Committed by Commit Bot

[Passwords] Properly support RTL layout in password move bubble

Screenshot in Arabic layout:
https://screenshot.googleplex.com/e5b8YLfe7dV.png

Bug: 1100814
Change-Id: I5096449c43e53caafef6a634cfd7850c9a67d7e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302150
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: default avatarVasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789488}
parent 4e57a0e3
...@@ -49,7 +49,7 @@ class ImageViewWithPlaceForBadge : public views::ImageView { ...@@ -49,7 +49,7 @@ class ImageViewWithPlaceForBadge : public views::ImageView {
// Remove the part of the ImageView that contains the badge. // Remove the part of the ImageView that contains the badge.
SkPath mask; SkPath mask;
mask.addCircle( mask.addCircle(
/*x=*/kBadgedProfilePhotoSize - kBadgeIconSize / 2, /*x=*/GetMirroredXInView(kBadgedProfilePhotoSize - kBadgeIconSize / 2),
/*y=*/kBadgedProfilePhotoSize - kBadgeIconSize / 2, /*y=*/kBadgedProfilePhotoSize - kBadgeIconSize / 2,
/*radius=*/kBadgeIconSize / 2 + kBadgeBorderWidth); /*radius=*/kBadgeIconSize / 2 + kBadgeBorderWidth);
mask.toggleInverseFillType(); mask.toggleInverseFillType();
...@@ -190,10 +190,9 @@ MoveToAccountStoreBubbleView::MovingBannerView::MovingBannerView( ...@@ -190,10 +190,9 @@ MoveToAccountStoreBubbleView::MovingBannerView::MovingBannerView(
from_view = AddChildView(std::move(from_image)); from_view = AddChildView(std::move(from_image));
// TODO(crbug.com/1100814): this arrow will point to the wrong direction in
// RTL setup.
auto arrow_view = std::make_unique<VectorIconView>( auto arrow_view = std::make_unique<VectorIconView>(
kBookmarkbarTouchOverflowIcon, kImageSize); kBookmarkbarTouchOverflowIcon, kImageSize);
arrow_view->EnableCanvasFlippingForRTLUI(true);
AddChildView(std::move(arrow_view)); AddChildView(std::move(arrow_view));
to_view = AddChildView(std::move(to_image)); to_view = AddChildView(std::move(to_image));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment