Extract constants from signin_promo_view.h.

- Added new files for constants.
- Added constants target in BUILD.gn for new files.
- Added/Modified headers of where the constants are used.

This is preparing for SigninEarlGreyUI and SigninEarlGreyUtils EG2
migrations.

Bug: 922813, 1015907
Change-Id: I41fc3223ebef4ba4e52e7f60e670eb6fdb0b42b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885225
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710496}

ios/chrome/browser/ui/authentication/cells/BUILD.gn

@@ -35,6 +35,9 @@ source_set("cells") {
     "//ios/public/provider/chrome/browser/signin",
     "//ui/base",
   ]
+  public_deps = [
+    ":constants",
+  ]
   libs = [ "UIKit.framework" ]
 }
 
@@ -81,3 +84,12 @@ source_set("unit_tests") {
     "//ui/base",
   ]
 }
+
+source_set("constants") {
+  configs += [ "//build/config/compiler:enable_arc" ]
+  sources = [
+    "signin_promo_view_constants.h",
+    "signin_promo_view_constants.mm",
+  ]
+  libs = [ "Foundation.framework" ]
+}

ios/chrome/browser/ui/authentication/cells/signin_promo_view.h

@@ -7,20 +7,9 @@
 
 #import <UIKit/UIKit.h>
 
-@protocol SigninPromoViewDelegate;
-
-typedef NS_ENUM(NSInteger, SigninPromoViewMode) {
-  // No identity available on the device.
-  SigninPromoViewModeColdState,
-  // At least one identity is available on the device and the user can sign
-  // without entering their credentials.
-  SigninPromoViewModeWarmState,
-};
+#import "ios/chrome/browser/ui/authentication/cells/signin_promo_view_constants.h"
 
-extern NSString* const kSigninPromoViewId;
-extern NSString* const kSigninPromoPrimaryButtonId;
-extern NSString* const kSigninPromoSecondaryButtonId;
-extern NSString* const kSigninPromoCloseButtonId;
+@protocol SigninPromoViewDelegate;
 
 // This class creates an image view, a label and 2 buttons. This view can be
 // configured with 2 modes : "Cold State" and "Warm State".

ios/chrome/browser/ui/authentication/cells/signin_promo_view.mm

@@ -8,6 +8,7 @@
 #include "base/mac/foundation_util.h"
 #include "build/branding_buildflags.h"
 #include "components/signin/public/base/signin_metrics.h"
+#import "ios/chrome/browser/ui/authentication/cells/signin_promo_view_constants.h"
 #import "ios/chrome/browser/ui/authentication/cells/signin_promo_view_delegate.h"
 #import "ios/chrome/browser/ui/colors/MDCPalette+CrAdditions.h"
 #import "ios/chrome/browser/ui/util/uikit_ui_util.h"
@@ -48,12 +49,6 @@ const CGFloat kCloseButtonWidthHeight = 24;
 const CGFloat kImageViewWidthHeight = 32;
 }
 
-NSString* const kSigninPromoViewId = @"kSigninPromoViewId";
-NSString* const kSigninPromoPrimaryButtonId = @"kSigninPromoPrimaryButtonId";
-NSString* const kSigninPromoSecondaryButtonId =
-    @"kSigninPromoSecondaryButtonId";
-NSString* const kSigninPromoCloseButtonId = @"kSigninPromoCloseButtonId";
-
 @interface SigninPromoView ()
 // Re-declare as readwrite.
 @property(nonatomic, readwrite) UIImageView* imageView;

ios/chrome/browser/ui/authentication/cells/signin_promo_view_configurator.mm

@@ -6,6 +6,7 @@
 
 #include "base/strings/sys_string_conversions.h"
 #import "ios/chrome/browser/ui/authentication/cells/signin_promo_view.h"
+#import "ios/chrome/browser/ui/authentication/cells/signin_promo_view_constants.h"
 #include "ios/chrome/grit/ios_chromium_strings.h"
 #include "ios/chrome/grit/ios_strings.h"
 #import "ios/public/provider/chrome/browser/chrome_browser_provider.h"

ios/chrome/browser/ui/authentication/cells/signin_promo_view_constants.h

+// Copyright 2019 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef IOS_CHROME_BROWSER_UI_AUTHENTICATION_CELLS_SIGNIN_PROMO_VIEW_CONSTANTS_H_
+#define IOS_CHROME_BROWSER_UI_AUTHENTICATION_CELLS_SIGNIN_PROMO_VIEW_CONSTANTS_H_
+
+#import <Foundation/Foundation.h>
+
+typedef NS_ENUM(NSInteger, SigninPromoViewMode) {
+  // No identity available on the device.
+  SigninPromoViewModeColdState,
+  // At least one identity is available on the device and the user can sign
+  // without entering their credentials.
+  SigninPromoViewModeWarmState,
+};
+
+extern NSString* const kSigninPromoViewId;
+extern NSString* const kSigninPromoPrimaryButtonId;
+extern NSString* const kSigninPromoSecondaryButtonId;
+extern NSString* const kSigninPromoCloseButtonId;
+
+#endif  // IOS_CHROME_BROWSER_UI_AUTHENTICATION_CELLS_SIGNIN_PROMO_VIEW_CONSTANTS_H_

ios/chrome/browser/ui/authentication/cells/signin_promo_view_constants.mm

+// Copyright 2019 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#import "ios/chrome/browser/ui/authentication/cells/signin_promo_view_constants.h"
+
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
+NSString* const kSigninPromoViewId = @"kSigninPromoViewId";
+NSString* const kSigninPromoPrimaryButtonId = @"kSigninPromoPrimaryButtonId";
+NSString* const kSigninPromoSecondaryButtonId =
+    @"kSigninPromoSecondaryButtonId";
+NSString* const kSigninPromoCloseButtonId = @"kSigninPromoCloseButtonId";

ios/chrome/browser/ui/authentication/cells/signin_promo_view_unittest.mm

@@ -4,6 +4,7 @@
 
 #import "ios/chrome/browser/ui/authentication/cells/signin_promo_view.h"
 
+#import "ios/chrome/browser/ui/authentication/cells/signin_promo_view_constants.h"
 #import "ios/third_party/material_components_ios/src/components/Buttons/src/MaterialButtons.h"
 #include "testing/platform_test.h"
 #include "third_party/ocmock/gtest_support.h"

ios/chrome/browser/ui/authentication/signin_earl_grey_ui.h

@@ -7,7 +7,7 @@
 
 #import <Foundation/Foundation.h>
 
-#import "ios/chrome/browser/ui/authentication/cells/signin_promo_view.h"
+#import "ios/chrome/browser/ui/authentication/cells/signin_promo_view_constants.h"
 
 @class ChromeIdentity;
 

ios/chrome/browser/ui/authentication/signin_earl_grey_ui.mm

@@ -7,6 +7,7 @@
 #import <EarlGrey/EarlGrey.h>
 
 #include "base/mac/foundation_util.h"
+#import "ios/chrome/browser/ui/authentication/cells/signin_promo_view_constants.h"
 #import "ios/chrome/browser/ui/authentication/signin_earlgrey_utils.h"
 #import "ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/identity_chooser_cell.h"
 #import "ios/chrome/browser/ui/authentication/unified_consent/identity_picker_view.h"

ios/chrome/browser/ui/authentication/signin_promo_view_mediator_unittest.mm

@@ -11,6 +11,7 @@
 #include "ios/chrome/browser/signin/chrome_identity_service_observer_bridge.h"
 #import "ios/chrome/browser/ui/authentication/cells/signin_promo_view.h"
 #import "ios/chrome/browser/ui/authentication/cells/signin_promo_view_configurator.h"
+#import "ios/chrome/browser/ui/authentication/cells/signin_promo_view_constants.h"
 #import "ios/chrome/browser/ui/authentication/cells/signin_promo_view_consumer.h"
 #include "ios/chrome/grit/ios_chromium_strings.h"
 #include "ios/chrome/grit/ios_strings.h"

ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm

@@ -20,7 +20,7 @@
 #include "ios/chrome/browser/bookmarks/bookmark_model_factory.h"
 #include "ios/chrome/browser/browser_state/chrome_browser_state.h"
 #include "ios/chrome/browser/pref_names.h"
-#import "ios/chrome/browser/ui/authentication/cells/signin_promo_view.h"
+#import "ios/chrome/browser/ui/authentication/cells/signin_promo_view_constants.h"
 #import "ios/chrome/browser/ui/authentication/signin_earl_grey_ui.h"
 #import "ios/chrome/browser/ui/authentication/signin_earlgrey_utils.h"
 #import "ios/chrome/browser/ui/bookmarks/bookmark_path_cache.h"

ios/chrome/browser/ui/recent_tabs/BUILD.gn

@@ -141,6 +141,7 @@ source_set("eg_tests") {
     "//ios/chrome/app/strings",
     "//ios/chrome/browser/tabs",
     "//ios/chrome/browser/ui/authentication:eg_test_support",
+    "//ios/chrome/browser/ui/authentication/cells:constants",
     "//ios/chrome/browser/ui/history:constants",
     "//ios/chrome/browser/ui/history:history_ui",
     "//ios/chrome/browser/ui/table_view",

ios/chrome/browser/ui/recent_tabs/recent_tabs_egtest.mm

@@ -13,6 +13,7 @@
 #include "components/strings/grit/components_strings.h"
 #import "ios/chrome/app/main_controller.h"
 #import "ios/chrome/browser/tabs/tab_model.h"
+#import "ios/chrome/browser/ui/authentication/cells/signin_promo_view_constants.h"
 #import "ios/chrome/browser/ui/authentication/signin_earl_grey_ui.h"
 #import "ios/chrome/browser/ui/authentication/signin_earlgrey_utils.h"
 #import "ios/chrome/browser/ui/history/history_ui_constants.h"

ios/chrome/browser/ui/settings/signin_settings_egtest.mm

@@ -8,6 +8,7 @@
 #include "components/prefs/pref_service.h"
 #include "ios/chrome/browser/browser_state/chrome_browser_state.h"
 #include "ios/chrome/browser/pref_names.h"
+#import "ios/chrome/browser/ui/authentication/cells/signin_promo_view_constants.h"
 #import "ios/chrome/browser/ui/authentication/signin_earl_grey_ui.h"
 #import "ios/chrome/browser/ui/authentication/signin_earlgrey_utils.h"
 #import "ios/chrome/browser/ui/settings/settings_table_view_controller.h"

ios/chrome/test/earl_grey/chrome_matchers_app_interface.mm

@@ -8,7 +8,7 @@
 #include "base/strings/sys_string_conversions.h"
 #include "components/strings/grit/components_strings.h"
 #import "ios/chrome/browser/autofill/form_suggestion_constants.h"
-#import "ios/chrome/browser/ui/authentication/cells/signin_promo_view.h"
+#import "ios/chrome/browser/ui/authentication/cells/signin_promo_view_constants.h"
 #import "ios/chrome/browser/ui/autofill/manual_fill/address_mediator.h"
 #import "ios/chrome/browser/ui/autofill/manual_fill/address_view_controller.h"
 #import "ios/chrome/browser/ui/autofill/manual_fill/card_coordinator.h"