Commit cc93e761 authored by noms's avatar noms Committed by Commit bot

[Mac] Fix accessibility crash because I am terrible with dynamic types.

Turns out attributes like AXPosition will crash with @[] :/

BUG=412707
TEST=Start Chrome with --enable-new-avatar-menu. Provided you have zooming
enabled in your Mac Accessibility settings, press Ctrl and scroll up to zoom
in. Click on the avatar button. The avatar bubble should open and Chrome should
not crash.

Review URL: https://codereview.chromium.org/645933002

Cr-Commit-Position: refs/heads/master@{#299160}
parent 6a1f7b51
...@@ -780,7 +780,7 @@ class ActiveProfileObserverBridge : public AvatarMenuObserver, ...@@ -780,7 +780,7 @@ class ActiveProfileObserverBridge : public AvatarMenuObserver,
} }
- (id)accessibilityAttributeValue:(NSString*)attribute { - (id)accessibilityAttributeValue:(NSString*)attribute {
return @[]; return nil;
} }
- (BOOL)canBecomeKeyView { - (BOOL)canBecomeKeyView {
...@@ -1159,7 +1159,7 @@ class ActiveProfileObserverBridge : public AvatarMenuObserver, ...@@ -1159,7 +1159,7 @@ class ActiveProfileObserverBridge : public AvatarMenuObserver,
// Add a dummy, empty element so that we don't initially display any // Add a dummy, empty element so that we don't initially display any
// focus rings. // focus rings.
NSButton* dummyFocusButton = NSButton* dummyFocusButton =
[[[DummyWindowFocusButton alloc] initWithFrame:NSZeroRect] autorelease]; [[[DummyWindowFocusButton alloc] initWithFrame:NSZeroRect] autorelease];
[dummyFocusButton setNextKeyView:subView]; [dummyFocusButton setNextKeyView:subView];
[[self window] makeFirstResponder:dummyFocusButton]; [[self window] makeFirstResponder:dummyFocusButton];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment