Commit cc96ed02 authored by Matt Giuca's avatar Matt Giuca Committed by Commit Bot

Clean-up: Updated URLs in comments referencing web-share and web-share-target.

- Web Share spec has moved from WICG to W3C.
- Updated some Web Share Target URLs to point to the WICG spec, not the
  explainer.
- Updated some Web Share Target URLs to point to the WICG spec, not a
  draft on the pr-preview site.
- Removed some notes that say Web Share Target is part of an unlaunched
  experiment.

Change-Id: I48132388192d773d962d13bc9361778ddeb66e4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742258Reviewed-by: default avatarDominick Ng <dominickn@chromium.org>
Reviewed-by: default avatarTed Choc <tedchoc@chromium.org>
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685457}
parent 6ddfe0d8
...@@ -16,7 +16,7 @@ ...@@ -16,7 +16,7 @@
#include "third_party/skia/include/core/SkColor.h" #include "third_party/skia/include/core/SkColor.h"
#include "url/gurl.h" #include "url/gurl.h"
// https://pr-preview.s3.amazonaws.com/ewilligers/web-share-target/pull/53.html#sharetargetfiles-and-its-members // https://wicg.github.io/web-share-target/level-2/#sharetargetfiles-and-its-members
struct ShareTargetParamsFile { struct ShareTargetParamsFile {
base::string16 name; base::string16 name;
std::vector<base::string16> accept; std::vector<base::string16> accept;
......
...@@ -123,7 +123,7 @@ message Image { ...@@ -123,7 +123,7 @@ message Image {
} }
// A proto representing a ShareTargetParamsFile // A proto representing a ShareTargetParamsFile
// https://pr-preview.s3.amazonaws.com/ewilligers/web-share-target/pull/53.html#sharetargetfiles-and-its-members // https://wicg.github.io/web-share-target/level-2/#sharetargetfiles-and-its-members
message ShareTargetParamsFile { message ShareTargetParamsFile {
optional string name = 1; optional string name = 1;
repeated string accept = 2; repeated string accept = 2;
...@@ -133,7 +133,7 @@ message ShareTargetParamsFile { ...@@ -133,7 +133,7 @@ message ShareTargetParamsFile {
// https://wicg.github.io/web-share-target/#dom-sharetargetparams // https://wicg.github.io/web-share-target/#dom-sharetargetparams
// Each field corresponds to key in ShareData. These are the query parameter // Each field corresponds to key in ShareData. These are the query parameter
// keys to be used for the data supplied in a ShareData instance. // keys to be used for the data supplied in a ShareData instance.
// ShareData: https://wicg.github.io/web-share#dom-sharedata // ShareData: https://w3c.github.io/web-share#dom-sharedata
message ShareTargetParams { message ShareTargetParams {
optional string title = 1; optional string title = 1;
optional string text = 2; optional string text = 2;
......
...@@ -18,7 +18,7 @@ import java.util.Locale; ...@@ -18,7 +18,7 @@ import java.util.Locale;
* A mime type filter that supports filtering both mime types and file extensions. * A mime type filter that supports filtering both mime types and file extensions.
* Note that this class is used specifically to implement * Note that this class is used specifically to implement
* the mime type filtering for web share target spec: * the mime type filtering for web share target spec:
* https://pr-preview.s3.amazonaws.com/ewilligers/web-share-target/pull/53.html#determining-if-a-file-is-accepted. * https://wicg.github.io/web-share-target/level-2/#determining-if-a-file-is-accepted
* It is also used inside chrome/android/java/src/org/chromium/chrome/browser/photo_picker. * It is also used inside chrome/android/java/src/org/chromium/chrome/browser/photo_picker.
*/ */
public class MimeTypeFilter implements FileFilter { public class MimeTypeFilter implements FileFilter {
......
...@@ -162,10 +162,6 @@ struct BLINK_COMMON_EXPORT Manifest { ...@@ -162,10 +162,6 @@ struct BLINK_COMMON_EXPORT Manifest {
std::vector<ImageResource> icons; std::vector<ImageResource> icons;
// Null if parsing failed or the field was not present. // Null if parsing failed or the field was not present.
// TODO(constantina): This field is non-standard and part of a Chrome
// experiment. See:
// https://github.com/WICG/web-share-target/blob/master/docs/interface.md
// As such, this field should not be exposed to web contents.
base::Optional<ShareTarget> share_target; base::Optional<ShareTarget> share_target;
// Null if parsing failed or the field was not present. // Null if parsing failed or the field was not present.
......
...@@ -28,10 +28,6 @@ struct Manifest { ...@@ -28,10 +28,6 @@ struct Manifest {
array<ManifestImageResource> icons; array<ManifestImageResource> icons;
// TODO(constantina): This field is non-standard and part of a Chrome
// experiment. See:
// https://github.com/WICG/web-share-target/blob/master/docs/interface.md
// As such, this field should not be exposed to the drive-by web.
ManifestShareTarget? share_target; ManifestShareTarget? share_target;
// TODO(harrisjay): This field is non-standard and part of a Chrome // TODO(harrisjay): This field is non-standard and part of a Chrome
......
...@@ -148,7 +148,7 @@ class MODULES_EXPORT ManifestParser { ...@@ -148,7 +148,7 @@ class MODULES_EXPORT ManifestParser {
const JSONObject* object); const JSONObject* object);
// Parses the name field of a share target file, as defined in: // Parses the name field of a share target file, as defined in:
// https://github.com/WICG/web-share-target/blob/master/docs/interface.md // https://wicg.github.io/web-share-target/level-2/#sharetargetfiles-and-its-members
// Returns the parsed string if any, an empty string if the parsing failed. // Returns the parsed string if any, an empty string if the parsing failed.
String ParseFileFilterName(const JSONObject* file); String ParseFileFilterName(const JSONObject* file);
...@@ -171,26 +171,26 @@ class MODULES_EXPORT ManifestParser { ...@@ -171,26 +171,26 @@ class MODULES_EXPORT ManifestParser {
Vector<mojom::blink::ManifestFileFilterPtr>* files); Vector<mojom::blink::ManifestFileFilterPtr>* files);
// Parses the method field of a Share Target, as defined in: // Parses the method field of a Share Target, as defined in:
// https://github.com/WICG/web-share-target/blob/master/docs/interface.md // https://wicg.github.io/web-share-target/#sharetarget-and-its-members
// Returns an optional share target method enum object. // Returns an optional share target method enum object.
base::Optional<mojom::blink::ManifestShareTarget::Method> base::Optional<mojom::blink::ManifestShareTarget::Method>
ParseShareTargetMethod(const JSONObject* share_target_dict); ParseShareTargetMethod(const JSONObject* share_target_dict);
// Parses the enctype field of a Share Target, as defined in: // Parses the enctype field of a Share Target, as defined in:
// https://github.com/WICG/web-share-target/blob/master/docs/interface.md // https://wicg.github.io/web-share-target/#sharetarget-and-its-members
// Returns an optional share target enctype enum object. // Returns an optional share target enctype enum object.
base::Optional<mojom::blink::ManifestShareTarget::Enctype> base::Optional<mojom::blink::ManifestShareTarget::Enctype>
ParseShareTargetEnctype(const JSONObject* share_target_dict); ParseShareTargetEnctype(const JSONObject* share_target_dict);
// Parses the 'params' field of a Share Target, as defined in: // Parses the 'params' field of a Share Target, as defined in:
// https://wicg.github.io/web-share-target/level-2/#sharetargetparams-and-its-members // https://wicg.github.io/web-share-target/#sharetarget-and-its-members
// Returns a parsed mojom::blink:ManifestShareTargetParamsPtr, not all fields // Returns a parsed mojom::blink:ManifestShareTargetParamsPtr, not all fields
// need to be populated. // need to be populated.
mojom::blink::ManifestShareTargetParamsPtr ParseShareTargetParams( mojom::blink::ManifestShareTargetParamsPtr ParseShareTargetParams(
const JSONObject* share_target_params); const JSONObject* share_target_params);
// Parses the 'share_target' field of a Manifest, as defined in: // Parses the 'share_target' field of a Manifest, as defined in:
// https://github.com/WICG/web-share-target/blob/master/docs/interface.md // https://wicg.github.io/web-share-target/#share_target-member
// Returns the parsed Web Share target. The returned Share Target is null if // Returns the parsed Web Share target. The returned Share Target is null if
// the field didn't exist, parsing failed, or it was empty. // the field didn't exist, parsing failed, or it was empty.
base::Optional<mojom::blink::ManifestShareTargetPtr> ParseShareTarget( base::Optional<mojom::blink::ManifestShareTargetPtr> ParseShareTarget(
......
...@@ -55,7 +55,7 @@ bool HasFiles(const ShareData& share_data) { ...@@ -55,7 +55,7 @@ bool HasFiles(const ShareData& share_data) {
} }
// Returns a message for a TypeError if share(share_data) would reject with // Returns a message for a TypeError if share(share_data) would reject with
// TypeError. https://wicg.github.io/web-share/level-2/#canshare-method // TypeError. https://w3c.github.io/web-share/level-2/#canshare-method
// Otherwise returns an empty string. // Otherwise returns an empty string.
// Populates full_url with the result of running the URL parser on // Populates full_url with the result of running the URL parser on
// share_data.url // share_data.url
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// https://wicg.github.io/web-share/ // https://w3c.github.io/web-share/
[ [
ImplementedAs=NavigatorShare, ImplementedAs=NavigatorShare,
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// https://wicg.github.io/web-share/ // https://w3c.github.io/web-share/
dictionary ShareData { dictionary ShareData {
USVString title; USVString title;
......
spec: https://wicg.github.io/web-share/ spec: https://w3c.github.io/web-share/
suggested_reviewers: suggested_reviewers:
- ewilligers - ewilligers
- mgiuca - mgiuca
......
// META: script=/resources/WebIDLParser.js // META: script=/resources/WebIDLParser.js
// META: script=/resources/idlharness.js // META: script=/resources/idlharness.js
// https://wicg.github.io/web-share/ // https://w3c.github.io/web-share/
'use strict'; 'use strict';
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment