[Android][TouchToFill] Check and recreate Android view before usage

Relying on GetWindowAndroid() returning a non-null value causes crashes
in various instances. With this CL, the window is null-checked before
use an creation is deferred to when it's actually used.
If creation doesn't succeed on first try (e.g. because the window isn't
yet attached), a consecutive call might succeed.

This approach also has the advantage that the interface remains clean
and doesn't require handling the rare Android failure explicitly. This
is acceptable since failing to create the surface means, that the UI
isn't ready to show any information anyway or anymore.

Bug: 1049090
Change-Id: Iebc556e33226151cbc4fb8060653290ae0e22dc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037573
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#739347}

chrome/browser/touch_to_fill/android/touch_to_fill_view_impl.cc

@@ -48,20 +48,23 @@ UiCredential ConvertJavaCredential(JNIEnv* env,
 }  // namespace
 
 TouchToFillViewImpl::TouchToFillViewImpl(TouchToFillController* controller)
-    : controller_(controller) {
-  java_object_ = Java_TouchToFillBridge_create(
-      AttachCurrentThread(), reinterpret_cast<intptr_t>(this),
-      controller_->GetNativeView()->GetWindowAndroid()->GetJavaObject());
-}
+    : controller_(controller) {}
 
 TouchToFillViewImpl::~TouchToFillViewImpl() {
-  Java_TouchToFillBridge_destroy(AttachCurrentThread(), java_object_);
+  if (java_object_internal_) {
+    // Don't create an object just for destruction.
+    Java_TouchToFillBridge_destroy(AttachCurrentThread(),
+                                   java_object_internal_);
+  }
 }
 
 void TouchToFillViewImpl::Show(
     const GURL& url,
     IsOriginSecure is_origin_secure,
     base::span<const password_manager::UiCredential> credentials) {
+  auto java_object = GetOrCreateJavaObject();
+  if (!java_object)
+    return;
   // Serialize the |credentials| span into a Java array and instruct the bridge
   // to show it together with |url| to the user.
   JNIEnv* env = AttachCurrentThread();
@@ -80,7 +83,7 @@ void TouchToFillViewImpl::Show(
   }
 
   Java_TouchToFillBridge_showCredentials(
-      env, java_object_, ConvertUTF8ToJavaString(env, url.spec()),
+      env, java_object, ConvertUTF8ToJavaString(env, url.spec()),
       is_origin_secure.value(), credential_array);
 }
 
@@ -105,3 +108,17 @@ void TouchToFillViewImpl::OnManagePasswordsSelected(JNIEnv* env) {
 void TouchToFillViewImpl::OnDismiss(JNIEnv* env) {
   OnDismiss();
 }
+
+base::android::ScopedJavaGlobalRef<jobject>
+TouchToFillViewImpl::GetOrCreateJavaObject() {
+  if (java_object_internal_) {
+    return java_object_internal_;
+  }
+  if (controller_->GetNativeView() == nullptr ||
+      controller_->GetNativeView()->GetWindowAndroid() == nullptr) {
+    return nullptr;  // No window attached (yet or anymore).
+  }
+  return java_object_internal_ = Java_TouchToFillBridge_create(
+             AttachCurrentThread(), reinterpret_cast<intptr_t>(this),
+             controller_->GetNativeView()->GetWindowAndroid()->GetJavaObject());
+}

chrome/browser/touch_to_fill/android/touch_to_fill_view_impl.h

@@ -38,8 +38,14 @@ class TouchToFillViewImpl : public TouchToFillView {
   void OnDismiss(JNIEnv* env);
 
  private:
+  // Returns either the fully initialized java counterpart of this bridge or
+  // a is_null() reference if the creation failed. By using this method, the
+  // bridge will try to recreate the java object if it failed previously (e.g.
+  // because there was no native window available).
+  base::android::ScopedJavaGlobalRef<jobject> GetOrCreateJavaObject();
+
   TouchToFillController* controller_ = nullptr;
-  base::android::ScopedJavaGlobalRef<jobject> java_object_;
+  base::android::ScopedJavaGlobalRef<jobject> java_object_internal_;
 };
 
 #endif  // CHROME_BROWSER_TOUCH_TO_FILL_ANDROID_TOUCH_TO_FILL_VIEW_IMPL_H_