[Sync] Declare Sync.*ConfigureFailure and Sync.*AssociationTime by suffixes

These histograms were declared manually for all data types. As a result,
many of them (for newer data types) were missing. This CL uses histogram
suffixes instead.

This CL also puts the related suffix SyncModelType up-to-date.

Bug: 883252
Change-Id: Ia594f068919bee4ed233b7c1477460a7f04ab797
Reviewed-on: https://chromium-review.googlesource.com/1245117Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594613}

components/sync/base/data_type_histogram.h

@@ -39,6 +39,8 @@ void SyncRecordModelTypeCountHistogram(syncer::ModelType model_type,
 // in macros, pass in the histogram method directly as a parameter.
 // See http://connect.microsoft.com/VisualStudio/feedback/details/380090/
 // variadic-macro-replacement#details
+// When adding a new datatype in the switch below, also update the SyncModelType
+// and SyncModelTypeByMacro histogram suffixes in histograms.xml.
 #define SYNC_DATA_TYPE_HISTOGRAM(datatype)                       \
   do {                                                           \
     switch (datatype) {                                          \

components/sync/base/model_type.h

@@ -35,8 +35,9 @@ namespace syncer {
 // GENERATED_JAVA_ENUM_PACKAGE: org.chromium.components.sync
 //
 // |kModelTypeInfoMap| struct entries are in the same order as their definition
-// in ModelType enum. Don't forget to update the |kModelTypeInfoMap| struct in
-// model_type.cc when you make changes in ModelType enum.
+// in ModelType enum. When you make changes in ModelType enum, don't forget to
+// update the |kModelTypeInfoMap| struct in model_type.cc and also the
+// SyncModelType and SyncModelTypeByMacro histogram suffixes in histograms.xml
 enum ModelType {
   // Object type unknown.  Objects may transition through
   // the unknown state during their initial creation, before