Commit ccfb59af authored by Xiaocheng Hu's avatar Xiaocheng Hu Committed by Commit Bot

Revert "Eliminate NOSCRIPT element from TranslateHelper text dump"

This reverts commit 797a3802.

Reason for revert: The overall approach is a hack that keeps generating regressions

Original change's description:
> Eliminate NOSCRIPT element from TranslateHelper text dump
> 
> TranslateHelper uses a sample of the page text to determine the page
> language. This patch eliminates content of NOSCRIPT elements from the
> text dump, so that non-text contents in NOSCRIPT elements are not passed
> to TranslateHelper.
> 
> Bug: 813009
> Change-Id: Icf1781a69d17538103574bd149cb3d5851852a08
> Reviewed-on: https://chromium-review.googlesource.com/924111
> Reviewed-by: Rachel Blum <groby@chromium.org>
> Reviewed-by: Emil A Eklund <eae@chromium.org>
> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#537557}

TBR=groby@chromium.org,eae@chromium.org,tkent@chromium.org,xiaochengh@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 813009
Change-Id: Ibb2557436cdb5b07586bc69177f1456dc435568c
Reviewed-on: https://chromium-review.googlesource.com/994059Reviewed-by: default avatarXiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547905}
parent b98fc36f
......@@ -159,8 +159,7 @@ class InnerTextDumper final {
};
bool TextContentDumperIgnoresElement(const Element& element) {
return IsHTMLStyleElement(element) || IsHTMLScriptElement(element) ||
IsHTMLNoScriptElement(element);
return IsHTMLStyleElement(element) || IsHTMLScriptElement(element);
}
bool IsWhiteSpace(UChar ch) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment