Commit cd14955a authored by kdillon's avatar kdillon Committed by Commit Bot

[scheduler] Renaming kVeryHigh prioritisation type to kInternalScriptContinuation.

This name is more contextual, which matches the naming conventions of
the other prioritisation types and indicates what the prioritisation
type is used for.

Change-Id: I4a6bb87abafc5268a3031e9bb6ed258cd0b0e00a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399012
Commit-Queue: Katie Dillon <kdillon@chromium.org>
Reviewed-by: default avatarScott Haseley <shaseley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806036}
parent 0aaf1763
......@@ -440,7 +440,7 @@ QueueTraits FrameSchedulerImpl::CreateQueueTraitsForTaskType(TaskType type) {
QueueTraits::PrioritisationType::kHighPriorityLocalFrame);
case TaskType::kInternalContinueScriptLoading:
return PausableTaskQueueTraits().SetPrioritisationType(
QueueTraits::PrioritisationType::kVeryHigh);
QueueTraits::PrioritisationType::kInternalScriptContinuation);
case TaskType::kDatabaseAccess:
if (base::FeatureList::IsEnabled(kHighPriorityDatabaseTaskType)) {
return PausableTaskQueueTraits().SetPrioritisationType(
......
......@@ -240,7 +240,7 @@ class FrameSchedulerImplTest : public testing::Test {
// space delimited task identifiers. The first letter of each task identifier
// specifies the prioritisation type:
// - 'R': Regular (normal priority)
// - 'V': Very high
// - 'V': Internal Script Continuation (very high priority)
// - 'B': Best-effort
// - 'D': Database
void PostTestTasksForPrioritisationType(Vector<String>* run_order,
......@@ -255,7 +255,7 @@ class FrameSchedulerImplTest : public testing::Test {
prioritisation_type = PrioritisationType::kRegular;
break;
case 'V':
prioritisation_type = PrioritisationType::kVeryHigh;
prioritisation_type = PrioritisationType::kInternalScriptContinuation;
break;
case 'B':
prioritisation_type = PrioritisationType::kBestEffort;
......
......@@ -103,7 +103,7 @@ void FrameTaskQueueController::CreateTaskQueue(
.SetFrameScheduler(frame_scheduler_impl_);
switch (queue_traits.prioritisation_type) {
case QueueTraits::PrioritisationType::kVeryHigh:
case QueueTraits::PrioritisationType::kInternalScriptContinuation:
queue_creation_params = queue_creation_params.SetFixedPriority(
TaskQueue::QueuePriority::kVeryHighPriority);
break;
......
......@@ -324,7 +324,7 @@ INSTANTIATE_TEST_SUITE_P(
All,
TaskQueueCreationFromQueueTraitsTest,
::testing::Values(
QueueTraits::PrioritisationType::kVeryHigh,
QueueTraits::PrioritisationType::kInternalScriptContinuation,
QueueTraits::PrioritisationType::kBestEffort,
QueueTraits::PrioritisationType::kRegular,
QueueTraits::PrioritisationType::kLoading,
......
......@@ -111,7 +111,7 @@ class PLATFORM_EXPORT MainThreadTaskQueue
// Separate enum class for handling prioritisation decisions in task queues.
enum class PrioritisationType {
kVeryHigh = 0,
kInternalScriptContinuation = 0,
kBestEffort = 1,
kRegular = 2,
kLoading = 3,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment