Commit cd2509c5 authored by Daniel Hosseinian's avatar Daniel Hosseinian Committed by Commit Bot

Change |kSettingPreviewIsPDF| to |kSettingPreviewIsPdf|

Print preview UI expects the initial settings key to be in camelCase,
like |previewIsPdf|.

Bug: 989978
Change-Id: Ifcfee6f71e3dcdb4902054b7f9407c814898a481
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825897
Auto-Submit: Daniel Hosseinian <dhoss@chromium.org>
Reviewed-by: default avatarRebekah Potter <rbpotter@chromium.org>
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700001}
parent bb1a10b0
......@@ -40,7 +40,7 @@ base::Value GetPrintTicket(PrinterType type, bool cloud) {
ticket.SetBoolKey(kSettingShouldPrintBackgrounds, false);
ticket.SetBoolKey(kSettingShouldPrintSelectionOnly, false);
ticket.SetBoolKey(kSettingPreviewModifiable, true);
ticket.SetBoolKey(kSettingPreviewIsPDF, false);
ticket.SetBoolKey(kSettingPreviewIsPdf, false);
ticket.SetBoolKey(kSettingPrintToPDF, !cloud && type == kPdfPrinter);
ticket.SetBoolKey(kSettingCloudPrintDialog, cloud);
ticket.SetBoolKey(kSettingPrintWithPrivet, is_privet_printer);
......
......@@ -982,7 +982,7 @@ void PrintPreviewHandler::SendInitialSettings(
print_preview_ui()->initiator_title());
initial_settings.SetBoolKey(kSettingPreviewModifiable,
print_preview_ui()->source_is_modifiable());
initial_settings.SetBoolKey(kSettingPreviewIsPDF,
initial_settings.SetBoolKey(kSettingPreviewIsPdf,
print_preview_ui()->source_is_pdf());
initial_settings.SetStringKey(kSettingPrinterName, default_printer);
initial_settings.SetBoolKey(kDocumentHasSelection,
......
......@@ -98,7 +98,7 @@ base::Value GetPrintPreviewTicket() {
print_ticket.SetBoolKey(kIsFirstRequest, true);
print_ticket.SetIntKey(kPreviewRequestID, 0);
print_ticket.SetBoolKey(kSettingPreviewModifiable, false);
print_ticket.SetBoolKey(kSettingPreviewIsPDF, true);
print_ticket.SetBoolKey(kSettingPreviewIsPdf, true);
print_ticket.RemoveKey(kSettingPageWidth);
print_ticket.RemoveKey(kSettingPageHeight);
print_ticket.RemoveKey(kSettingShowSystemDialog);
......
......@@ -127,7 +127,7 @@ void CreatePrintSettingsDictionary(base::DictionaryValue* dict) {
dict->SetBoolean(kIsFirstRequest, true);
dict->SetInteger(kSettingMarginsType, DEFAULT_MARGINS);
dict->SetBoolean(kSettingPreviewModifiable, true);
dict->SetBoolean(kSettingPreviewIsPDF, false);
dict->SetBoolean(kSettingPreviewIsPdf, false);
dict->SetBoolean(kSettingHeaderFooterEnabled, false);
dict->SetBoolean(kSettingShouldPrintBackgrounds, false);
dict->SetBoolean(kSettingShouldPrintSelectionOnly, false);
......
......@@ -150,7 +150,7 @@ const char kSettingPinValue[] = "pinValue";
const char kSettingPolicies[] = "policies";
// Whether the source page content is PDF or not.
const char kSettingPreviewIsPDF[] = "previewIsPDF";
const char kSettingPreviewIsPdf[] = "previewIsPdf";
// Whether the source page content is modifiable. True for web content.
// i.e. Anything from Blink. False for everything else. e.g. PDF/Flash.
......
......@@ -56,7 +56,7 @@ PRINTING_EXPORT extern const char kSettingPageHeight[];
PRINTING_EXPORT extern const char kSettingPagesPerSheet[];
PRINTING_EXPORT extern const char kSettingPinValue[];
PRINTING_EXPORT extern const char kSettingPolicies[];
PRINTING_EXPORT extern const char kSettingPreviewIsPDF[];
PRINTING_EXPORT extern const char kSettingPreviewIsPdf[];
PRINTING_EXPORT extern const char kSettingPreviewModifiable[];
PRINTING_EXPORT extern const char kSettingPrintToGoogleDrive[];
PRINTING_EXPORT extern const char kSettingPrintToPDF[];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment