Commit cd34939b authored by Tanmoy Mollik's avatar Tanmoy Mollik Committed by Commit Bot

[Android] Remove unused string in PersonalizedSigninPromoView

This cl removes signin_promo_status_message string. This string was used
in personalized sync promos. But this string is now hidden and no longer
shown on the UI for sync promos.
It is replaced by sync_error_card_title that is used in SyncErrorCards.

Bug: 1124701
Change-Id: Id111d1df6fbee1b336b253867161cfb9b3c217fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391086Reviewed-by: default avatarMarc Treib <treib@chromium.org>
Reviewed-by: default avatarTheresa  <twellington@chromium.org>
Reviewed-by: default avatarAlice Wang <aliceywang@chromium.org>
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805778}
parent 78a9aa62
...@@ -16,7 +16,7 @@ ...@@ -16,7 +16,7 @@
android:layout_marginBottom="8dp" android:layout_marginBottom="8dp"
android:gravity="center" android:gravity="center"
android:textAppearance="@style/TextAppearance.TextMediumThick.Primary" android:textAppearance="@style/TextAppearance.TextMediumThick.Primary"
android:text="@string/signin_promo_status_message" android:text="@string/sync_error_card_title"
android:visibility="gone"/> android:visibility="gone"/>
<TextView <TextView
......
...@@ -127,7 +127,6 @@ public class SyncErrorCardPreference extends Preference ...@@ -127,7 +127,6 @@ public class SyncErrorCardPreference extends Preference
errorCardView.getDismissButton().setVisibility(View.GONE); errorCardView.getDismissButton().setVisibility(View.GONE);
errorCardView.getStatusMessage().setVisibility(View.VISIBLE); errorCardView.getStatusMessage().setVisibility(View.VISIBLE);
errorCardView.getStatusMessage().setText(R.string.sync_error_card_title);
errorCardView.getDescription().setText( errorCardView.getDescription().setText(
SyncSettingsUtils.getSyncErrorHint(getContext(), mSyncError)); SyncSettingsUtils.getSyncErrorHint(getContext(), mSyncError));
......
...@@ -2491,9 +2491,6 @@ To change this setting, <ph name="BEGIN_LINK">&lt;resetlink&gt;</ph>reset sync<p ...@@ -2491,9 +2491,6 @@ To change this setting, <ph name="BEGIN_LINK">&lt;resetlink&gt;</ph>reset sync<p
<message name="IDS_SIGNIN_PROMO_CHOOSE_ANOTHER_ACCOUNT" desc="Button that the user can press if they want to select a different account before signing in. This button is shown below 'Continue as Joe Doe' button that signs user in with default account."> <message name="IDS_SIGNIN_PROMO_CHOOSE_ANOTHER_ACCOUNT" desc="Button that the user can press if they want to select a different account before signing in. This button is shown below 'Continue as Joe Doe' button that signs user in with default account.">
Choose another account Choose another account
</message> </message>
<message name="IDS_SIGNIN_PROMO_STATUS_MESSAGE" desc="Title string for 'Turn on sync' sync promos.">
Sync is off
</message>
<message name="IDS_SYNC_PROMO_TURN_ON_SYNC" desc="Button that the user can press if they want to turn on sync with this account."> <message name="IDS_SYNC_PROMO_TURN_ON_SYNC" desc="Button that the user can press if they want to turn on sync with this account.">
Turn on sync Turn on sync
</message> </message>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment