[WebAuthn] Refactor layout tests to reduce code.

Instead of custom building each set of options per test,
deep copy the options and remove select properties. Both reduces
code and makes it more clear what is being tested.

Also adds a helper to set up a successful response from the
mock authenticator.

Bug: 664630
Change-Id: If5986e21b56e1093835866283f0e69134f265390
Reviewed-on: https://chromium-review.googlesource.com/957831Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542753}

third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-basics.html

@@ -115,16 +115,10 @@ promise_test(_ => {
 
 promise_test(_ => {
   mockAuthenticator.setRawId(RAW_ID);
-  mockAuthenticator.setId(ID);
-  mockAuthenticator.setClientDataJson(CLIENT_DATA_JSON);
-  mockAuthenticator.setAuthenticatorData(AUTHENTICATOR_DATA);
-  mockAuthenticator.setSignature(SIGNATURE);
-  mockAuthenticator.setAuthenticatorStatus(
-    webauth.mojom.AuthenticatorStatus.SUCCESS);
-
-    return navigator.credentials.get({publicKey : GET_CREDENTIAL_OPTIONS}).then(r => {
-        assertValidGetCredentialResponse(r);
-    });
+  mockAuthenticator.setDefaultsForSuccessfulGetAssertion();
+  return navigator.credentials.get({publicKey : GET_CREDENTIAL_OPTIONS}).then(r => {
+      assertValidGetCredentialResponse(r);
+  });
 }, "Verify that mockAuthenticator returns the values we give it.");
 
 promise_test(t => {
@@ -156,54 +150,28 @@ promise_test(t => {
 }, "Verify that not supported error returned by mock is properly handled.");
 
 promise_test(function(t) {
-    var customGetCredentialOptions = {
-        // No challenge.
-        rpId: "google.com",
-        allowCredentials: [ACCEPTABLE_CREDENTIAL],
-        userVerification: "preferred",
-    };
-
-    return promise_rejects(t, new TypeError(),
-            navigator.credentials.get({publicKey: customGetCredentialOptions}));
+  var customGetCredentialOptions = deepCopy(MAKE_CREDENTIAL_OPTIONS);
+  delete customGetCredentialOptions.challenge;
+  return promise_rejects(t, new TypeError(),
+      navigator.credentials.get({publicKey: customGetCredentialOptions}));
 }, "navigator.credentials.get() with missing challenge");
 
 promise_test(_ => {
   mockAuthenticator.reset();
-  mockAuthenticator.setRawId(RAW_ID);
-  mockAuthenticator.setId(ID);
-  mockAuthenticator.setClientDataJson(CLIENT_DATA_JSON);
-  mockAuthenticator.setAuthenticatorData(AUTHENTICATOR_DATA);
-  mockAuthenticator.setSignature(SIGNATURE);
-  mockAuthenticator.setAuthenticatorStatus(
-      webauth.mojom.AuthenticatorStatus.SUCCESS);
-
-  var customPublicKey = {
-      challenge: CHALLENGE,
-      allowCredentials: [ACCEPTABLE_CREDENTIAL],
-      userVerification: "preferred",
-  };
-
-  return navigator.credentials.get({publicKey: customPublicKey}).then(r => {
+  mockAuthenticator.setDefaultsForSuccessfulGetAssertion();
+  var customGetCredentialOptions = deepCopy(MAKE_CREDENTIAL_OPTIONS);
+  delete customGetCredentialOptions.rpId;
+  return navigator.credentials.get({publicKey: customGetCredentialOptions}).then(r => {
       assertValidGetCredentialResponse(r);
   });
 }, "navigator.credentials.get() with missing rpId");
 
 promise_test(_ => {
   mockAuthenticator.reset();
-  mockAuthenticator.setRawId(RAW_ID);
-  mockAuthenticator.setId(ID);
-  mockAuthenticator.setClientDataJson(CLIENT_DATA_JSON);
-  mockAuthenticator.setAuthenticatorData(AUTHENTICATOR_DATA);
-  mockAuthenticator.setSignature(SIGNATURE);
-  mockAuthenticator.setAuthenticatorStatus(
-      webauth.mojom.AuthenticatorStatus.SUCCESS);
-
-  var customPublicKey = {
-      challenge: CHALLENGE,
-      allowCredentials: [ACCEPTABLE_CREDENTIAL]
-  };
-
-  return navigator.credentials.get({publicKey: customPublicKey}).then(r => {
+  mockAuthenticator.setDefaultsForSuccessfulGetAssertion();
+  var customGetCredentialOptions = deepCopy(MAKE_CREDENTIAL_OPTIONS);
+  delete customGetCredentialOptions.userVerification;
+  return navigator.credentials.get({publicKey: customGetCredentialOptions}).then(r => {
       assertValidGetCredentialResponse(r);
   });
 }, "navigator.credentials.get() with missing user verification requirement");

third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/credential-helpers.js

@@ -138,6 +138,17 @@ class MockAuthenticator {
         webauth.mojom.AuthenticatorStatus.SUCCESS);
   }
 
+  // Sets everything needed for a GetAssertion success response.
+  setDefaultsForSuccessfulGetAssertion() {
+    mockAuthenticator.setRawId(RAW_ID);
+    mockAuthenticator.setId(ID);
+    mockAuthenticator.setClientDataJson(CLIENT_DATA_JSON);
+    mockAuthenticator.setAuthenticatorData(AUTHENTICATOR_DATA);
+    mockAuthenticator.setSignature(SIGNATURE);
+    mockAuthenticator.setAuthenticatorStatus(
+        webauth.mojom.AuthenticatorStatus.SUCCESS);
+  }
+
   setAuthenticatorStatus(status) {
     this.status_ = status;
   }
@@ -267,6 +278,16 @@ function EncloseInScriptTag(code) {
   return "<script>" + code + "</scr" + "ipt>";
 }
 
+function deepCopy(value) {
+  if ([Number, String, Uint8Array].includes(value.constructor))
+    return value;
+
+  let copy = (value.constructor == Array) ? [] : {};
+  for (let key of Object.keys(value))
+    copy[key] = deepCopy(value[key]);
+  return copy;
+}
+
 // Verifies if |r| is the valid response to credentials.create(publicKey).
 function assertValidMakeCredentialResponse(r) {
 assert_equals(r.id, ID, 'id');