Commit cd7b7fd2 authored by Greg Thompson's avatar Greg Thompson Committed by Chromium LUCI CQ

Retire ImportantFile.DeleteOnCloseError histogram.

It tells us that failures are due to I/O errors, access denied errors,
and other things we can't do anything about (likely odd drivers, too).

R=chromium-metrics-reviews@google.com, gab@chromium.org

Bug: 1156213
Change-Id: If4fb97d44d8b9a59db48239c68e69a56f59cd462
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609143
Commit-Queue: Greg Thompson <grt@chromium.org>
Auto-Submit: Greg Thompson <grt@chromium.org>
Reviewed-by: default avatarGabriel Charette <gab@chromium.org>
Reviewed-by: default avatarBrian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#841442}
parent 776d9209
...@@ -124,12 +124,9 @@ void DeleteTmpFileWithRetry(File tmp_file, ...@@ -124,12 +124,9 @@ void DeleteTmpFileWithRetry(File tmp_file,
if (tmp_file.IsValid()) { if (tmp_file.IsValid()) {
if (tmp_file.DeleteOnClose(true)) if (tmp_file.DeleteOnClose(true))
return; return;
// The file was opened with exclusive r/w access, so it would be very odd // The file was opened with exclusive r/w access, so failures are primarily
// for this to fail. // due to I/O errors or other phenomena out of the process's control. Go
UmaHistogramExactLinearWithSuffix( // ahead and close the file. The call to DeleteFile below will basically
"ImportantFile.DeleteOnCloseError", histogram_suffix,
-File::GetLastFileError(), -File::FILE_ERROR_MAX);
// Go ahead and close the file. The call to DeleteFile below will basically
// repeat the above, but maybe it will somehow succeed. // repeat the above, but maybe it will somehow succeed.
tmp_file.Close(); tmp_file.Close();
} }
......
...@@ -6793,7 +6793,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -6793,7 +6793,10 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</histogram> </histogram>
<histogram name="ImportantFile.DeleteOnCloseError" enum="PlatformFileError" <histogram name="ImportantFile.DeleteOnCloseError" enum="PlatformFileError"
expires_after="2021-01-19"> expires_after="M89">
<obsolete>
Removed in M89.
</obsolete>
<owner>grt@chromium.org</owner> <owner>grt@chromium.org</owner>
<owner>xaerox@yandex-team.ru</owner> <owner>xaerox@yandex-team.ru</owner>
<summary> <summary>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment