Commit cd964bbc authored by Robbie Gibson's avatar Robbie Gibson Committed by Commit Bot

[iOS] Add flag for Search for Copied Image feature

Bug: 913958
Change-Id: Ib942171d8f94e7b37cb91cdebe52c5e02141917e
Reviewed-on: https://chromium-review.googlesource.com/c/1371893
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Reviewed-by: default avatarMark Cogan <marq@chromium.org>
Reviewed-by: default avatarStepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615595}
parent 58e6d608
...@@ -494,6 +494,9 @@ const flags_ui::FeatureEntry kFeatureEntries[] = { ...@@ -494,6 +494,9 @@ const flags_ui::FeatureEntry kFeatureEntries[] = {
{"find-in-page-iframe", flag_descriptions::kFindInPageiFrameName, {"find-in-page-iframe", flag_descriptions::kFindInPageiFrameName,
flag_descriptions::kFindInPageiFrameDescription, flags_ui::kOsIos, flag_descriptions::kFindInPageiFrameDescription, flags_ui::kOsIos,
FEATURE_VALUE_TYPE(kFindInPageiFrame)}, FEATURE_VALUE_TYPE(kFindInPageiFrame)},
{"search-copied-image", flag_descriptions::kSearchCopiedImageName,
flag_descriptions::kSearchCopiedImageDescription, flags_ui::kOsIos,
FEATURE_VALUE_TYPE(kSearchCopiedImage)},
}; };
// Add all switches from experimental flags to |command_line|. // Add all switches from experimental flags to |command_line|.
......
...@@ -309,6 +309,11 @@ const char kIgnoresViewportScaleLimitsName[] = "Ignore Viewport Scale Limits"; ...@@ -309,6 +309,11 @@ const char kIgnoresViewportScaleLimitsName[] = "Ignore Viewport Scale Limits";
const char kIgnoresViewportScaleLimitsDescription[] = const char kIgnoresViewportScaleLimitsDescription[] =
"When enabled the page can always be scaled, regardless of author intent."; "When enabled the page can always be scaled, regardless of author intent.";
const char kSearchCopiedImageName[] = "Search copied image";
const char kSearchCopiedImageDescription[] =
"Enable searching from the toolbar search button for an image copied to "
"the system pasteboard.";
const char kSearchIconToggleName[] = "Change the icon for the search button"; const char kSearchIconToggleName[] = "Change the icon for the search button";
const char kSearchIconToggleDescription[] = const char kSearchIconToggleDescription[] =
"Different icons for the search button."; "Different icons for the search button.";
......
...@@ -249,6 +249,10 @@ extern const char kPhysicalWebDescription[]; ...@@ -249,6 +249,10 @@ extern const char kPhysicalWebDescription[];
extern const char kIgnoresViewportScaleLimitsName[]; extern const char kIgnoresViewportScaleLimitsName[];
extern const char kIgnoresViewportScaleLimitsDescription[]; extern const char kIgnoresViewportScaleLimitsDescription[];
// Title and description for the flag to enable searching for a copied image.
extern const char kSearchCopiedImageName[];
extern const char kSearchCopiedImageDescription[];
// Title and description for the flag to toggle the flag of the search button. // Title and description for the flag to toggle the flag of the search button.
extern const char kSearchIconToggleName[]; extern const char kSearchIconToggleName[];
extern const char kSearchIconToggleDescription[]; extern const char kSearchIconToggleDescription[];
......
...@@ -17,3 +17,6 @@ const base::Feature kOmniboxPopupShortcutIconsInZeroState{ ...@@ -17,3 +17,6 @@ const base::Feature kOmniboxPopupShortcutIconsInZeroState{
"OmniboxPopupShortcutIconsInZeroState", base::FEATURE_DISABLED_BY_DEFAULT}; "OmniboxPopupShortcutIconsInZeroState", base::FEATURE_DISABLED_BY_DEFAULT};
const base::Feature kWKWebViewSnapshots{"WKWebViewSnapshots", const base::Feature kWKWebViewSnapshots{"WKWebViewSnapshots",
base::FEATURE_ENABLED_BY_DEFAULT}; base::FEATURE_ENABLED_BY_DEFAULT};
const base::Feature kSearchCopiedImage{"SearchCopiedImage",
base::FEATURE_DISABLED_BY_DEFAULT};
...@@ -24,4 +24,7 @@ extern const base::Feature kOmniboxPopupShortcutIconsInZeroState; ...@@ -24,4 +24,7 @@ extern const base::Feature kOmniboxPopupShortcutIconsInZeroState;
// Used to enable using the WKWebView snapshotting API for iOS 11+. // Used to enable using the WKWebView snapshotting API for iOS 11+.
extern const base::Feature kWKWebViewSnapshots; extern const base::Feature kWKWebViewSnapshots;
// Feature to allow user to search for a copied image.
extern const base::Feature kSearchCopiedImage;
#endif // IOS_CHROME_BROWSER_UI_UI_FEATURE_FLAGS_H_ #endif // IOS_CHROME_BROWSER_UI_UI_FEATURE_FLAGS_H_
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment