Commit cd9d7826 authored by Eugene But's avatar Eugene But Committed by Commit Bot

Fix DownloadTaskImplTest for iOS 12.

iOS 12 calls private undocumented method from NSHTTPCookieStorage, which
needs to be stubbed in CRWFakeNSURLSessionTask in order to use fake task
with NSHTTPCookieStorage.

Bug: 851472
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I59b676090786a65e902ccd98a5fea85e2b191fed
Reviewed-on: https://chromium-review.googlesource.com/1097570Reviewed-by: default avatarJustin Cohen <justincohen@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566577}
parent 6fe7110a
...@@ -39,10 +39,14 @@ ...@@ -39,10 +39,14 @@
self.state = NSURLSessionTaskStateRunning; self.state = NSURLSessionTaskStateRunning;
} }
// A private method, called by -[NSHTTPCookieStorage storeCookies:forTask:]. // Below are private methods, called by
// Requires stubbing in order to use NSHTTPCookieStorage API. // -[NSHTTPCookieStorage storeCookies:forTask:]. Require stubbing in order to
// use NSHTTPCookieStorage API.
- (NSString*)_storagePartitionIdentifier { - (NSString*)_storagePartitionIdentifier {
return nil; return nil;
} }
- (NSURL*)_siteForCookies {
return nil;
}
@end @end
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment