Commit cda9aed0 authored by Mathias Bynens's avatar Mathias Bynens Committed by Commit Bot

Temporarily disable test for V8 roll

A V8 CL [1] improves the terminology that’s used for internal promise
state. Per the spec [2], a resolved promise may be “pending,
fulfilled, or rejected”, but previously V8 incorrectly used the term
“resolved” instead of “fulfilled”. This change is user-observable
through the `d8` REPL and the DevTools Console, and so this patch
updates the affected test’s expectations and temporarily disables it.

[1]: https://chromium-review.googlesource.com/c/v8/v8/+/2144011
[2]: https://tc39.es/ecma262/#sec-properties-of-promise-instances

Bug: v8:6751, v8:5416
Change-Id: I359560afab9155511aed762c864e80f33ac57262
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144095
Auto-Submit: Mathias Bynens <mathias@chromium.org>
Reviewed-by: default avatarPeter Marshall <petermarshall@chromium.org>
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757804}
parent 57010c99
......@@ -6568,6 +6568,9 @@ crbug.com/1025274 http/tests/security/mixedContent/insecure-audio-video-in-main-
crbug.com/1042877 virtual/autoupgrade-optionally-blockable-mixed-content/http/tests/mixed-autoupgrade/optionally/image-upgrade-console-message.https.html [ Failure ]
crbug.com/1042877 virtual/autoupgrade-optionally-blockable-mixed-content/http/tests/mixed-autoupgrade/optionally/image-upgrade.https.html [ Failure ]
# V8 roll
crbug.com/v8/6751 http/tests/devtools/console/console-format-es6.js [ Skip ]
# DevTools roll
crbug.com/1006759 http/tests/devtools/profiler/agents-disabled-check.js [ Skip ]
......
......@@ -4,10 +4,10 @@ console-format-es6.js:15 Promise {<rejected>: -0}
console-format-es6.js:16 [Promise]
globals[0]
Promise {<rejected>: -0}
console-format-es6.js:15 Promise {<resolved>: 1}
console-format-es6.js:15 Promise {<fulfilled>: 1}
console-format-es6.js:16 [Promise]
globals[1]
Promise {<resolved>: 1}
Promise {<fulfilled>: 1}
console-format-es6.js:15 Promise {<pending>}
console-format-es6.js:16 [Promise]
globals[2]
......@@ -78,18 +78,18 @@ Promise {<rejected>: -0}
__proto__: Promise
[[PromiseStatus]]: "rejected"
[[PromiseValue]]: -0
console-format-es6.js:15 Promise {<resolved>: 1}
console-format-es6.js:15 Promise {<fulfilled>: 1}
__proto__: Promise
[[PromiseStatus]]: "resolved"
[[PromiseStatus]]: "fulfilled"
[[PromiseValue]]: 1
console-format-es6.js:16 [Promise]
0: Promise {<resolved>: 1}
0: Promise {<fulfilled>: 1}
length: 1
__proto__: Array(0)
globals[1]
Promise {<resolved>: 1}
Promise {<fulfilled>: 1}
__proto__: Promise
[[PromiseStatus]]: "resolved"
[[PromiseStatus]]: "fulfilled"
[[PromiseValue]]: 1
console-format-es6.js:15 Promise {<pending>}
__proto__: Promise
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment