AudioNodeOutput::enable() and AudioNodeOutput::disable() should not be reentered
AudioNodeOutput::disable() can be reentered and causes the following crash. ASSERTION FAILED: m_outputs.contains(&output) ../../third_party/WebKit/Source/modules/webaudio/AudioNodeInput.cpp(98) : void blink::AudioNodeInput::disable(blink::AudioNodeOutput &) Received signal 11 SEGV_MAPERR 0000fbadbeef To avoid AudioNodeOutput::disable() from getting reentered, this CL moves the place of flipping m_isEnabled. The same issue is in AudioNodeOutput::enable() and this CL addresses the issue as well. BUG=411989 TEST=None, it's hard to create a simple test html that reproduces the bug. Review URL: https://codereview.chromium.org/558523002 git-svn-id: svn://svn.chromium.org/blink/trunk@181693 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Showing
Please register or sign in to comment