Commit cdcddc15 authored by Kyle Horimoto's avatar Kyle Horimoto Committed by Commit Bot

[CrOS PhoneHub] Fix Phone Hub multi-device setup settings

A previous CL [1] removed the "Phone Hub notification badge" feature,
but accidentally forgot to update the size of the kPhoneHubSubFeatures
array. This caused an issue which would accidentally read past the array
and cause incorrect FeatureStates to be provided.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2462225

Bug: 1106937
Change-Id: Iabe0d5adceb321f5998989e5ba4524b63f477476
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493220
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: default avatarRegan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819999}
parent 19c368f1
...@@ -26,7 +26,7 @@ namespace multidevice_setup { ...@@ -26,7 +26,7 @@ namespace multidevice_setup {
namespace { namespace {
constexpr std::array<mojom::Feature, 3> kPhoneHubSubFeatures{ constexpr std::array<mojom::Feature, 2> kPhoneHubSubFeatures{
mojom::Feature::kPhoneHubNotifications, mojom::Feature::kPhoneHubNotifications,
mojom::Feature::kPhoneHubTaskContinuation}; mojom::Feature::kPhoneHubTaskContinuation};
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment