Commit cde0f142 authored by Avi Drissman's avatar Avi Drissman Committed by Commit Bot

Fix macOS 11.0 switching

@available works now for macOS 11.0; use it.

Fixed: 1105187, 1115294
Change-Id: Icecd3b71b913e474629aa2e9c8be4936954e9689
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545080
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Auto-Submit: Avi Drissman <avi@chromium.org>
Reviewed-by: default avatarDominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829137}
parent c2c167d4
...@@ -7,7 +7,6 @@ ...@@ -7,7 +7,6 @@
#include "third_party/blink/renderer/platform/fonts/mac/font_matcher_mac.h" #include "third_party/blink/renderer/platform/fonts/mac/font_matcher_mac.h"
#include "base/mac/foundation_util.h" #include "base/mac/foundation_util.h"
#include "base/mac/mac_util.h"
#include "testing/gtest/include/gtest/gtest.h" #include "testing/gtest/include/gtest/gtest.h"
#include "third_party/blink/renderer/platform/font_family_names.h" #include "third_party/blink/renderer/platform/font_family_names.h"
...@@ -33,9 +32,7 @@ TEST(FontPlatformDataMacTest, VariableOpticalSizingThreshold) { ...@@ -33,9 +32,7 @@ TEST(FontPlatformDataMacTest, VariableOpticalSizingThreshold) {
// Below the 11.0 axis minimum. // Below the 11.0 axis minimum.
sk_sp<SkTypeface> system_font(MakeSystemFontOfSize(12)); sk_sp<SkTypeface> system_font(MakeSystemFontOfSize(12));
// TODO(https://crbug.com/1115294, https://crbug.com/1105187): Switch back to if (@available(macOS 11.0, *)) {
// @available when it works.
if (base::mac::IsOS11()) {
EXPECT_FALSE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 6)); EXPECT_FALSE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 6));
EXPECT_FALSE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 12)); EXPECT_FALSE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 12));
EXPECT_FALSE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 17)); EXPECT_FALSE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 17));
...@@ -48,7 +45,7 @@ TEST(FontPlatformDataMacTest, VariableOpticalSizingThreshold) { ...@@ -48,7 +45,7 @@ TEST(FontPlatformDataMacTest, VariableOpticalSizingThreshold) {
EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 72)); EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 72));
EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 96)); EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 96));
EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 97)); EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 97));
} else if (base::mac::IsOS10_15()) { } else if (@available(macOS 10.15, *)) {
EXPECT_FALSE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 6)); EXPECT_FALSE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 6));
EXPECT_FALSE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 12)); EXPECT_FALSE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 12));
EXPECT_FALSE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 17)); EXPECT_FALSE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 17));
...@@ -78,7 +75,7 @@ TEST(FontPlatformDataMacTest, VariableOpticalSizingThreshold) { ...@@ -78,7 +75,7 @@ TEST(FontPlatformDataMacTest, VariableOpticalSizingThreshold) {
// Just smaller than the switch-over size in 10.15, which is 19.9. // Just smaller than the switch-over size in 10.15, which is 19.9.
system_font = MakeSystemFontOfSize(19); system_font = MakeSystemFontOfSize(19);
if (base::mac::IsOS11()) { if (@available(macOS 11.0, *)) {
EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 6)); EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 6));
EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 12)); EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 12));
EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 17)); EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 17));
...@@ -91,7 +88,7 @@ TEST(FontPlatformDataMacTest, VariableOpticalSizingThreshold) { ...@@ -91,7 +88,7 @@ TEST(FontPlatformDataMacTest, VariableOpticalSizingThreshold) {
EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 72)); EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 72));
EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 96)); EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 96));
EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 97)); EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 97));
} else if (base::mac::IsOS10_15()) { } else if (@available(macOS 10.15, *)) {
EXPECT_FALSE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 6)); EXPECT_FALSE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 6));
EXPECT_FALSE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 12)); EXPECT_FALSE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 12));
EXPECT_FALSE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 17)); EXPECT_FALSE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 17));
...@@ -121,7 +118,7 @@ TEST(FontPlatformDataMacTest, VariableOpticalSizingThreshold) { ...@@ -121,7 +118,7 @@ TEST(FontPlatformDataMacTest, VariableOpticalSizingThreshold) {
// Just larger than the switch-over size in 10.15, which is 19.9. // Just larger than the switch-over size in 10.15, which is 19.9.
system_font = MakeSystemFontOfSize(20); system_font = MakeSystemFontOfSize(20);
if (base::mac::IsOS11()) { if (@available(macOS 11.0, *)) {
EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 6)); EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 6));
EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 12)); EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 12));
EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 17)); EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 17));
...@@ -134,7 +131,7 @@ TEST(FontPlatformDataMacTest, VariableOpticalSizingThreshold) { ...@@ -134,7 +131,7 @@ TEST(FontPlatformDataMacTest, VariableOpticalSizingThreshold) {
EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 72)); EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 72));
EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 96)); EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 96));
EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 97)); EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 97));
} else if (base::mac::IsOS10_15()) { } else if (@available(macOS 10.15, *)) {
EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 6)); EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 6));
EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 12)); EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 12));
EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 17)); EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 17));
...@@ -164,7 +161,7 @@ TEST(FontPlatformDataMacTest, VariableOpticalSizingThreshold) { ...@@ -164,7 +161,7 @@ TEST(FontPlatformDataMacTest, VariableOpticalSizingThreshold) {
// Above the 11.0 axis maximum. // Above the 11.0 axis maximum.
system_font = MakeSystemFontOfSize(128); system_font = MakeSystemFontOfSize(128);
if (base::mac::IsOS11()) { if (@available(macOS 11.0, *)) {
EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 6)); EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 6));
EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 12)); EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 12));
EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 17)); EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 17));
...@@ -177,7 +174,7 @@ TEST(FontPlatformDataMacTest, VariableOpticalSizingThreshold) { ...@@ -177,7 +174,7 @@ TEST(FontPlatformDataMacTest, VariableOpticalSizingThreshold) {
EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 72)); EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 72));
EXPECT_FALSE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 96)); EXPECT_FALSE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 96));
EXPECT_FALSE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 97)); EXPECT_FALSE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 97));
} else if (base::mac::IsOS10_15()) { } else if (@available(macOS 10.15, *)) {
EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 6)); EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 6));
EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 12)); EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 12));
EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 17)); EXPECT_TRUE(VariableAxisChangeEffective(system_font.get(), kOpszTag, 17));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment