Commit cde2e3c7 authored by Emily Stark's avatar Emily Stark Committed by Commit Bot

Exempt SSL_CONNECTION_VERSION_UNKNOWN from legacy TLS warning treatment

Signed Exchanges do not have a SSL connection version set. Exclude
such cases from the legacy TLS warning treatment to avoid spurious
warnings.

Bug: 1041773
Change-Id: I323e3c1206da32b629c82b4eb28fc0a67190e7cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002830
Commit-Queue: Emily Stark <estark@chromium.org>
Reviewed-by: default avatarDavid Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732076}
parent 02f59e84
...@@ -110,7 +110,10 @@ bool IsLegacyTLS(GURL url, int connection_status) { ...@@ -110,7 +110,10 @@ bool IsLegacyTLS(GURL url, int connection_status) {
net::SSLVersion ssl_version = net::SSLVersion ssl_version =
net::SSLConnectionStatusToVersion(connection_status); net::SSLConnectionStatusToVersion(connection_status);
return ssl_version < ssl_version_min; // Signed Exchanges do not have connection status set. Exclude unknown TLS
// versions from legacy TLS treatment. See https://crbug.com/1041773.
return ssl_version != net::SSL_CONNECTION_VERSION_UNKNOWN &&
ssl_version < ssl_version_min;
} }
} // namespace } // namespace
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment