Commit cdf03dfb authored by avi@chromium.org's avatar avi@chromium.org

Add OVERRIDE to media/.

BUG=104314
TEST=no change

Review URL: http://codereview.chromium.org/8520033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110304 0039d316-1c4b-4281-b951-d872f2087c98
parent f3f8ffb3
...@@ -118,9 +118,9 @@ class MEDIA_EXPORT AudioInputController ...@@ -118,9 +118,9 @@ class MEDIA_EXPORT AudioInputController
/////////////////////////////////////////////////////////////////////////// ///////////////////////////////////////////////////////////////////////////
// AudioInputCallback methods. // AudioInputCallback methods.
virtual void OnData(AudioInputStream* stream, const uint8* src, uint32 size, virtual void OnData(AudioInputStream* stream, const uint8* src, uint32 size,
uint32 hardware_delay_bytes); uint32 hardware_delay_bytes) OVERRIDE;
virtual void OnClose(AudioInputStream* stream); virtual void OnClose(AudioInputStream* stream) OVERRIDE;
virtual void OnError(AudioInputStream* stream, int code); virtual void OnError(AudioInputStream* stream, int code) OVERRIDE;
protected: protected:
// Internal state of the source. // Internal state of the source.
......
...@@ -26,12 +26,12 @@ class MEDIA_EXPORT AudioOutputProxy : public AudioOutputStream { ...@@ -26,12 +26,12 @@ class MEDIA_EXPORT AudioOutputProxy : public AudioOutputStream {
AudioOutputProxy(AudioOutputDispatcher* dispatcher); AudioOutputProxy(AudioOutputDispatcher* dispatcher);
// AudioOutputStream interface. // AudioOutputStream interface.
virtual bool Open(); virtual bool Open() OVERRIDE;
virtual void Start(AudioSourceCallback* callback); virtual void Start(AudioSourceCallback* callback) OVERRIDE;
virtual void Stop(); virtual void Stop() OVERRIDE;
virtual void SetVolume(double volume); virtual void SetVolume(double volume) OVERRIDE;
virtual void GetVolume(double* volume); virtual void GetVolume(double* volume) OVERRIDE;
virtual void Close(); virtual void Close() OVERRIDE;
private: private:
// Needs to access destructor. // Needs to access destructor.
......
...@@ -22,10 +22,10 @@ class FakeAudioInputStream ...@@ -22,10 +22,10 @@ class FakeAudioInputStream
public: public:
static AudioInputStream* MakeFakeStream(const AudioParameters& params); static AudioInputStream* MakeFakeStream(const AudioParameters& params);
virtual bool Open(); virtual bool Open() OVERRIDE;
virtual void Start(AudioInputCallback* callback); virtual void Start(AudioInputCallback* callback) OVERRIDE;
virtual void Stop(); virtual void Stop() OVERRIDE;
virtual void Close(); virtual void Close() OVERRIDE;
private: private:
// Give RefCountedThreadSafe access our destructor. // Give RefCountedThreadSafe access our destructor.
......
...@@ -20,12 +20,12 @@ class MEDIA_EXPORT FakeAudioOutputStream : public AudioOutputStream { ...@@ -20,12 +20,12 @@ class MEDIA_EXPORT FakeAudioOutputStream : public AudioOutputStream {
static AudioOutputStream* MakeFakeStream(const AudioParameters& params); static AudioOutputStream* MakeFakeStream(const AudioParameters& params);
static FakeAudioOutputStream* GetLastFakeStream(); static FakeAudioOutputStream* GetLastFakeStream();
virtual bool Open(); virtual bool Open() OVERRIDE;
virtual void Start(AudioSourceCallback* callback); virtual void Start(AudioSourceCallback* callback) OVERRIDE;
virtual void Stop(); virtual void Stop() OVERRIDE;
virtual void SetVolume(double volume); virtual void SetVolume(double volume) OVERRIDE;
virtual void GetVolume(double* volume); virtual void GetVolume(double* volume) OVERRIDE;
virtual void Close(); virtual void Close() OVERRIDE;
uint8* buffer() { return buffer_.get(); } uint8* buffer() { return buffer_.get(); }
double volume() { return volume_; } double volume() { return volume_; }
......
...@@ -39,12 +39,12 @@ class AUAudioOutputStream : public AudioOutputStream { ...@@ -39,12 +39,12 @@ class AUAudioOutputStream : public AudioOutputStream {
virtual ~AUAudioOutputStream(); virtual ~AUAudioOutputStream();
// Implementation of AudioOutputStream. // Implementation of AudioOutputStream.
virtual bool Open(); virtual bool Open() OVERRIDE;
virtual void Close(); virtual void Close() OVERRIDE;
virtual void Start(AudioSourceCallback* callback); virtual void Start(AudioSourceCallback* callback) OVERRIDE;
virtual void Stop(); virtual void Stop() OVERRIDE;
virtual void SetVolume(double volume); virtual void SetVolume(double volume) OVERRIDE;
virtual void GetVolume(double* volume); virtual void GetVolume(double* volume) OVERRIDE;
static double HardwareSampleRate(); static double HardwareSampleRate();
......
...@@ -9,6 +9,7 @@ ...@@ -9,6 +9,7 @@
#include <AudioToolbox/AudioQueue.h> #include <AudioToolbox/AudioQueue.h>
#include <AudioUnit/AudioUnit.h> #include <AudioUnit/AudioUnit.h>
#include "base/compiler_specific.h"
#include "base/synchronization/lock.h" #include "base/synchronization/lock.h"
#include "media/audio/audio_io.h" #include "media/audio/audio_io.h"
#include "media/audio/audio_parameters.h" #include "media/audio/audio_parameters.h"
...@@ -29,12 +30,12 @@ class PCMQueueOutAudioOutputStream : public AudioOutputStream { ...@@ -29,12 +30,12 @@ class PCMQueueOutAudioOutputStream : public AudioOutputStream {
virtual ~PCMQueueOutAudioOutputStream(); virtual ~PCMQueueOutAudioOutputStream();
// Implementation of AudioOutputStream. // Implementation of AudioOutputStream.
virtual bool Open(); virtual bool Open() OVERRIDE;
virtual void Close(); virtual void Close() OVERRIDE;
virtual void Start(AudioSourceCallback* callback); virtual void Start(AudioSourceCallback* callback) OVERRIDE;
virtual void Stop(); virtual void Stop() OVERRIDE;
virtual void SetVolume(double volume); virtual void SetVolume(double volume) OVERRIDE;
virtual void GetVolume(double* volume); virtual void GetVolume(double* volume) OVERRIDE;
private: private:
// The audio is double buffered. // The audio is double buffered.
......
...@@ -28,8 +28,8 @@ class MEDIA_EXPORT SineWaveAudioSource ...@@ -28,8 +28,8 @@ class MEDIA_EXPORT SineWaveAudioSource
// Implementation of AudioSourceCallback. // Implementation of AudioSourceCallback.
virtual uint32 OnMoreData( virtual uint32 OnMoreData(
AudioOutputStream* stream, uint8* dest, uint32 max_size, AudioOutputStream* stream, uint8* dest, uint32 max_size,
AudioBuffersState audio_buffers); AudioBuffersState audio_buffers) OVERRIDE;
virtual void OnError(AudioOutputStream* stream, int code); virtual void OnError(AudioOutputStream* stream, int code) OVERRIDE;
protected: protected:
Format format_; Format format_;
...@@ -65,15 +65,17 @@ class MEDIA_EXPORT PushSource ...@@ -65,15 +65,17 @@ class MEDIA_EXPORT PushSource
virtual ~PushSource(); virtual ~PushSource();
// Write one buffer. // Write one buffer.
virtual bool Write(const void* data, uint32 len); virtual bool Write(const void* data, uint32 len) OVERRIDE;
// Return the total number of bytes not given to the audio device yet. // Return the total number of bytes not given to the audio device yet.
virtual uint32 UnProcessedBytes(); virtual uint32 UnProcessedBytes() OVERRIDE;
// Implementation of AudioSourceCallback. // Implementation of AudioSourceCallback.
virtual uint32 OnMoreData(AudioOutputStream* stream, uint8* dest, virtual uint32 OnMoreData(AudioOutputStream* stream,
uint32 max_size, AudioBuffersState buffers_state); uint8* dest,
virtual void OnError(AudioOutputStream* stream, int code); uint32 max_size,
AudioBuffersState buffers_state) OVERRIDE;
virtual void OnError(AudioOutputStream* stream, int code) OVERRIDE;
// Discard all buffered data and reset to initial state. // Discard all buffered data and reset to initial state.
void ClearAll(); void ClearAll();
......
...@@ -54,8 +54,8 @@ class TestAudioInputController : public AudioInputController { ...@@ -54,8 +54,8 @@ class TestAudioInputController : public AudioInputController {
// Overriden to do nothing. It is assumed the caller will notify the event // Overriden to do nothing. It is assumed the caller will notify the event
// handler with recorded data and other events. // handler with recorded data and other events.
virtual void Record() {} virtual void Record() OVERRIDE {}
virtual void Close() {} virtual void Close() OVERRIDE {}
private: private:
// These are not owned by us and expected to be valid for this object's // These are not owned by us and expected to be valid for this object's
...@@ -75,7 +75,7 @@ class TestAudioInputControllerFactory : public AudioInputController::Factory { ...@@ -75,7 +75,7 @@ class TestAudioInputControllerFactory : public AudioInputController::Factory {
// AudioInputController::Factory methods. // AudioInputController::Factory methods.
virtual AudioInputController* Create( virtual AudioInputController* Create(
AudioInputController::EventHandler* event_handler, AudioInputController::EventHandler* event_handler,
AudioParameters params); AudioParameters params) OVERRIDE;
TestAudioInputController* controller() const { return controller_; } TestAudioInputController* controller() const { return controller_; }
......
...@@ -54,7 +54,8 @@ class MEDIA_EXPORT AsyncDataSourceFactoryBase : public DataSourceFactory { ...@@ -54,7 +54,8 @@ class MEDIA_EXPORT AsyncDataSourceFactoryBase : public DataSourceFactory {
// DataSourceFactory method. // DataSourceFactory method.
// Derived classes should not overload this Build() method. AllowRequests() & // Derived classes should not overload this Build() method. AllowRequests() &
// CreateRequest() should be implemented instead. // CreateRequest() should be implemented instead.
virtual void Build(const std::string& url, const BuildCallback& callback); virtual void Build(const std::string& url,
const BuildCallback& callback) OVERRIDE;
// DataSourceFactory method. // DataSourceFactory method.
// Clone() must be implemented by derived classes. // Clone() must be implemented by derived classes.
......
...@@ -87,7 +87,7 @@ class MEDIA_EXPORT Buffer : public StreamSample { ...@@ -87,7 +87,7 @@ class MEDIA_EXPORT Buffer : public StreamSample {
virtual size_t GetDataSize() const = 0; virtual size_t GetDataSize() const = 0;
// If there's no data in this buffer, it represents end of stream. // If there's no data in this buffer, it represents end of stream.
virtual bool IsEndOfStream() const; virtual bool IsEndOfStream() const OVERRIDE;
protected: protected:
virtual ~Buffer() {} virtual ~Buffer() {}
......
...@@ -23,13 +23,13 @@ class MEDIA_EXPORT CompositeDataSourceFactory ...@@ -23,13 +23,13 @@ class MEDIA_EXPORT CompositeDataSourceFactory
void AddFactory(DataSourceFactory* factory); void AddFactory(DataSourceFactory* factory);
// DataSourceFactory method. // DataSourceFactory method.
virtual DataSourceFactory* Clone() const; virtual DataSourceFactory* Clone() const OVERRIDE;
protected: protected:
// AsyncDataSourceFactoryBase methods. // AsyncDataSourceFactoryBase methods.
virtual bool AllowRequests() const; virtual bool AllowRequests() const OVERRIDE;
virtual AsyncDataSourceFactoryBase::BuildRequest* CreateRequest( virtual AsyncDataSourceFactoryBase::BuildRequest* CreateRequest(
const std::string& url, const BuildCallback& callback); const std::string& url, const BuildCallback& callback) OVERRIDE;
private: private:
class BuildRequest; class BuildRequest;
......
...@@ -26,8 +26,8 @@ class MEDIA_EXPORT DataBuffer : public Buffer { ...@@ -26,8 +26,8 @@ class MEDIA_EXPORT DataBuffer : public Buffer {
explicit DataBuffer(size_t buffer_size); explicit DataBuffer(size_t buffer_size);
// Buffer implementation. // Buffer implementation.
virtual const uint8* GetData() const; virtual const uint8* GetData() const OVERRIDE;
virtual size_t GetDataSize() const; virtual size_t GetDataSize() const OVERRIDE;
// Returns a read-write pointer to the buffer data. // Returns a read-write pointer to the buffer data.
virtual uint8* GetWritableData(); virtual uint8* GetWritableData();
......
...@@ -18,9 +18,9 @@ class MEDIA_EXPORT MessageLoopFactoryImpl : public MessageLoopFactory { ...@@ -18,9 +18,9 @@ class MEDIA_EXPORT MessageLoopFactoryImpl : public MessageLoopFactory {
MessageLoopFactoryImpl(); MessageLoopFactoryImpl();
// MessageLoopFactory methods. // MessageLoopFactory methods.
virtual MessageLoop* GetMessageLoop(const std::string& name); virtual MessageLoop* GetMessageLoop(const std::string& name) OVERRIDE;
virtual scoped_refptr<base::MessageLoopProxy> GetMessageLoopProxy( virtual scoped_refptr<base::MessageLoopProxy> GetMessageLoopProxy(
const std::string& name); const std::string& name) OVERRIDE;
protected: protected:
virtual ~MessageLoopFactoryImpl(); virtual ~MessageLoopFactoryImpl();
......
...@@ -79,7 +79,7 @@ class MEDIA_EXPORT VideoFrame : public StreamSample { ...@@ -79,7 +79,7 @@ class MEDIA_EXPORT VideoFrame : public StreamSample {
uint8* data(size_t plane) const; uint8* data(size_t plane) const;
// StreamSample interface. // StreamSample interface.
virtual bool IsEndOfStream() const; virtual bool IsEndOfStream() const OVERRIDE;
protected: protected:
// Clients must use the static CreateFrame() method to create a new frame. // Clients must use the static CreateFrame() method to create a new frame.
......
// Copyright (c) 2010 The Chromium Authors. All rights reserved. // Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
...@@ -20,7 +20,7 @@ class AudioRendererAlgorithmDefault : public AudioRendererAlgorithmBase { ...@@ -20,7 +20,7 @@ class AudioRendererAlgorithmDefault : public AudioRendererAlgorithmBase {
virtual ~AudioRendererAlgorithmDefault(); virtual ~AudioRendererAlgorithmDefault();
// AudioRendererAlgorithmBase implementation // AudioRendererAlgorithmBase implementation
virtual uint32 FillBuffer(uint8* dest, uint32 length); virtual uint32 FillBuffer(uint8* dest, uint32 length) OVERRIDE;
private: private:
DISALLOW_COPY_AND_ASSIGN(AudioRendererAlgorithmDefault); DISALLOW_COPY_AND_ASSIGN(AudioRendererAlgorithmDefault);
......
...@@ -26,9 +26,9 @@ class MEDIA_EXPORT AudioRendererAlgorithmOLA ...@@ -26,9 +26,9 @@ class MEDIA_EXPORT AudioRendererAlgorithmOLA
virtual ~AudioRendererAlgorithmOLA(); virtual ~AudioRendererAlgorithmOLA();
// AudioRendererAlgorithmBase implementation // AudioRendererAlgorithmBase implementation
virtual uint32 FillBuffer(uint8* dest, uint32 length); virtual uint32 FillBuffer(uint8* dest, uint32 length) OVERRIDE;
virtual void set_playback_rate(float new_rate); virtual void set_playback_rate(float new_rate) OVERRIDE;
private: private:
FRIEND_TEST_ALL_PREFIXES(AudioRendererAlgorithmOLATest, FRIEND_TEST_ALL_PREFIXES(AudioRendererAlgorithmOLATest,
......
...@@ -88,7 +88,7 @@ class MEDIA_EXPORT AudioRendererBase : public AudioRenderer { ...@@ -88,7 +88,7 @@ class MEDIA_EXPORT AudioRendererBase : public AudioRenderer {
bool buffers_empty); bool buffers_empty);
// Get/Set the playback rate of |algorithm_|. // Get/Set the playback rate of |algorithm_|.
virtual void SetPlaybackRate(float playback_rate); virtual void SetPlaybackRate(float playback_rate) OVERRIDE;
virtual float GetPlaybackRate(); virtual float GetPlaybackRate();
private: private:
......
...@@ -13,6 +13,7 @@ ...@@ -13,6 +13,7 @@
#include <string> #include <string>
#include "base/basictypes.h" #include "base/basictypes.h"
#include "base/compiler_specific.h"
#include "base/gtest_prod_util.h" #include "base/gtest_prod_util.h"
#include "media/base/media_export.h" #include "media/base/media_export.h"
...@@ -47,8 +48,8 @@ class IdentityBitstreamConverter : public BitstreamConverter { ...@@ -47,8 +48,8 @@ class IdentityBitstreamConverter : public BitstreamConverter {
IdentityBitstreamConverter() {} IdentityBitstreamConverter() {}
virtual ~IdentityBitstreamConverter() {} virtual ~IdentityBitstreamConverter() {}
virtual bool Initialize(); virtual bool Initialize() OVERRIDE;
virtual bool ConvertPacket(AVPacket* packet); virtual bool ConvertPacket(AVPacket* packet) OVERRIDE;
private: private:
DISALLOW_COPY_AND_ASSIGN(IdentityBitstreamConverter); DISALLOW_COPY_AND_ASSIGN(IdentityBitstreamConverter);
...@@ -66,8 +67,8 @@ class MEDIA_EXPORT FFmpegBitstreamConverter : public BitstreamConverter { ...@@ -66,8 +67,8 @@ class MEDIA_EXPORT FFmpegBitstreamConverter : public BitstreamConverter {
AVCodecContext* stream_context); AVCodecContext* stream_context);
virtual ~FFmpegBitstreamConverter(); virtual ~FFmpegBitstreamConverter();
virtual bool Initialize(); virtual bool Initialize() OVERRIDE;
virtual bool ConvertPacket(AVPacket* packet); virtual bool ConvertPacket(AVPacket* packet) OVERRIDE;
private: private:
std::string filter_name_; std::string filter_name_;
......
...@@ -34,7 +34,8 @@ class MEDIA_EXPORT ChunkDemuxer : public Demuxer { ...@@ -34,7 +34,8 @@ class MEDIA_EXPORT ChunkDemuxer : public Demuxer {
virtual void Stop(const base::Closure& callback) OVERRIDE; virtual void Stop(const base::Closure& callback) OVERRIDE;
virtual void Seek(base::TimeDelta time, const PipelineStatusCB& cb) OVERRIDE; virtual void Seek(base::TimeDelta time, const PipelineStatusCB& cb) OVERRIDE;
virtual void OnAudioRendererDisabled() OVERRIDE; virtual void OnAudioRendererDisabled() OVERRIDE;
virtual scoped_refptr<DemuxerStream> GetStream(DemuxerStream::Type type); virtual scoped_refptr<DemuxerStream> GetStream(
DemuxerStream::Type type) OVERRIDE;
virtual void SetPreload(Preload preload) OVERRIDE; virtual void SetPreload(Preload preload) OVERRIDE;
virtual base::TimeDelta GetStartTime() const OVERRIDE; virtual base::TimeDelta GetStartTime() const OVERRIDE;
......
...@@ -28,8 +28,8 @@ class MEDIA_EXPORT ChunkDemuxerFactory : public DemuxerFactory { ...@@ -28,8 +28,8 @@ class MEDIA_EXPORT ChunkDemuxerFactory : public DemuxerFactory {
virtual ~ChunkDemuxerFactory(); virtual ~ChunkDemuxerFactory();
// DemuxerFactory methods. // DemuxerFactory methods.
virtual void Build(const std::string& url, const BuildCallback& cb); virtual void Build(const std::string& url, const BuildCallback& cb) OVERRIDE;
virtual DemuxerFactory* Clone() const; virtual DemuxerFactory* Clone() const OVERRIDE;
private: private:
std::string url_; std::string url_;
......
...@@ -44,8 +44,8 @@ class MEDIA_EXPORT FFmpegH264BitstreamConverter : public BitstreamConverter { ...@@ -44,8 +44,8 @@ class MEDIA_EXPORT FFmpegH264BitstreamConverter : public BitstreamConverter {
virtual ~FFmpegH264BitstreamConverter(); virtual ~FFmpegH264BitstreamConverter();
// BitstreamConverter implementation // BitstreamConverter implementation
virtual bool Initialize(); virtual bool Initialize() OVERRIDE;
virtual bool ConvertPacket(AVPacket* packet); virtual bool ConvertPacket(AVPacket* packet) OVERRIDE;
private: private:
// Actual converter class. // Actual converter class.
......
...@@ -24,16 +24,16 @@ class MEDIA_EXPORT FileDataSource : public DataSource { ...@@ -24,16 +24,16 @@ class MEDIA_EXPORT FileDataSource : public DataSource {
PipelineStatus Initialize(const std::string& url); PipelineStatus Initialize(const std::string& url);
// Implementation of Filter. // Implementation of Filter.
virtual void set_host(FilterHost* filter_host); virtual void set_host(FilterHost* filter_host) OVERRIDE;
virtual void Stop(const base::Closure& callback); virtual void Stop(const base::Closure& callback) OVERRIDE;
// Implementation of DataSource. // Implementation of DataSource.
virtual void Read(int64 position, size_t size, uint8* data, virtual void Read(int64 position, size_t size, uint8* data,
const DataSource::ReadCallback& read_callback); const DataSource::ReadCallback& read_callback) OVERRIDE;
virtual bool GetSize(int64* size_out); virtual bool GetSize(int64* size_out) OVERRIDE;
virtual bool IsStreaming(); virtual bool IsStreaming() OVERRIDE;
virtual void SetPreload(Preload preload); virtual void SetPreload(Preload preload) OVERRIDE;
virtual void SetBitrate(int bitrate); virtual void SetBitrate(int bitrate) OVERRIDE;
private: private:
// Only allow factories and tests to create this object. // Only allow factories and tests to create this object.
......
...@@ -15,8 +15,9 @@ class MEDIA_EXPORT FileDataSourceFactory : public DataSourceFactory { ...@@ -15,8 +15,9 @@ class MEDIA_EXPORT FileDataSourceFactory : public DataSourceFactory {
virtual ~FileDataSourceFactory(); virtual ~FileDataSourceFactory();
// DataSourceFactory methods. // DataSourceFactory methods.
virtual void Build(const std::string& url, const BuildCallback& callback); virtual void Build(const std::string& url,
virtual DataSourceFactory* Clone() const; const BuildCallback& callback) OVERRIDE;
virtual DataSourceFactory* Clone() const OVERRIDE;
private: private:
DISALLOW_COPY_AND_ASSIGN(FileDataSourceFactory); DISALLOW_COPY_AND_ASSIGN(FileDataSourceFactory);
......
...@@ -21,11 +21,11 @@ class MEDIA_EXPORT InMemoryUrlProtocol : public FFmpegURLProtocol { ...@@ -21,11 +21,11 @@ class MEDIA_EXPORT InMemoryUrlProtocol : public FFmpegURLProtocol {
virtual ~InMemoryUrlProtocol(); virtual ~InMemoryUrlProtocol();
// FFmpegURLProtocol methods. // FFmpegURLProtocol methods.
virtual size_t Read(size_t size, uint8* data); virtual size_t Read(size_t size, uint8* data) OVERRIDE;
virtual bool GetPosition(int64* position_out); virtual bool GetPosition(int64* position_out) OVERRIDE;
virtual bool SetPosition(int64 position); virtual bool SetPosition(int64 position) OVERRIDE;
virtual bool GetSize(int64* size_out); virtual bool GetSize(int64* size_out) OVERRIDE;
virtual bool IsStreaming(); virtual bool IsStreaming() OVERRIDE;
private: private:
const uint8* data_; const uint8* data_;
......
...@@ -31,17 +31,17 @@ class MEDIA_EXPORT NullAudioRenderer ...@@ -31,17 +31,17 @@ class MEDIA_EXPORT NullAudioRenderer
virtual ~NullAudioRenderer(); virtual ~NullAudioRenderer();
// AudioRenderer implementation. // AudioRenderer implementation.
virtual void SetVolume(float volume); virtual void SetVolume(float volume) OVERRIDE;
// PlatformThread::Delegate implementation. // PlatformThread::Delegate implementation.
virtual void ThreadMain(); virtual void ThreadMain() OVERRIDE;
protected: protected:
// AudioRendererBase implementation. // AudioRendererBase implementation.
virtual bool OnInitialize(int bits_per_channel, virtual bool OnInitialize(int bits_per_channel,
ChannelLayout channel_layout, ChannelLayout channel_layout,
int sample_rate); int sample_rate) OVERRIDE;
virtual void OnStop(); virtual void OnStop() OVERRIDE;
private: private:
// A number to convert bytes written in FillBuffer to milliseconds based on // A number to convert bytes written in FillBuffer to milliseconds based on
......
...@@ -14,9 +14,9 @@ class NullVideoRenderer : public VideoRendererBase { ...@@ -14,9 +14,9 @@ class NullVideoRenderer : public VideoRendererBase {
NullVideoRenderer(); NullVideoRenderer();
// VideoRendererBase implementation. // VideoRendererBase implementation.
virtual bool OnInitialize(VideoDecoder* decoder); virtual bool OnInitialize(VideoDecoder* decoder) OVERRIDE;
virtual void OnStop(const base::Closure& callback); virtual void OnStop(const base::Closure& callback) OVERRIDE;
virtual void OnFrameAvailable(); virtual void OnFrameAvailable() OVERRIDE;
private: private:
// Only allow to be deleted by reference counting. // Only allow to be deleted by reference counting.
......
...@@ -31,23 +31,24 @@ class MEDIA_EXPORT ReferenceAudioRenderer ...@@ -31,23 +31,24 @@ class MEDIA_EXPORT ReferenceAudioRenderer
virtual ~ReferenceAudioRenderer(); virtual ~ReferenceAudioRenderer();
// Filter implementation. // Filter implementation.
virtual void SetPlaybackRate(float playback_rate); virtual void SetPlaybackRate(float playback_rate) OVERRIDE;
// AudioRenderer implementation. // AudioRenderer implementation.
virtual void SetVolume(float volume); virtual void SetVolume(float volume) OVERRIDE;
// AudioSourceCallback implementation. // AudioSourceCallback implementation.
virtual uint32 OnMoreData(AudioOutputStream* stream, uint8* dest, virtual uint32 OnMoreData(AudioOutputStream* stream, uint8* dest,
uint32 len, AudioBuffersState buffers_state); uint32 len,
AudioBuffersState buffers_state) OVERRIDE;
virtual void OnClose(AudioOutputStream* stream); virtual void OnClose(AudioOutputStream* stream);
virtual void OnError(AudioOutputStream* stream, int code); virtual void OnError(AudioOutputStream* stream, int code) OVERRIDE;
protected: protected:
// AudioRendererBase implementation. // AudioRendererBase implementation.
virtual bool OnInitialize(int bits_per_channel, virtual bool OnInitialize(int bits_per_channel,
ChannelLayout channel_layout, ChannelLayout channel_layout,
int sample_rate); int sample_rate) OVERRIDE;
virtual void OnStop(); virtual void OnStop() OVERRIDE;
private: private:
// Audio output stream device. // Audio output stream device.
......
...@@ -37,21 +37,21 @@ class MEDIA_EXPORT VideoRendererBase ...@@ -37,21 +37,21 @@ class MEDIA_EXPORT VideoRendererBase
virtual ~VideoRendererBase(); virtual ~VideoRendererBase();
// Filter implementation. // Filter implementation.
virtual void Play(const base::Closure& callback); virtual void Play(const base::Closure& callback) OVERRIDE;
virtual void Pause(const base::Closure& callback); virtual void Pause(const base::Closure& callback) OVERRIDE;
virtual void Flush(const base::Closure& callback); virtual void Flush(const base::Closure& callback) OVERRIDE;
virtual void Stop(const base::Closure& callback); virtual void Stop(const base::Closure& callback) OVERRIDE;
virtual void SetPlaybackRate(float playback_rate); virtual void SetPlaybackRate(float playback_rate) OVERRIDE;
virtual void Seek(base::TimeDelta time, const FilterStatusCB& cb); virtual void Seek(base::TimeDelta time, const FilterStatusCB& cb) OVERRIDE;
// VideoRenderer implementation. // VideoRenderer implementation.
virtual void Initialize(VideoDecoder* decoder, virtual void Initialize(VideoDecoder* decoder,
const base::Closure& callback, const base::Closure& callback,
const StatisticsCallback& stats_callback); const StatisticsCallback& stats_callback) OVERRIDE;
virtual bool HasEnded(); virtual bool HasEnded() OVERRIDE;
// PlatformThread::Delegate implementation. // PlatformThread::Delegate implementation.
virtual void ThreadMain(); virtual void ThreadMain() OVERRIDE;
// Clients of this class (painter/compositor) should use GetCurrentFrame() // Clients of this class (painter/compositor) should use GetCurrentFrame()
// obtain ownership of VideoFrame, it should always relinquish the ownership // obtain ownership of VideoFrame, it should always relinquish the ownership
......
...@@ -27,11 +27,11 @@ class MEDIA_EXPORT FakeVideoCaptureDevice : public VideoCaptureDevice { ...@@ -27,11 +27,11 @@ class MEDIA_EXPORT FakeVideoCaptureDevice : public VideoCaptureDevice {
virtual void Allocate(int width, virtual void Allocate(int width,
int height, int height,
int frame_rate, int frame_rate,
VideoCaptureDevice::EventHandler* observer); VideoCaptureDevice::EventHandler* observer) OVERRIDE;
virtual void Start(); virtual void Start() OVERRIDE;
virtual void Stop(); virtual void Stop() OVERRIDE;
virtual void DeAllocate(); virtual void DeAllocate() OVERRIDE;
virtual const Name& device_name(); virtual const Name& device_name() OVERRIDE;
private: private:
// Flag indicating the internal state. // Flag indicating the internal state.
......
...@@ -26,11 +26,11 @@ class VideoCaptureDeviceLinux : public VideoCaptureDevice { ...@@ -26,11 +26,11 @@ class VideoCaptureDeviceLinux : public VideoCaptureDevice {
virtual void Allocate(int width, virtual void Allocate(int width,
int height, int height,
int frame_rate, int frame_rate,
EventHandler* observer); EventHandler* observer) OVERRIDE;
virtual void Start(); virtual void Start() OVERRIDE;
virtual void Stop(); virtual void Stop() OVERRIDE;
virtual void DeAllocate(); virtual void DeAllocate() OVERRIDE;
virtual const Name& device_name(); virtual const Name& device_name() OVERRIDE;
private: private:
enum InternalState { enum InternalState {
......
...@@ -40,11 +40,11 @@ class VideoCaptureDeviceWin ...@@ -40,11 +40,11 @@ class VideoCaptureDeviceWin
virtual void Allocate(int width, virtual void Allocate(int width,
int height, int height,
int frame_rate, int frame_rate,
VideoCaptureDevice::EventHandler* observer); VideoCaptureDevice::EventHandler* observer) OVERRIDE;
virtual void Start(); virtual void Start() OVERRIDE;
virtual void Stop(); virtual void Stop() OVERRIDE;
virtual void DeAllocate(); virtual void DeAllocate() OVERRIDE;
virtual const Name& device_name(); virtual const Name& device_name() OVERRIDE;
private: private:
enum InternalState { enum InternalState {
......
...@@ -37,14 +37,14 @@ class WebMClusterParser : public WebMParserClient { ...@@ -37,14 +37,14 @@ class WebMClusterParser : public WebMParserClient {
private: private:
// WebMParserClient methods. // WebMParserClient methods.
virtual bool OnListStart(int id); virtual bool OnListStart(int id) OVERRIDE;
virtual bool OnListEnd(int id); virtual bool OnListEnd(int id) OVERRIDE;
virtual bool OnUInt(int id, int64 val); virtual bool OnUInt(int id, int64 val) OVERRIDE;
virtual bool OnFloat(int id, double val); virtual bool OnFloat(int id, double val) OVERRIDE;
virtual bool OnBinary(int id, const uint8* data, int size); virtual bool OnBinary(int id, const uint8* data, int size) OVERRIDE;
virtual bool OnString(int id, const std::string& str); virtual bool OnString(int id, const std::string& str) OVERRIDE;
virtual bool OnSimpleBlock(int track_num, int timecode, int flags, virtual bool OnSimpleBlock(int track_num, int timecode, int flags,
const uint8* data, int size); const uint8* data, int size) OVERRIDE;
double timecode_multiplier_; // Multiplier used to convert timecodes into double timecode_multiplier_; // Multiplier used to convert timecodes into
// microseconds. // microseconds.
......
...@@ -5,6 +5,7 @@ ...@@ -5,6 +5,7 @@
#ifndef MEDIA_WEBM_WEBM_INFO_PARSER_H_ #ifndef MEDIA_WEBM_WEBM_INFO_PARSER_H_
#define MEDIA_WEBM_WEBM_INFO_PARSER_H_ #define MEDIA_WEBM_WEBM_INFO_PARSER_H_
#include "base/compiler_specific.h"
#include "media/webm/webm_parser.h" #include "media/webm/webm_parser.h"
namespace media { namespace media {
...@@ -27,14 +28,14 @@ class WebMInfoParser : public WebMParserClient { ...@@ -27,14 +28,14 @@ class WebMInfoParser : public WebMParserClient {
private: private:
// WebMParserClient methods // WebMParserClient methods
virtual bool OnListStart(int id); virtual bool OnListStart(int id) OVERRIDE;
virtual bool OnListEnd(int id); virtual bool OnListEnd(int id) OVERRIDE;
virtual bool OnUInt(int id, int64 val); virtual bool OnUInt(int id, int64 val) OVERRIDE;
virtual bool OnFloat(int id, double val); virtual bool OnFloat(int id, double val) OVERRIDE;
virtual bool OnBinary(int id, const uint8* data, int size); virtual bool OnBinary(int id, const uint8* data, int size) OVERRIDE;
virtual bool OnString(int id, const std::string& str); virtual bool OnString(int id, const std::string& str) OVERRIDE;
virtual bool OnSimpleBlock(int track_num, int timecode, int flags, virtual bool OnSimpleBlock(int track_num, int timecode, int flags,
const uint8* data, int size); const uint8* data, int size) OVERRIDE;
int64 timecode_scale_; int64 timecode_scale_;
double duration_; double duration_;
......
...@@ -5,9 +5,9 @@ ...@@ -5,9 +5,9 @@
#ifndef MEDIA_WEBM_WEBM_TRACKS_PARSER_H_ #ifndef MEDIA_WEBM_WEBM_TRACKS_PARSER_H_
#define MEDIA_WEBM_WEBM_TRACKS_PARSER_H_ #define MEDIA_WEBM_WEBM_TRACKS_PARSER_H_
#include "media/webm/webm_parser.h" #include "base/compiler_specific.h"
#include "base/time.h" #include "base/time.h"
#include "media/webm/webm_parser.h"
namespace media { namespace media {
...@@ -36,14 +36,14 @@ class WebMTracksParser : public WebMParserClient { ...@@ -36,14 +36,14 @@ class WebMTracksParser : public WebMParserClient {
private: private:
// WebMParserClient methods // WebMParserClient methods
virtual bool OnListStart(int id); virtual bool OnListStart(int id) OVERRIDE;
virtual bool OnListEnd(int id); virtual bool OnListEnd(int id) OVERRIDE;
virtual bool OnUInt(int id, int64 val); virtual bool OnUInt(int id, int64 val) OVERRIDE;
virtual bool OnFloat(int id, double val); virtual bool OnFloat(int id, double val) OVERRIDE;
virtual bool OnBinary(int id, const uint8* data, int size); virtual bool OnBinary(int id, const uint8* data, int size) OVERRIDE;
virtual bool OnString(int id, const std::string& str); virtual bool OnString(int id, const std::string& str) OVERRIDE;
virtual bool OnSimpleBlock(int track_num, int timecode, int flags, virtual bool OnSimpleBlock(int track_num, int timecode, int flags,
const uint8* data, int size); const uint8* data, int size) OVERRIDE;
int64 timecode_scale_; int64 timecode_scale_;
int64 track_type_; int64 track_type_;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment