Skip to content

GitLab

T
tangled
Commit ce1a9526 authored by littledan's avatar littledan Committed by Commit bot
Browse files
Options

New test expectations for async function callstack tests 

Async/await functions are getting better stack traces from the V8
patch at https://codereview.chromium.org/2357423002/ . This patch
checks in new test expectations and marks the tests as
NeedsManualRebaseline until the V8 patch is checked in and the roll
occurs.

BUG=v8:4483,chromium:646199

Review-Url: https://codereview.chromium.org/2362923002
Cr-Commit-Position: refs/heads/master@{#420778}
parent d9001a3e
Hide whitespace changes
Inline Side-by-side
Showing with 62 additions and 109 deletions
third_party/WebKit/LayoutTests/TestExpectations
View file @ ce1a9526
...@@ -582,6 +582,8 @@ crbug.com/621515 inspector/sources/debugger-async/async-await/async-callstack-as ...@@ -582,6 +582,8 @@ crbug.com/621515 inspector/sources/debugger-async/async-await/async-callstack-as
crbug.com/621515 inspector/sources/debugger-async/async-await/async-callstack-async-await3.html [ Skip ] crbug.com/621515 inspector/sources/debugger-async/async-await/async-callstack-async-await3.html [ Skip ]
# Stack traces for async functions are improving as the desugaring changes # Stack traces for async functions are improving as the desugaring changes
crbug.com/646199 virtual/asyncawait/inspector/sources/debugger-async/async-await/async-callstack-async-await1.html [ NeedsManualRebaseline ]
crbug.com/646199 virtual/asyncawait/inspector/sources/debugger-async/async-await/async-callstack-async-await2.html [ NeedsManualRebaseline ]
crbug.com/646199 virtual/asyncawait/inspector/sources/debugger-async/async-await/async-callstack-async-await3.html [ NeedsManualRebaseline ] crbug.com/646199 virtual/asyncawait/inspector/sources/debugger-async/async-await/async-callstack-async-await3.html [ NeedsManualRebaseline ]
# These tests pass but images do not match because of position: absolute in vertical flow bug # These tests pass but images do not match because of position: absolute in vertical flow bug
......
third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-await/async-callstack-async-await1-expected.txt
View file @ ce1a9526
...@@ -5,8 +5,8 @@ Captured call stacks in no particular order: ...@@ -5,8 +5,8 @@ Captured call stacks in no particular order:
Call stack: Call stack:
0) errorCallback (async-callstack-async-await1.html:60) 0) errorCallback (async-callstack-async-await1.html:60)
1) doTestSettledPromisesRejected (async-callstack-async-await1.html:92) 1) doTestSettledPromisesRejected (async-callstack-async-await1.html:92)
[Promise.reject] [async function]
0) doTestSettledPromisesRejected (async-callstack-async-await1.html:89) 0) doTestSettledPromisesRejected (async-callstack-async-await1.html:86)
1) testFunctionTimeout (async-callstack-async-await1.html:50) 1) testFunctionTimeout (async-callstack-async-await1.html:50)
[setTimeout] [setTimeout]
0) testFunction (async-callstack-async-await1.html:43) 0) testFunction (async-callstack-async-await1.html:43)
...@@ -27,8 +27,8 @@ Call stack: ...@@ -27,8 +27,8 @@ Call stack:
Call stack: Call stack:
0) thenCallback (async-callstack-async-await1.html:55) 0) thenCallback (async-callstack-async-await1.html:55)
1) doTestPromiseConstructor (async-callstack-async-await1.html:70) 1) doTestPromiseConstructor (async-callstack-async-await1.html:70)
[Promise.resolve] [async function]
0) doTestPromiseConstructor (async-callstack-async-await1.html:66) 0) doTestPromiseConstructor (async-callstack-async-await1.html:63)
1) testFunctionTimeout (async-callstack-async-await1.html:50) 1) testFunctionTimeout (async-callstack-async-await1.html:50)
[setTimeout] [setTimeout]
0) testFunction (async-callstack-async-await1.html:43) 0) testFunction (async-callstack-async-await1.html:43)
...@@ -39,8 +39,8 @@ Call stack: ...@@ -39,8 +39,8 @@ Call stack:
Call stack: Call stack:
0) thenCallback (async-callstack-async-await1.html:55) 0) thenCallback (async-callstack-async-await1.html:55)
1) doTestSettledPromisesResolved (async-callstack-async-await1.html:80) 1) doTestSettledPromisesResolved (async-callstack-async-await1.html:80)
[Promise.resolve] [async function]
0) doTestSettledPromisesResolved (async-callstack-async-await1.html:79) 0) doTestSettledPromisesResolved (async-callstack-async-await1.html:76)
1) testFunctionTimeout (async-callstack-async-await1.html:50) 1) testFunctionTimeout (async-callstack-async-await1.html:50)
[setTimeout] [setTimeout]
0) testFunction (async-callstack-async-await1.html:43) 0) testFunction (async-callstack-async-await1.html:43)
......
third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-await/async-callstack-async-await2-expected.txt
View file @ ce1a9526
...@@ -4,13 +4,9 @@ Set timer for test function. ...@@ -4,13 +4,9 @@ Set timer for test function.
Captured call stacks in no particular order: Captured call stacks in no particular order:
Call stack: Call stack:
0) doTestChainedPromises (async-callstack-async-await2.html:67) 0) doTestChainedPromises (async-callstack-async-await2.html:67)
[Promise.resolve] [async function]
0) resolvePromise (async-callstack-async-await2.html:12) 0) doTestChainedPromises (async-callstack-async-await2.html:63)
[setTimeout] 1) testFunctionTimeout (async-callstack-async-await2.html:50)
0) promiseCallback (async-callstack-async-await2.html:21)
1) timeoutPromise (async-callstack-async-await2.html:9)
2) doTestChainedPromises (async-callstack-async-await2.html:66)
3) testFunctionTimeout (async-callstack-async-await2.html:50)
[setTimeout] [setTimeout]
0) testFunction (async-callstack-async-await2.html:43) 0) testFunction (async-callstack-async-await2.html:43)
[setTimeout] [setTimeout]
...@@ -19,86 +15,59 @@ Call stack: ...@@ -19,86 +15,59 @@ Call stack:
Call stack: Call stack:
0) doTestChainedPromises (async-callstack-async-await2.html:69) 0) doTestChainedPromises (async-callstack-async-await2.html:69)
[Promise.resolve] [async function]
0) resolvePromise (async-callstack-async-await2.html:12) 0) doTestChainedPromises (async-callstack-async-await2.html:63)
[setTimeout] 1) testFunctionTimeout (async-callstack-async-await2.html:50)
0) promiseCallback (async-callstack-async-await2.html:21)
1) timeoutPromise (async-callstack-async-await2.html:9)
2) doTestChainedPromises (async-callstack-async-await2.html:68)
[Promise.resolve]
0) resolvePromise (async-callstack-async-await2.html:12)
[setTimeout]
0) promiseCallback (async-callstack-async-await2.html:21)
1) timeoutPromise (async-callstack-async-await2.html:9)
2) doTestChainedPromises (async-callstack-async-await2.html:66)
3) testFunctionTimeout (async-callstack-async-await2.html:50)
[setTimeout] [setTimeout]
0) testFunction (async-callstack-async-await2.html:43) 0) testFunction (async-callstack-async-await2.html:43)
[setTimeout]
0) scheduleTestFunction (debugger-test.js:3)
<... skipped remaining frames ...>
Call stack: Call stack:
0) doTestChainedPromises (async-callstack-async-await2.html:71) 0) doTestChainedPromises (async-callstack-async-await2.html:71)
[Promise.resolve] [async function]
0) doTestChainedPromises (async-callstack-async-await2.html:70) 0) doTestChainedPromises (async-callstack-async-await2.html:63)
[Promise.resolve] 1) testFunctionTimeout (async-callstack-async-await2.html:50)
0) resolvePromise (async-callstack-async-await2.html:12)
[setTimeout] [setTimeout]
0) promiseCallback (async-callstack-async-await2.html:21) 0) testFunction (async-callstack-async-await2.html:43)
1) timeoutPromise (async-callstack-async-await2.html:9)
2) doTestChainedPromises (async-callstack-async-await2.html:68)
[Promise.resolve]
0) resolvePromise (async-callstack-async-await2.html:12)
[setTimeout] [setTimeout]
0) promiseCallback (async-callstack-async-await2.html:21) 0) scheduleTestFunction (debugger-test.js:3)
1) timeoutPromise (async-callstack-async-await2.html:9) <... skipped remaining frames ...>
2) doTestChainedPromises (async-callstack-async-await2.html:66)
3) testFunctionTimeout (async-callstack-async-await2.html:50)
Call stack: Call stack:
0) doTestChainedPromises (async-callstack-async-await2.html:73) 0) doTestChainedPromises (async-callstack-async-await2.html:73)
[Promise.resolve] [async function]
0) doTestChainedPromises (async-callstack-async-await2.html:72) 0) doTestChainedPromises (async-callstack-async-await2.html:63)
[Promise.resolve] 1) testFunctionTimeout (async-callstack-async-await2.html:50)
0) doTestChainedPromises (async-callstack-async-await2.html:70) [setTimeout]
[Promise.resolve] 0) testFunction (async-callstack-async-await2.html:43)
0) resolvePromise (async-callstack-async-await2.html:12)
[setTimeout] [setTimeout]
0) promiseCallback (async-callstack-async-await2.html:21) 0) scheduleTestFunction (debugger-test.js:3)
1) timeoutPromise (async-callstack-async-await2.html:9) <... skipped remaining frames ...>
2) doTestChainedPromises (async-callstack-async-await2.html:68)
[Promise.resolve]
0) resolvePromise (async-callstack-async-await2.html:12)
Call stack: Call stack:
0) thenCallback (async-callstack-async-await2.html:55) 0) thenCallback (async-callstack-async-await2.html:55)
1) doTestChainedPromises (async-callstack-async-await2.html:74) 1) doTestChainedPromises (async-callstack-async-await2.html:74)
[Promise.resolve] [async function]
0) resolvePromise (async-callstack-async-await2.html:12) 0) doTestChainedPromises (async-callstack-async-await2.html:63)
1) testFunctionTimeout (async-callstack-async-await2.html:50)
[setTimeout] [setTimeout]
0) promiseCallback (async-callstack-async-await2.html:21) 0) testFunction (async-callstack-async-await2.html:43)
1) timeoutPromise (async-callstack-async-await2.html:9) [setTimeout]
2) doTestChainedPromises (async-callstack-async-await2.html:74) 0) scheduleTestFunction (debugger-test.js:3)
[Promise.resolve] <... skipped remaining frames ...>
0) doTestChainedPromises (async-callstack-async-await2.html:72)
[Promise.resolve]
0) doTestChainedPromises (async-callstack-async-await2.html:70)
[Promise.resolve]
0) resolvePromise (async-callstack-async-await2.html:12)
Call stack: Call stack:
0) thenCallback (async-callstack-async-await2.html:55) 0) thenCallback (async-callstack-async-await2.html:55)
1) doTestChainedPromisesJSON (async-callstack-async-await2.html:86) 1) doTestChainedPromisesJSON (async-callstack-async-await2.html:86)
[Promise.resolve] [async function]
0) doTestChainedPromisesJSON (async-callstack-async-await2.html:85) 0) doTestChainedPromisesJSON (async-callstack-async-await2.html:80)
[Promise.resolve] 1) testFunctionTimeout (async-callstack-async-await2.html:50)
0) doTestChainedPromisesJSON (async-callstack-async-await2.html:84)
[Promise.resolve]
0) resolvePromise (async-callstack-async-await2.html:12)
[setTimeout]
0) promiseCallback (async-callstack-async-await2.html:21)
1) timeoutPromise (async-callstack-async-await2.html:9)
2) doTestChainedPromisesJSON (async-callstack-async-await2.html:83)
3) testFunctionTimeout (async-callstack-async-await2.html:50)
[setTimeout] [setTimeout]
0) testFunction (async-callstack-async-await2.html:43) 0) testFunction (async-callstack-async-await2.html:43)
[setTimeout]
0) scheduleTestFunction (debugger-test.js:3)
<... skipped remaining frames ...>
third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-await/async-callstack-async-await3-expected.txt
View file @ ce1a9526
...@@ -5,8 +5,8 @@ Captured call stacks in no particular order: ...@@ -5,8 +5,8 @@ Captured call stacks in no particular order:
Call stack: Call stack:
0) errorCallback (async-callstack-async-await3.html:60) 0) errorCallback (async-callstack-async-await3.html:60)
1) doTestPromiseReject (async-callstack-async-await3.html:129) 1) doTestPromiseReject (async-callstack-async-await3.html:129)
[Promise.reject] [async function]
0) doTestPromiseReject (async-callstack-async-await3.html:126) 0) doTestPromiseReject (async-callstack-async-await3.html:123)
1) testFunctionTimeout (async-callstack-async-await3.html:50) 1) testFunctionTimeout (async-callstack-async-await3.html:50)
[setTimeout] [setTimeout]
0) testFunction (async-callstack-async-await3.html:43) 0) testFunction (async-callstack-async-await3.html:43)
...@@ -17,51 +17,33 @@ Call stack: ...@@ -17,51 +17,33 @@ Call stack:
Call stack: Call stack:
0) errorCallback (async-callstack-async-await3.html:60) 0) errorCallback (async-callstack-async-await3.html:60)
1) doTestRejectFromChain (async-callstack-async-await3.html:109) 1) doTestRejectFromChain (async-callstack-async-await3.html:109)
[Promise.reject] [async function]
0) rejectPromise (async-callstack-async-await3.html:16) 0) doTestRejectFromChain (async-callstack-async-await3.html:103)
1) testFunctionTimeout (async-callstack-async-await3.html:50)
[setTimeout] [setTimeout]
0) promiseCallback (async-callstack-async-await3.html:19) 0) testFunction (async-callstack-async-await3.html:43)
1) timeoutPromise (async-callstack-async-await3.html:9)
2) rejectFromChain (async-callstack-async-await3.html:98)
[Promise.resolve]
0) resolvePromise (async-callstack-async-await3.html:12)
[setTimeout] [setTimeout]
0) promiseCallback (async-callstack-async-await3.html:21) 0) scheduleTestFunction (debugger-test.js:3)
1) timeoutPromise (async-callstack-async-await3.html:9) <... skipped remaining frames ...>
2) rejectFromChain (async-callstack-async-await3.html:97)
[Promise.resolve]
0) resolvePromise (async-callstack-async-await3.html:12)
Call stack: Call stack:
0) errorCallback (async-callstack-async-await3.html:60) 0) errorCallback (async-callstack-async-await3.html:60)
1) doTestThrowFromChain (async-callstack-async-await3.html:89) 1) doTestThrowFromChain (async-callstack-async-await3.html:89)
[Promise.resolve] [async function]
0) resolvePromise (async-callstack-async-await3.html:12) 0) doTestThrowFromChain (async-callstack-async-await3.html:83)
[setTimeout] 1) testFunctionTimeout (async-callstack-async-await3.html:50)
0) promiseCallback (async-callstack-async-await3.html:21)
1) timeoutPromise (async-callstack-async-await3.html:9)
2) throwFromChain (async-callstack-async-await3.html:76)
[Promise.resolve]
0) resolvePromise (async-callstack-async-await3.html:12)
[setTimeout]
0) promiseCallback (async-callstack-async-await3.html:21)
1) timeoutPromise (async-callstack-async-await3.html:9)
2) throwFromChain (async-callstack-async-await3.html:75)
3) doTestThrowFromChain (async-callstack-async-await3.html:86)
4) testFunctionTimeout (async-callstack-async-await3.html:50)
[setTimeout] [setTimeout]
0) testFunction (async-callstack-async-await3.html:43) 0) testFunction (async-callstack-async-await3.html:43)
[setTimeout]
0) scheduleTestFunction (debugger-test.js:3)
<... skipped remaining frames ...>
Call stack: Call stack:
0) thenCallback (async-callstack-async-await3.html:55) 0) thenCallback (async-callstack-async-await3.html:55)
1) doTestPromiseAll (async-callstack-async-await3.html:67) 1) doTestPromiseAll (async-callstack-async-await3.html:67)
[Promise.resolve] [async function]
0) resolvePromise (async-callstack-async-await3.html:12) 0) doTestPromiseAll (async-callstack-async-await3.html:63)
[setTimeout] 1) testFunctionTimeout (async-callstack-async-await3.html:50)
0) promiseCallback (async-callstack-async-await3.html:21)
1) timeoutPromise (async-callstack-async-await3.html:9)
2) doTestPromiseAll (async-callstack-async-await3.html:66)
3) testFunctionTimeout (async-callstack-async-await3.html:50)
[setTimeout] [setTimeout]
0) testFunction (async-callstack-async-await3.html:43) 0) testFunction (async-callstack-async-await3.html:43)
[setTimeout] [setTimeout]
...@@ -71,8 +53,8 @@ Call stack: ...@@ -71,8 +53,8 @@ Call stack:
Call stack: Call stack:
0) thenCallback (async-callstack-async-await3.html:55) 0) thenCallback (async-callstack-async-await3.html:55)
1) doTestPromiseResolve (async-callstack-async-await3.html:117) 1) doTestPromiseResolve (async-callstack-async-await3.html:117)
[Promise.resolve] [async function]
0) doTestPromiseResolve (async-callstack-async-await3.html:116) 0) doTestPromiseResolve (async-callstack-async-await3.html:113)
1) testFunctionTimeout (async-callstack-async-await3.html:50) 1) testFunctionTimeout (async-callstack-async-await3.html:50)
[setTimeout] [setTimeout]
0) testFunction (async-callstack-async-await3.html:43) 0) testFunction (async-callstack-async-await3.html:43)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment