Commit ce6b4f9e authored by Bence Béky's avatar Bence Béky Committed by Commit Bot

Remove obsolete flags from quic_flags_list.h

Remove two obsolete flags: FLAGS_quic_bbr_rtt_variation_weight and
FLAGS_quic_ietf_draft_version.

Every remaining flag is a reloadable flag or a restart flag, all
Boolean.  Remove type argument.

Change-Id: I0b9d6db33b82968c05aa8025d86921f1df7a29b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502751Reviewed-by: default avatarDavid Schinazi <dschinazi@chromium.org>
Reviewed-by: default avatarVictor Vasiliev <vasilvv@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821330}
parent 46d03267
...@@ -21,7 +21,7 @@ ...@@ -21,7 +21,7 @@
#include "build/build_config.h" #include "build/build_config.h"
#include "net/third_party/quiche/src/quic/platform/api/quic_logging.h" #include "net/third_party/quiche/src/quic/platform/api/quic_logging.h"
#define QUIC_FLAG(type, flag, value) type flag = value; #define QUIC_FLAG(flag, value) bool flag = value;
#include "net/quic/quic_flags_list.h" #include "net/quic/quic_flags_list.h"
#undef QUIC_FLAG #undef QUIC_FLAG
...@@ -304,10 +304,10 @@ void SetQuicFlagByName_int64_t(int64_t* flag, const std::string& value) { ...@@ -304,10 +304,10 @@ void SetQuicFlagByName_int64_t(int64_t* flag, const std::string& value) {
} // namespace } // namespace
void SetQuicFlagByName(const std::string& flag_name, const std::string& value) { void SetQuicFlagByName(const std::string& flag_name, const std::string& value) {
#define QUIC_FLAG(type, flag, default_value) \ #define QUIC_FLAG(flag, default_value) \
if (flag_name == #flag) { \ if (flag_name == #flag) { \
SetQuicFlagByName_##type(&flag, value); \ SetQuicFlagByName_bool(&flag, value); \
return; \ return; \
} }
#include "net/quic/quic_flags_list.h" #include "net/quic/quic_flags_list.h"
#undef QUIC_FLAG #undef QUIC_FLAG
......
...@@ -16,7 +16,7 @@ ...@@ -16,7 +16,7 @@
#include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h" #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h"
#include "net/third_party/quiche/src/quic/platform/api/quic_export.h" #include "net/third_party/quiche/src/quic/platform/api/quic_export.h"
#define QUIC_FLAG(type, flag, value) QUIC_EXPORT_PRIVATE extern type flag; #define QUIC_FLAG(flag, value) QUIC_EXPORT_PRIVATE extern bool flag;
#include "net/quic/quic_flags_list.h" #include "net/quic/quic_flags_list.h"
#undef QUIC_FLAG #undef QUIC_FLAG
......
...@@ -8,13 +8,13 @@ ...@@ -8,13 +8,13 @@
#include "base/path_service.h" #include "base/path_service.h"
QuicFlagSaverImpl::QuicFlagSaverImpl() { QuicFlagSaverImpl::QuicFlagSaverImpl() {
#define QUIC_FLAG(type, flag, value) saved_##flag##_ = flag; #define QUIC_FLAG(flag, value) saved_##flag##_ = flag;
#include "net/quic/quic_flags_list.h" #include "net/quic/quic_flags_list.h"
#undef QUIC_FLAG #undef QUIC_FLAG
} }
QuicFlagSaverImpl::~QuicFlagSaverImpl() { QuicFlagSaverImpl::~QuicFlagSaverImpl() {
#define QUIC_FLAG(type, flag, value) flag = saved_##flag##_; #define QUIC_FLAG(flag, value) flag = saved_##flag##_;
#include "net/quic/quic_flags_list.h" #include "net/quic/quic_flags_list.h"
#undef QUIC_FLAG #undef QUIC_FLAG
} }
......
...@@ -21,7 +21,7 @@ class QuicFlagSaverImpl { ...@@ -21,7 +21,7 @@ class QuicFlagSaverImpl {
~QuicFlagSaverImpl(); ~QuicFlagSaverImpl();
private: private:
#define QUIC_FLAG(type, flag, value) type saved_##flag##_; #define QUIC_FLAG(flag, value) bool saved_##flag##_;
#include "net/quic/quic_flags_list.h" #include "net/quic/quic_flags_list.h"
#undef QUIC_FLAG #undef QUIC_FLAG
}; };
...@@ -30,7 +30,7 @@ class QuicFlagSaverImpl { ...@@ -30,7 +30,7 @@ class QuicFlagSaverImpl {
class QuicFlagChecker { class QuicFlagChecker {
public: public:
QuicFlagChecker() { QuicFlagChecker() {
#define QUIC_FLAG(type, flag, value) \ #define QUIC_FLAG(flag, value) \
CHECK_EQ(value, flag) \ CHECK_EQ(value, flag) \
<< "Flag set to an unexpected value. A prior test is likely " \ << "Flag set to an unexpected value. A prior test is likely " \
<< "setting a flag without using a QuicFlagSaver. Use QuicTest to " \ << "setting a flag without using a QuicFlagSaver. Use QuicTest to " \
......
This diff is collapsed.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment