Remove obsolete flags from quic_flags_list.h

Remove two obsolete flags: FLAGS_quic_bbr_rtt_variation_weight and
FLAGS_quic_ietf_draft_version.

Every remaining flag is a reloadable flag or a restart flag, all
Boolean.  Remove type argument.

Change-Id: I0b9d6db33b82968c05aa8025d86921f1df7a29b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502751Reviewed-by: David Schinazi <dschinazi@chromium.org>
Reviewed-by: Victor Vasiliev <vasilvv@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821330}

net/quic/platform/impl/quic_flags_impl.cc

@@ -21,7 +21,7 @@
 #include "build/build_config.h"
 #include "net/third_party/quiche/src/quic/platform/api/quic_logging.h"
 
-#define QUIC_FLAG(type, flag, value) type flag = value;
+#define QUIC_FLAG(flag, value) bool flag = value;
 #include "net/quic/quic_flags_list.h"
 #undef QUIC_FLAG
 
@@ -304,10 +304,10 @@ void SetQuicFlagByName_int64_t(int64_t* flag, const std::string& value) {
 }  // namespace
 
 void SetQuicFlagByName(const std::string& flag_name, const std::string& value) {
-#define QUIC_FLAG(type, flag, default_value) \
-  if (flag_name == #flag) {                  \
-    SetQuicFlagByName_##type(&flag, value);  \
-    return;                                  \
+#define QUIC_FLAG(flag, default_value)    \
+  if (flag_name == #flag) {               \
+    SetQuicFlagByName_bool(&flag, value); \
+    return;                               \
   }
 #include "net/quic/quic_flags_list.h"
 #undef QUIC_FLAG

net/quic/platform/impl/quic_flags_impl.h

@@ -16,7 +16,7 @@
 #include "net/third_party/quiche/src/common/platform/api/quiche_string_piece.h"
 #include "net/third_party/quiche/src/quic/platform/api/quic_export.h"
 
-#define QUIC_FLAG(type, flag, value) QUIC_EXPORT_PRIVATE extern type flag;
+#define QUIC_FLAG(flag, value) QUIC_EXPORT_PRIVATE extern bool flag;
 #include "net/quic/quic_flags_list.h"
 #undef QUIC_FLAG
 

net/quic/platform/impl/quic_test_impl.cc

@@ -8,13 +8,13 @@
 #include "base/path_service.h"
 
 QuicFlagSaverImpl::QuicFlagSaverImpl() {
-#define QUIC_FLAG(type, flag, value) saved_##flag##_ = flag;
+#define QUIC_FLAG(flag, value) saved_##flag##_ = flag;
 #include "net/quic/quic_flags_list.h"
 #undef QUIC_FLAG
 }
 
 QuicFlagSaverImpl::~QuicFlagSaverImpl() {
-#define QUIC_FLAG(type, flag, value) flag = saved_##flag##_;
+#define QUIC_FLAG(flag, value) flag = saved_##flag##_;
 #include "net/quic/quic_flags_list.h"
 #undef QUIC_FLAG
 }

net/quic/platform/impl/quic_test_impl.h

@@ -21,7 +21,7 @@ class QuicFlagSaverImpl {
   ~QuicFlagSaverImpl();
 
  private:
-#define QUIC_FLAG(type, flag, value) type saved_##flag##_;
+#define QUIC_FLAG(flag, value) bool saved_##flag##_;
 #include "net/quic/quic_flags_list.h"
 #undef QUIC_FLAG
 };
@@ -30,7 +30,7 @@ class QuicFlagSaverImpl {
 class QuicFlagChecker {
  public:
   QuicFlagChecker() {
-#define QUIC_FLAG(type, flag, value)                                      \
+#define QUIC_FLAG(flag, value)                                            \
   CHECK_EQ(value, flag)                                                   \
       << "Flag set to an unexpected value.  A prior test is likely "      \
       << "setting a flag without using a QuicFlagSaver. Use QuicTest to " \