[iOS] cleanup, remove -[SceneController openUrlFromSettings:]

-[SceneController openUrlFromSettings:] is only used by
-[SceneController closeSettingsUIAndOpenURL:]. So the code from
|openUrlFromSettings:| is moved into |closeSettingsUIAndOpenURL:|.

Change-Id: Idd6c58f0d813f3b6412148e21d424ec9c4567c5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550813
Auto-Submit: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830166}

ios/chrome/browser/ui/main/scene_controller.mm

@@ -982,7 +982,17 @@ const char kMultiWindowOpenInNewWindowHistogram[] =
 
 // Opens an url from a link in the settings UI.
 - (void)closeSettingsUIAndOpenURL:(OpenNewTabCommand*)command {
-  [self openUrlFromSettings:command];
+  DCHECK([command fromChrome]);
+  UrlLoadParams params = UrlLoadParams::InNewTab([command URL]);
+  params.web_params.transition_type = ui::PAGE_TRANSITION_TYPED;
+  ProceduralBlock completion = ^{
+    [self dismissModalsAndOpenSelectedTabInMode:ApplicationModeForTabOpening::
+                                                    NORMAL
+                              withUrlLoadParams:params
+                                 dismissOmnibox:YES
+                                     completion:nil];
+  };
+  [self closeSettingsAnimated:YES completion:completion];
 }
 
 - (void)closeSettingsUI {
@@ -1426,22 +1436,6 @@ const char kMultiWindowOpenInNewWindowHistogram[] =
                                  completion:nil];
 }
 
-#pragma mark - ApplicationCommandsHelpers
-
-- (void)openUrlFromSettings:(OpenNewTabCommand*)command {
-  DCHECK([command fromChrome]);
-  UrlLoadParams params = UrlLoadParams::InNewTab([command URL]);
-  params.web_params.transition_type = ui::PAGE_TRANSITION_TYPED;
-  ProceduralBlock completion = ^{
-    [self dismissModalsAndOpenSelectedTabInMode:ApplicationModeForTabOpening::
-                                                    NORMAL
-                              withUrlLoadParams:params
-                                 dismissOmnibox:YES
-                                     completion:nil];
-  };
-  [self closeSettingsAnimated:YES completion:completion];
-}
-
 #pragma mark - UserFeedbackDataSource
 
 - (BOOL)currentPageIsIncognito {