Commit ce848de5 authored by Jonathan Freed's avatar Jonathan Freed Committed by Commit Bot

Adding PREFETCH_METADATA capability to Feed requests.

Bug: b/166660507
Change-Id: If94ef5636812508796fd66fa3b5ad58beda439ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390945
Commit-Queue: Jonathan Freed <freedjm@chromium.org>
Reviewed-by: default avatarDan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803932}
parent a82ccc10
......@@ -9,7 +9,6 @@ package feedwire;
option optimize_for = LITE_RUNTIME;
// Feature capability of either the client or the server.
// Next ID: 20
enum Capability {
UNKNOWN_CAPABILITY = 0;
// The client is capable of a basic UI.
......@@ -28,4 +27,5 @@ enum Capability {
REQUEST_SCHEDULE = 20;
OPEN_IN_TAB = 27;
DOWNLOAD_LINK = 28;
PREFETCH_METADATA = 43;
}
......@@ -118,6 +118,7 @@ feedwire::Request CreateFeedQueryRequest(
feedwire::FeedRequest& feed_request = *request.mutable_feed_request();
feed_request.add_client_capability(feedwire::Capability::BASE_UI);
feed_request.add_client_capability(feedwire::Capability::CARD_MENU);
feed_request.add_client_capability(feedwire::Capability::PREFETCH_METADATA);
for (auto capability : GetFeedConfig().experimental_capabilities)
feed_request.add_client_capability(capability);
......
......@@ -62,7 +62,7 @@ TEST(ProtoUtilTest, DefaultCapabilities) {
/*consistency_token=*/std::string())
.feed_request();
ASSERT_EQ(9, request.client_capability_size());
ASSERT_EQ(10, request.client_capability_size());
EXPECT_TRUE(HasCapability(request, feedwire::Capability::BASE_UI));
EXPECT_TRUE(HasCapability(request, feedwire::Capability::REQUEST_SCHEDULE));
EXPECT_TRUE(HasCapability(request, feedwire::Capability::OPEN_IN_TAB));
......@@ -73,6 +73,7 @@ TEST(ProtoUtilTest, DefaultCapabilities) {
EXPECT_TRUE(HasCapability(request, feedwire::Capability::UI_THEME_V2));
EXPECT_TRUE(
HasCapability(request, feedwire::Capability::UNDO_FOR_DISMISS_COMMAND));
EXPECT_TRUE(HasCapability(request, feedwire::Capability::PREFETCH_METADATA));
}
TEST(ProtoUtilTest, DisableCapabilitiesWithFinch) {
......@@ -88,7 +89,7 @@ TEST(ProtoUtilTest, DisableCapabilitiesWithFinch) {
/*consistency_token=*/std::string())
.feed_request();
ASSERT_EQ(8, request.client_capability_size());
ASSERT_EQ(9, request.client_capability_size());
// Optional capabilities can be disabled.
EXPECT_FALSE(HasCapability(request, feedwire::Capability::INFINITE_FEED));
......@@ -104,6 +105,7 @@ TEST(ProtoUtilTest, DisableCapabilitiesWithFinch) {
EXPECT_TRUE(HasCapability(request, feedwire::Capability::UI_THEME_V2));
EXPECT_TRUE(
HasCapability(request, feedwire::Capability::UNDO_FOR_DISMISS_COMMAND));
EXPECT_TRUE(HasCapability(request, feedwire::Capability::PREFETCH_METADATA));
}
} // namespace
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment