Commit ce8ed77b authored by Lei Zhang's avatar Lei Zhang Committed by Commit Bot

Fix dependency for third_party/blink/renderer/bindings/modules/v8.

The v8 binding target has generated sources like
gen/third_party/blink/renderer/bindings/modules/v8/v8_media_recorder.cc
that then includes third_party/blink/renderer/modules/mediarecorder
headers. These headers use buildflags.h and all buildflags.h files are
generated. Thus for v8_media_recorder.cc to build, it needs to depend
on //third_party/blink/renderer/modules/mediarecorder:buildflags, but
that dependency is missing.

To fix this, add a dependency from
//third_party/blink/renderer/core:prerequisites, which is responsible
for generating all necessary C++ source code to
//third_party/blink/renderer/modules/mediarecorder:buildflags.

Bug: 1139543
Change-Id: If48a33cf4b5deb5bc66a8c21612eff924da774f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482030
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: default avatarYuki Shiino <yukishiino@chromium.org>
Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820399}
parent ae9ba2ec
...@@ -256,6 +256,7 @@ group("make_modules_generated") { ...@@ -256,6 +256,7 @@ group("make_modules_generated") {
"//third_party/blink/renderer/bindings/modules:bindings_modules_generated", "//third_party/blink/renderer/bindings/modules:bindings_modules_generated",
"//third_party/blink/renderer/bindings/modules/v8:generated", "//third_party/blink/renderer/bindings/modules/v8:generated",
"//third_party/blink/renderer/core:core_event_interfaces", "//third_party/blink/renderer/core:core_event_interfaces",
"//third_party/blink/renderer/modules/mediarecorder:buildflags",
] ]
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment